From e9d1613b8ab17fa96630246fa8333ab1c2923837 Mon Sep 17 00:00:00 2001
From: Edwin Betancourt <EdwinBetanc0urt@outlook.com>
Date: Sun, 21 Mar 2021 19:03:07 -0400
Subject: [PATCH] fix: Unnecesarily loop in the static menu. (#660)

* fix: Unnecesarily loop in the static menu.

* change visivility with dinamic attribute.

* Update menu.js

Co-authored-by: EdwinBetanc0urt <EdwinBetanco0urt@outlook.com>
---
 src/router/modules/ADempiere/menu.js | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/src/router/modules/ADempiere/menu.js b/src/router/modules/ADempiere/menu.js
index 1824de49..2f5ef623 100644
--- a/src/router/modules/ADempiere/menu.js
+++ b/src/router/modules/ADempiere/menu.js
@@ -157,13 +157,21 @@ function getRouteFromMenuItem({ menu, roleUuid, organizationUuid }) {
  * @author elsiosanchez <elsiosanches@gmail.com>
  * @param {object} staticRoutes static routes
  * @param {object} permiseRole role permissions
+ * @returns {object} routes with hidden/show
  */
 function hidenStactiRoutes({ staticRoutes, permiseRole }) {
+  const { isAllowInfoProduct } = permiseRole
+  if (!isAllowInfoProduct) {
+    // does not change the hidden visibility of ProductInfo
+    return staticRoutes
+  }
+
   return staticRoutes.map(route => {
     if (route.path === '/ProductInfo') {
       return {
         ...route,
-        hidden: !permiseRole.isAllowInfoProduct
+        // is hidden by default, change to be visible
+        hidden: !isAllowInfoProduct
       }
     }
     return {