fix: Print formats unnecessary request. (#414)

src/components/ADempiere/ContextMenu/contextMenuMobile.vue

@@ -130,7 +130,6 @@ export default {
   mixins: [contextMixin],
   computed: {
     isPanelTypeMobile() {
-      console.log(this.panelType, this.$route.meta.type)
       if (this.$route.meta.type === 'process' || this.$route.meta.type === 'report') {
         return true
       }

src/lang/ADempiere/es.js

@@ -170,7 +170,7 @@ export default {
   },
   report: {
     ExportXlsx: '(xlsx) Extencion de Archivo Excel',
-    ExportXls: '(xls)  Archivo Excel ',
+    ExportXls: '(xls) Archivo Excel',
     ExporXml: '(xml) Archivo Lenguaje de marcas Extensible',
     ExporCsv: '(csv) Archivo Separado por Coma',
     ExportTxt: '(txt) Archivo de Texto Delimitado por Tabuladores',

src/store/modules/ADempiere/browser.js

@@ -116,6 +116,24 @@ const browser = {
                 }
               })
 
+            // Panel for save on store
+            const newBrowser = {
+              ...browserResponse,
+              containerUuid,
+              fieldList: fieldsList,
+              panelType,
+              // app attributes
+              awaitForValues, // control to values
+              awaitForValuesToQuery: awaitForValues, // get values from request search
+              isShowedCriteria,
+              isShowedTotals: true
+            }
+
+            commit('addBrowser', newBrowser)
+            dispatch('addPanel', newBrowser)
+
+            resolve(newBrowser)
+
             // Convert from gRPC process list
             const actions = []
             if (process) {
@@ -140,28 +158,8 @@ const browser = {
             // Add process menu
             dispatch('setContextMenu', {
               containerUuid,
-              relations: [],
+              actions
-              actions,
-              references: []
             })
-
-            // Panel for save on store
-            const newBrowser = {
-              ...browserResponse,
-              containerUuid,
-              fieldList: fieldsList,
-              panelType,
-              // app attributes
-              awaitForValues, // control to values
-              awaitForValuesToQuery: awaitForValues, // get values from request search
-              isShowedCriteria,
-              isShowedTotals: true
-            }
-
-            commit('addBrowser', newBrowser)
-            dispatch('addPanel', newBrowser)
-
-            resolve(newBrowser)
           })
           .catch(error => {
             router.push({ path: '/dashboard' })

src/store/modules/ADempiere/contextMenu.js

@@ -10,8 +10,6 @@ import { requestListDocumentActions, requestListDocumentStatuses } from '@/api/A
 //     relations: [],
 //     actions: [],
 //     references: []
-//     defaultAction: {},
-//     lastAction: {}
 //   }
 // ]
 const initStateContextMenu = {
@@ -50,8 +48,25 @@ const contextMenu = {
     }
   },
   actions: {
-    setContextMenu({ commit }, payload) {
+    /**
-      commit('setContextMenu', payload)
+     * Sub menu associated with panel
+     * @param {string} containerUuid
+     * @param {array}  relations
+     * @param {array}  actions
+     * @param {array}  references
+     */
+    setContextMenu({ commit }, {
+      containerUuid,
+      relations = [],
+      actions = [],
+      references = []
+    }) {
+      commit('setContextMenu', {
+        containerUuid,
+        relations,
+        actions,
+        references
+      })
     },
     /**
      * TODO: Verify tableName params to change in constant

src/store/modules/ADempiere/process.js

@@ -18,7 +18,7 @@ const process = {
   },
   actions: {
     /**
-     *
+     * Get process metadata from server
      * @param {string} containerUuid
      * @param {object} routeToDelete, route to close in tagView when fail
      */
@@ -26,31 +26,32 @@ const process = {
       containerUuid,
       routeToDelete
     }) {
-      let printFormatsAvailable
-      dispatch('requestPrintFormats', {
-        processUuid: containerUuid
-      })
-        .then(response => {
-          printFormatsAvailable = response
-        })
       return new Promise(resolve => {
         getProcessMetadata(containerUuid)
-          .then(responseProcess => {
+          .then(async responseProcess => {
-            responseProcess.printFormatsAvailable = printFormatsAvailable
+            let printFormatsAvailable = []
-            const { processDefinition, actions } = generateProcess({
+            if (responseProcess.isReport) {
-              processToGenerate: responseProcess
+              printFormatsAvailable = await dispatch('requestPrintFormats', {
+                processUuid: containerUuid
               })
+            }
+
+            const { processDefinition, actions } = generateProcess({
+              processToGenerate: {
+                ...responseProcess,
+                printFormatsAvailable
+              }
+            })
+
             dispatch('addPanel', processDefinition)
             commit('addProcess', processDefinition)
+            resolve(processDefinition)
 
             //  Add process menu
             dispatch('setContextMenu', {
               containerUuid,
-              relations: [],
+              actions
-              actions,
-              references: []
             })
-            resolve(processDefinition)
           })
           .catch(error => {
             router.push({
@@ -79,16 +80,13 @@ const process = {
 
         dispatch('addPanel', processDefinition)
         commit('addProcess', processDefinition)
+        resolve(processDefinition)
 
         //  Add process menu
         dispatch('setContextMenu', {
           containerUuid: processDefinition.uuid,
-          relations: [],
+          actions
-          actions,
-          references: []
         })
-
-        resolve(processDefinition)
       })
     }
   },

src/store/modules/ADempiere/reportControl.js

@@ -38,7 +38,8 @@ const reportControl = {
       processUuid,
       instanceUuid
     }) {
-      return requestPrintFormats({ processUuid })
+      return new Promise(resolve => {
+        requestPrintFormats({ processUuid })
           .then(printFormatResponse => {
             const printFormatList = printFormatResponse.printFormatsList.map(printFormatItem => {
               return {
@@ -54,11 +55,13 @@ const reportControl = {
               containerUuid: processUuid,
               printFormatList
             })
-          return printFormatList
+
+            resolve(printFormatList)
           })
           .catch(error => {
             console.warn(`Error getting print formats: ${error.message}. Code: ${error.code}.`)
           })
+      })
     },
     requestReportViews({ commit }, {
       processId,
@@ -66,7 +69,8 @@ const reportControl = {
       instanceUuid,
       printFormatUuid
     }) {
-      return requestReportViews({ processUuid })
+      return new Promise(resolve => {
+        requestReportViews({ processUuid })
           .then(reportViewResponse => {
             const reportViewList = reportViewResponse.reportViewsList.map(reportViewItem => {
               return {
@@ -83,11 +87,13 @@ const reportControl = {
               containerUuid: processUuid,
               viewList: reportViewList
             })
-          return reportViewList
+
+            resolve(reportViewList)
           })
           .catch(error => {
             console.warn(`Error getting report views: ${error.message}. Code: ${error.code}.`)
           })
+      })
     },
     requestDrillTables({ commit }, {
       processId,
@@ -97,7 +103,8 @@ const reportControl = {
       tableName,
       reportViewUuid
     }) {
-      return requestDrillTables({ tableName })
+      return new Promise(resolve => {
+        requestDrillTables({ tableName })
           .then(responseDrillTables => {
             const drillTablesList = responseDrillTables.drillTablesList.map(drillTableItem => {
               return {
@@ -116,17 +123,15 @@ const reportControl = {
               containerUuid: processUuid,
               drillTablesList
             })
-          return drillTablesList
+
+            resolve(drillTablesList)
           })
           .catch(error => {
             console.warn(`Error getting drill tables: ${error.message}. Code: ${error.code}.`)
           })
+      })
     },
-    getReportOutputFromServer({ commit, getters, rootGetters }, parameters) {
+    getReportOutputFromServer({ commit, getters, rootGetters }, {
-      if (isEmptyValue(parameters.printFormatUuid)) {
-        parameters.printFormatUuid = getters.getDefaultPrintFormat(parameters.processUuid).printFormatUuid
-      }
-      const {
       tableName,
       printFormatUuid,
       reportViewUuid,
@@ -137,9 +142,14 @@ const reportControl = {
       processId,
       instanceUuid,
       option
-      } = parameters
+    }) {
+      if (isEmptyValue(printFormatUuid)) {
+        printFormatUuid = getters.getDefaultPrintFormat(processUuid).printFormatUuid
+      }
+
       const parametersList = rootGetters.getParametersToServer({ containerUuid: processUuid })
-      return getReportOutput({
+      return new Promise(resolve => {
+        getReportOutput({
           parametersList,
           printFormatUuid,
           reportViewUuid,
@@ -151,42 +161,20 @@ const reportControl = {
           .then(response => {
             const reportOutput = {
               ...response,
-            processId: processId,
+              processId,
-            processUuid: processUuid,
+              processUuid,
               isError: false,
-            instanceUuid: instanceUuid,
+              instanceUuid,
               isReport: true,
               option: option
             }
             commit('setNewReportOutput', reportOutput)
-          return reportOutput
+
+            resolve(reportOutput)
           })
           .catch(error => {
-          const reportOutput = {
-            uuid: '',
-            processName: '',
-            description: '',
-            fileName: '',
-            output: '',
-            mimeType: '',
-            dataCols: null,
-            dataRows: null,
-            headerName: '',
-            footerName: '',
-            printFormatUuid: '',
-            reportViewUuid: '',
-            tableName: '',
-            outputStream: [],
-            reportType: '',
-            processId: null,
-            processUuid: '',
-            isError: true,
-            instanceUuid: '',
-            isReport: true,
-            option: ''
-          }
             console.warn(`Error getting report output: ${error.message}. Code: ${error.code}.`)
-          return reportOutput
+          })
       })
     }
   },

src/store/modules/ADempiere/window.js

@@ -189,9 +189,7 @@ const window = {
             //  Add process menu
             dispatch('setContextMenu', {
               containerUuid: tab.uuid,
-              relations: [],
+              actions: actions
-              actions: actions,
-              references: []
             })
 
             if (tab.isParentTab) {