From 7f742350733b3775c599bf413084376a9ea077f0 Mon Sep 17 00:00:00 2001 From: EdwinBetanc0urt Date: Mon, 10 Feb 2020 21:13:19 -0400 Subject: [PATCH] Refactor code, remove unused methods and optimized application. (#318) * Refactor code, remove unused methods and optimized application. * Delete redundant action's, and some deprecated. * Optimize delete record container to panels in window. * fix delete tag view when change roles. --- .../ADempiere/ContextMenu/contextMenuMixin.js | 7 +- src/components/ADempiere/DataTable/index.vue | 107 ++----- .../ADempiere/DataTable/menu/contextMenu.vue | 4 +- .../ADempiere/DataTable/menu/index.vue | 4 +- .../ADempiere/DataTable/menu/mixinMenu.js | 26 +- src/components/ADempiere/Dropdown/index.vue | 13 +- .../ADempiere/Field/FieldSelect.vue | 5 +- src/components/ADempiere/Field/index.vue | 11 +- src/components/ADempiere/Panel/detail.vue | 277 ------------------ src/components/ADempiere/Panel/index.vue | 89 +++--- src/components/ADempiere/Tab/index.vue | 28 +- src/components/ADempiere/Tab/tabChildren.vue | 15 +- src/components/ADempiere/Tab/tabMixin.js | 27 +- src/layout/components/AppMain.vue | 25 ++ src/layout/components/TagsView/index.vue | 50 ++-- src/store/modules/ADempiere/browser.js | 68 +++-- src/store/modules/ADempiere/data.js | 6 +- .../modules/ADempiere/languageControl.js | 3 +- src/store/modules/ADempiere/lookup.js | 10 +- src/store/modules/ADempiere/panel.js | 273 ++++++++--------- src/store/modules/ADempiere/process.js | 4 +- src/store/modules/ADempiere/utils.js | 42 ++- src/store/modules/ADempiere/window.js | 58 ++-- src/store/modules/ADempiere/windowControl.js | 93 +++--- src/store/modules/user.js | 56 ++-- src/utils/ADempiere/dictionaryUtils.js | 2 +- src/views/ADempiere/Browser/index.vue | 34 +-- src/views/ADempiere/ReportViewer/index.vue | 30 +- src/views/ADempiere/Window/index.vue | 126 ++++---- src/views/profile/components/RolesNavbar.vue | 18 +- src/views/profile/components/role.vue | 21 +- 31 files changed, 607 insertions(+), 925 deletions(-) delete mode 100644 src/components/ADempiere/Panel/detail.vue diff --git a/src/components/ADempiere/ContextMenu/contextMenuMixin.js b/src/components/ADempiere/ContextMenu/contextMenuMixin.js index 3975f1be..81c59c5c 100644 --- a/src/components/ADempiere/ContextMenu/contextMenuMixin.js +++ b/src/components/ADempiere/ContextMenu/contextMenuMixin.js @@ -336,6 +336,7 @@ export const contextMixin = { return } + // TODO: Add store attribute to avoid making repeated requests if (this.panelType === 'window' && !this.isEmptyValue(this.$route.params.tableName)) { this.$store.dispatch('getPrivateAccessFromServer', { tableName: this.$route.params.tableName, @@ -447,12 +448,6 @@ export const contextMixin = { .catch(error => { console.warn(error) }) - if (this.panelType === 'process') { - // TODO: Verify use - this.$store.dispatch('deleteRecordContainer', { - viewUuid: this.$route - }) - } } else { this.showNotification({ type: 'warning', diff --git a/src/components/ADempiere/DataTable/index.vue b/src/components/ADempiere/DataTable/index.vue index b6c8afe2..2770c89a 100644 --- a/src/components/ADempiere/DataTable/index.vue +++ b/src/components/ADempiere/DataTable/index.vue @@ -4,8 +4,7 @@ { + this.$store.dispatch('setRecordSelection', { + parentUuid: this.parentUuid, + containerUuid: this.containerUuid, + panelType: this.panelType + }) + }) }, callOffNewRecord() { this.getterDataRecords.shift() @@ -1012,27 +982,6 @@ export default { this.$refs.headerSearchSelect && this.$refs.headerSearchSelect.focus() } }, - activeAdvancedQuery(value) { - this.isAdvancedQuery = value - if (value) { - this.$store.dispatch('setOldAction', this.$route.query.action) - this.$router.push({ - query: { - ...this.$route.query, - action: 'advancedQuery' - } - }) - } - if (!value) { - const oldAction = this.$store.getters.getOldAction - this.$router.push({ - query: { - ...this.$route.query, - action: oldAction - } - }) - } - }, getFieldDefinition(fieldDefinition, row) { let styleSheet = '' if (fieldDefinition && (fieldDefinition.id !== null || fieldDefinition.conditionsList.length)) { diff --git a/src/components/ADempiere/DataTable/menu/contextMenu.vue b/src/components/ADempiere/DataTable/menu/contextMenu.vue index 98b4a208..7c7b7710 100644 --- a/src/components/ADempiere/DataTable/menu/contextMenu.vue +++ b/src/components/ADempiere/DataTable/menu/contextMenu.vue @@ -12,7 +12,7 @@ > {{ $t('components.contextMennuWindowReport') }} -