From 5a38ada7705015f51ff80671a7312f31a251a0be Mon Sep 17 00:00:00 2001
From: EdwinBetanc0urt <EdwinBetanc0urt@hotmail.com>
Date: Wed, 29 Jan 2020 17:30:53 -0400
Subject: [PATCH] fix: Undefined method. (#285)

---
 .../ContextMenu/contextMenuDesktop.vue        | 16 +++++++++--
 .../ContextMenu/contextMenuMobile.vue         | 20 ++++++++++---
 .../ADempiere/ContextMenu/items.vue           | 28 +++++++++++--------
 src/components/ADempiere/Field/FieldMixin.js  |  6 +++-
 .../ADempiere/Field/FieldSelect.vue           |  1 +
 src/components/ADempiere/Field/index.vue      |  4 ++-
 src/store/modules/ADempiere/panel.js          |  9 ++++--
 src/store/modules/ADempiere/processControl.js |  5 +++-
 src/store/modules/user.js                     |  4 +--
 9 files changed, 68 insertions(+), 25 deletions(-)

diff --git a/src/components/ADempiere/ContextMenu/contextMenuDesktop.vue b/src/components/ADempiere/ContextMenu/contextMenuDesktop.vue
index 1d333e41..4822357a 100644
--- a/src/components/ADempiere/ContextMenu/contextMenuDesktop.vue
+++ b/src/components/ADempiere/ContextMenu/contextMenuDesktop.vue
@@ -1,6 +1,16 @@
 <template>
   <div class="container-submenu container-context-menu">
-    <el-menu v-shortkey="{f2: ['f2'], f3: ['f3'], f5: ['f5'], f3:['ctrl', 'd']}" :default-active="activeMenu" :router="false" class="el-menu-demo" mode="horizontal" menu-trigger="hover" unique-opened @select="typeFormat" @shortkey.native="actionContextMenu">
+    <el-menu
+      v-shortkey="{ f2: ['f2'], f3: ['f3'], f5: ['f5'], f3:['ctrl', 'd'] }"
+      :default-active="activeMenu"
+      :router="false"
+      class="el-menu-demo"
+      mode="horizontal"
+      menu-trigger="hover"
+      unique-opened
+      @select="typeFormat"
+      @shortkey.native="actionContextMenu"
+    >
       <template>
         <el-submenu v-if="relationsList !== undefined && relationsList.length" class="el-menu-item" index="1">
           <template slot="title">
@@ -55,7 +65,9 @@
             index="xlsx"
             @click.native="exporWindow('xlsx')"
           >
-            <template slot="title">{{ $t('components.contextMennuWindowReport') }}</template>
+            <template slot="title">
+              {{ $t('components.contextMennuWindowReport') }}
+            </template>
             <template v-for="(format, index) in option">
               <el-menu-item :key="index" :index="index">
                 {{ format }}
diff --git a/src/components/ADempiere/ContextMenu/contextMenuMobile.vue b/src/components/ADempiere/ContextMenu/contextMenuMobile.vue
index 0c108a73..b1769d6f 100644
--- a/src/components/ADempiere/ContextMenu/contextMenuMobile.vue
+++ b/src/components/ADempiere/ContextMenu/contextMenuMobile.vue
@@ -1,10 +1,20 @@
 <template>
   <div class="container-submenu-mobile container-context-menu">
     <right-menu>
-      <el-menu :default-active="activeMenu" :router="false" class="el-menu-demo" mode="vertical" menu-trigger="hover" unique-opened style="width: 258px; float: right;">
+      <el-menu
+        v-shortkey="{ f2: ['f2'], f3: ['f3'], f5: ['f5'], f3:['ctrl', 'd'] }"
+        :default-active="activeMenu"
+        :router="false"
+        class="el-menu-demo"
+        mode="vertical"
+        menu-trigger="hover"
+        unique-opened
+        style="width: 258px; float: right;"
+      >
         <el-submenu index="1">
           <template slot="title">
-            <svg-icon icon-class="tree" /> {{ $t('components.contextMenuRelations') }}
+            <svg-icon icon-class="tree" />
+            {{ $t('components.contextMenuRelations') }}
           </template>
           <el-menu-item-group>
             <el-scrollbar wrap-class="scroll">
@@ -14,7 +24,8 @@
         </el-submenu>
         <el-submenu index="2">
           <template slot="title">
-            <svg-icon icon-class="link" />{{ $t('components.contextMenuActions') }}
+            <svg-icon icon-class="link" />
+            {{ $t('components.contextMenuActions') }}
           </template>
           <el-menu-item-group>
             <el-scrollbar wrap-class="scroll">
@@ -28,7 +39,8 @@
                   </el-menu-item>
                 </el-submenu>
                 <el-menu-item v-else :key="index" :index="action.name" :disabled="action.disabled" @click="runAction(action)">
-                  <svg-icon v-if="action.type === 'process'" icon-class="component" /> {{ action.name }}
+                  <svg-icon v-if="action.type === 'process'" icon-class="component" />
+                  {{ action.name }}
                 </el-menu-item>
               </template>
               <el-menu-item v-show="isReport" index="4">
diff --git a/src/components/ADempiere/ContextMenu/items.vue b/src/components/ADempiere/ContextMenu/items.vue
index b6306212..e0df502a 100644
--- a/src/components/ADempiere/ContextMenu/items.vue
+++ b/src/components/ADempiere/ContextMenu/items.vue
@@ -1,22 +1,28 @@
 <template>
+  <el-submenu
+    v-if="item.meta.type === 'summary'"
+    key="is-summary"
+    :index="item.meta.title"
+    popper-append-to-body
+  >
+    <template slot="title">
+      <svg-icon v-if="isMobile" icon-class="nested" />
+      {{ item.meta.title }}
+    </template>
+    <item v-for="(child, subKey) in item.children" :key="subKey" :item="child">
+      {{ child.meta.title }}
+    </item>
+  </el-submenu>
   <el-menu-item
-    v-if="item.meta.type !== 'summary'"
-    v-show="item.meta.uuid!==$route.meta.uuid"
+    v-else
+    v-show="item.meta.uuid !== $route.meta.uuid"
+    key="not-summary"
     :index="item.meta.uuid"
     @click="handleClick(item)"
   >
     <svg-icon v-if="isMobile" :icon-class="classIconMenuRight" />
     {{ item.meta.title }}
   </el-menu-item>
-  <el-submenu v-else :index="item.meta.title" popper-append-to-body>
-    <template slot="title">
-      <svg-icon v-if="isMobile" icon-class="nested" />
-      {{ item.meta.title }}
-    </template>
-    <item v-for="(child, key) in item.children" :key="key" :item="child">
-      {{ child.meta.title }}
-    </item>
-  </el-submenu>
 </template>
 
 <script>
diff --git a/src/components/ADempiere/Field/FieldMixin.js b/src/components/ADempiere/Field/FieldMixin.js
index 0447e0fd..d421306f 100644
--- a/src/components/ADempiere/Field/FieldMixin.js
+++ b/src/components/ADempiere/Field/FieldMixin.js
@@ -23,7 +23,11 @@ export const fieldMixin = {
   },
   computed: {
     getterValue() {
-      const field = this.$store.getters.getFieldFromColumnName(this.metadata.containerUuid, this.metadata.columnName)
+      const field = this.$store.getters.getFieldFromColumnName({
+        containerUuid: this.metadata.containerUuid,
+        columnName: this.metadata.columnName,
+        isAdvancedQuery: this.metadata.isAdvancedQuery
+      })
       if (field) {
         return field.value
       }
diff --git a/src/components/ADempiere/Field/FieldSelect.vue b/src/components/ADempiere/Field/FieldSelect.vue
index b7d97fd7..821b9453 100644
--- a/src/components/ADempiere/Field/FieldSelect.vue
+++ b/src/components/ADempiere/Field/FieldSelect.vue
@@ -174,6 +174,7 @@ export default {
           if (this.isPanelWindow) {
             this.$store.dispatch('notifyFieldChangeDisplayColumn', {
               containerUuid: this.metadata.containerUuid,
+              isAdvancedQuery: this.metadata.isAdvancedQuery,
               columnName: this.metadata.columnName,
               displayColumn: responseLookupItem.label
             })
diff --git a/src/components/ADempiere/Field/index.vue b/src/components/ADempiere/Field/index.vue
index d17c07a7..e31ca9d1 100644
--- a/src/components/ADempiere/Field/index.vue
+++ b/src/components/ADempiere/Field/index.vue
@@ -165,7 +165,7 @@ export default {
       }
 
       const sizeField = this.field.sizeFieldFromType.size
-      var newSizes = {}
+      const newSizes = {}
 
       // in table set max width, used by browser result and tab children of window
       if (this.inTable) {
@@ -243,6 +243,7 @@ export default {
     this.field = this.metadataField
   },
   methods: {
+    showMessage,
     isDisplayed() {
       if (this.isAdvancedQuery) {
         return this.field.isShowedFromUser
@@ -347,6 +348,7 @@ export default {
   .custom-tittle-popover {
     font-size: 14px;
     font-weight: bold;
+    float: left;
   }
   /**
    * Separation between elements (item) of the form
diff --git a/src/store/modules/ADempiere/panel.js b/src/store/modules/ADempiere/panel.js
index 59a22528..0c7adb93 100644
--- a/src/store/modules/ADempiere/panel.js
+++ b/src/store/modules/ADempiere/panel.js
@@ -775,10 +775,11 @@ const panel = {
     },
     notifyFieldChangeDisplayColumn({ commit, getters }, {
       containerUuid,
+      isAdvancedQuery,
       columnName,
       displayColumn
     }) {
-      const field = getters.getFieldFromColumnName(containerUuid, columnName)
+      const field = getters.getFieldFromColumnName({ containerUuid, isAdvancedQuery, columnName })
       commit('changeFieldValue', {
         field: field,
         newValue: field.value,
@@ -864,8 +865,10 @@ const panel = {
       }
       return panel.fieldList
     },
-    getFieldFromColumnName: (state, getters) => (containerUuid, columnName) => {
-      return getters.getFieldsListFromPanel(containerUuid).find(itemField => itemField.columnName === columnName)
+    getFieldFromColumnName: (state, getters) => ({ containerUuid, isAdvancedQuery, columnName }) => {
+      return getters.getFieldsListFromPanel(containerUuid, isAdvancedQuery).find(itemField => {
+        return itemField.columnName === columnName
+      })
     },
     /**
      * Determinate if panel is ready fron send, all fiedls mandatory and displayed with values
diff --git a/src/store/modules/ADempiere/processControl.js b/src/store/modules/ADempiere/processControl.js
index 0db4f966..53b28437 100644
--- a/src/store/modules/ADempiere/processControl.js
+++ b/src/store/modules/ADempiere/processControl.js
@@ -157,7 +157,10 @@ const processControl = {
               } else {
                 tab = rootGetters.getTab(params.parentUuid, params.containerUuid)
                 tableName = tab.tableName
-                const field = rootGetters.getFieldFromColumnName(params.containerUuid, tableName + '_ID')
+                const field = rootGetters.getFieldFromColumnName({
+                  containerUuid: params.containerUuid,
+                  columnName: `${tableName}_ID`
+                })
                 recordId = field.value
               }
             }
diff --git a/src/store/modules/user.js b/src/store/modules/user.js
index 7f482af0..12b0cb05 100644
--- a/src/store/modules/user.js
+++ b/src/store/modules/user.js
@@ -54,7 +54,7 @@ const actions = {
   login({ commit }, userInfo) {
     const { userName, password } = userInfo
     return new Promise((resolve, reject) => {
-      login({ userName: userName.trim(), password: password })
+      login({ userName, password })
         .then(logInResponse => {
           const { uuid: token } = logInResponse
 
@@ -236,7 +236,7 @@ const actions = {
           message: error.message,
           type: 'error'
         })
-        console.warn(`Error change role: ${error.message}. Code: ${error.code}`)
+        console.warn(`Error change role: ${error.message}. Code: ${error.code}.`)
       })
     //  return new Promise(async resolve => {
     //  const token = role