From 31e6b7b3c849565d2f2e642e66f6edef247f2d3b Mon Sep 17 00:00:00 2001
From: Edwin Betancourt <EdwinBetanc0urt@outlook.com>
Date: Thu, 25 Mar 2021 11:24:55 -0400
Subject: [PATCH] fix: Field isActive not edit with false value. (#693)

* fix: Field isActive not edit with false value.

* fix changed record is active.

Co-authored-by: EdwinBetanc0urt <EdwinBetanco0urt@outlook.com>
---
 .../ADempiere/DataTable/dataTables-Script.js  |  4 +-
 src/components/ADempiere/Field/FieldYesNo.vue | 33 ++++++------
 src/store/modules/ADempiere/panel/actions.js  | 54 +++++++++++++------
 src/utils/ADempiere/references.js             | 50 ++++++++++-------
 4 files changed, 90 insertions(+), 51 deletions(-)

diff --git a/src/components/ADempiere/DataTable/dataTables-Script.js b/src/components/ADempiere/DataTable/dataTables-Script.js
index c608b99b..6a78c7f7 100644
--- a/src/components/ADempiere/DataTable/dataTables-Script.js
+++ b/src/components/ADempiere/DataTable/dataTables-Script.js
@@ -8,7 +8,7 @@ import IconElement from '@/components/ADempiere/IconElement'
 import { formatField } from '@/utils/ADempiere/valueFormat'
 import MainPanel from '@/components/ADempiere/Panel'
 import { sortFields } from '@/utils/ADempiere/dictionaryUtils'
-import { FIELDS_DECIMALS, FIELDS_QUANTITY, FIELDS_READ_ONLY_FORM } from '@/utils/ADempiere/references'
+import { FIELDS_DECIMALS, FIELDS_QUANTITY, COLUMNS_READ_ONLY_FORM } from '@/utils/ADempiere/references'
 import { LOG_COLUMNS_NAME_LIST } from '@/utils/ADempiere/dataUtils.js'
 import { fieldIsDisplayed } from '@/utils/ADempiere'
 import evaluator from '@/utils/ADempiere/evaluator'
@@ -407,7 +407,7 @@ export default {
       }
       if (fieldIsDisplayed(field)) {
         // columnName: IsActive
-        const fieldReadOnlyForm = FIELDS_READ_ONLY_FORM.find(item => {
+        const fieldReadOnlyForm = COLUMNS_READ_ONLY_FORM.find(item => {
           return !item.isChangedAllForm &&
             // columnName: IsActive, Processed, Processing
             Object.prototype.hasOwnProperty.call(row, item.columnName)
diff --git a/src/components/ADempiere/Field/FieldYesNo.vue b/src/components/ADempiere/Field/FieldYesNo.vue
index 381c0a42..f6ac29fd 100644
--- a/src/components/ADempiere/Field/FieldYesNo.vue
+++ b/src/components/ADempiere/Field/FieldYesNo.vue
@@ -16,23 +16,15 @@
 
 <script>
 import { fieldIsDisplayed } from '@/utils/ADempiere'
-import { FIELDS_READ_ONLY_FORM } from '@/utils/ADempiere/references'
+import { COLUMNS_READ_ONLY_FORM } from '@/utils/ADempiere/references'
 import fieldMixin from '@/components/ADempiere/Field/mixin/mixinField.js'
 import { convertStringToBoolean } from '@/utils/ADempiere/valueFormat.js'
 
 export default {
   name: 'FieldYesNo',
-  mixins: [fieldMixin],
-  data() {
-    return {
-      valuesReadOnly: [
-        {
-          columnName: 'IsActive',
-          isReadOnlyValue: false
-        }
-      ]
-    }
-  },
+  mixins: [
+    fieldMixin
+  ],
   computed: {
     cssClassStyle() {
       let styleClass = ' custom-field-yes-no '
@@ -40,6 +32,16 @@ export default {
         styleClass += this.metadata.cssClassName
       }
       return styleClass
+    },
+    columnReadOnlyForm() {
+      return COLUMNS_READ_ONLY_FORM.find(item => {
+        return item.columnName === this.metadata.columnName
+      })
+    }
+  },
+  mounted() {
+    if (!this.isEmptyValue(this.columnReadOnlyForm)) {
+      this.isReadOnlyForm(this.value)
     }
   },
   methods: {
@@ -53,12 +55,13 @@ export default {
       }
     },
     isReadOnlyForm(value) {
-      const fieldReadOnlyForm = FIELDS_READ_ONLY_FORM.find(item => item.columnName === this.metadata.columnName)
+      const fieldReadOnlyForm = this.columnReadOnlyForm
+
       // columnName: IsActive, Processed, Processing
-      if (fieldReadOnlyForm && fieldIsDisplayed(this.metadata)) {
+      if (!this.isEmptyValue(fieldReadOnlyForm) && fieldIsDisplayed(this.metadata)) {
         const fieldsExcludes = []
         // if isChangedAllForm it does not exclude anything, otherwise it excludes this columnName
-        if (fieldReadOnlyForm.isChangedAllForm) {
+        if (!fieldReadOnlyForm.isChangedAllForm) {
           fieldsExcludes.push(this.metadata.columnName)
         }
 
diff --git a/src/store/modules/ADempiere/panel/actions.js b/src/store/modules/ADempiere/panel/actions.js
index b573a063..f4102653 100644
--- a/src/store/modules/ADempiere/panel/actions.js
+++ b/src/store/modules/ADempiere/panel/actions.js
@@ -274,6 +274,7 @@ const actions = {
       valueAttribute: true
     })
   },
+
   /**
    * Set default values to panel
    * @param {string}  parentUuid
@@ -356,31 +357,54 @@ const actions = {
         attributes: defaultAttributes
       })
         .then(() => {
-          if (['browser', 'form', 'process', 'report'].includes(panelType)) {
-          // const fieldsUser = []
-            panel.fieldsList.forEach(itemField => {
-              if (!itemField.isAdvancedQuery || itemField.isActiveLogics) {
+          const windowPanel = (itemField) => {
+            if (!itemField.isAdvancedQuery || itemField.isActiveLogics) {
+              // enable edit fields in panel
+              commit('changeFieldAttribure', {
+                attributeName: 'isReadOnlyFromForm',
+                field: itemField,
+                attributeValue: false
+              })
+            }
+          }
+
+          const othersPanel = (itemField) => {
+            if (!itemField.isAdvancedQuery || itemField.isActiveLogics) {
+              // enable edit fields in panel
+              commit('changeFieldAttribure', {
+                attributeName: 'isReadOnlyFromForm',
+                field: itemField,
+                attributeValue: false
+              })
+
               // Change Dependents
-                dispatch('changeDependentFieldsList', {
-                  field: itemField
-                })
-              }
+              dispatch('changeDependentFieldsList', {
+                field: itemField
+              })
+            }
             // if (itemField.isShowedFromUserDefault || !isEmptyValue(itemField.value)) {
             //   fieldsUser.push(itemField.columnName)
             // }
-            })
-
-          // dispatch('changeFieldShowedFromUser', {
-          //   containerUuid,
-          //   fieldsUser,
-          //   groupField: ''
-          // })
           }
+
+          let execute = windowPanel
+          if (['browser', 'form', 'process', 'report'].includes(panelType)) {
+            // const fieldsUser = []
+            execute = othersPanel
+
+            // dispatch('changeFieldShowedFromUser', {
+            //   containerUuid,
+            //   fieldsUser,
+            //   groupField: ''
+            // })
+          }
+          panel.fieldsList.forEach(execute)
         })
 
       resolve(defaultAttributes)
     })
   },
+
   seekRecord({ dispatch, getters }, {
     parentUuid,
     containerUuid,
diff --git a/src/utils/ADempiere/references.js b/src/utils/ADempiere/references.js
index 19c33807..364ef8e7 100644
--- a/src/utils/ADempiere/references.js
+++ b/src/utils/ADempiere/references.js
@@ -583,28 +583,40 @@ export const FIELDS_HIDDEN = [
   BUTTON
 ]
 
+export const COLUMN_IS_ACTIVE = {
+  columnName: 'IsActive', // column name of field
+  defaultValue: true, // default value when loading
+  valueIsReadOnlyForm: false, // value that activates read-only form
+  isChangedAllForm: false // change the entire form to read only including this field
+}
+
+export const COLUMN_PROCESSED = {
+  columnName: 'Processed',
+  defaultValue: false,
+  valueIsReadOnlyForm: true,
+  isChangedAllForm: true
+}
+
+export const COLUMN_PROCESSING = {
+  columnName: 'Processing',
+  defaultValue: true,
+  valueIsReadOnlyForm: false,
+  isChangedAllForm: true
+}
+
+export const COLUMNS_NAME_READ_ONLY = [
+  COLUMN_IS_ACTIVE.columnName,
+  COLUMN_PROCESSED.columnName,
+  COLUMN_PROCESSING.columnName
+]
+
 /**
  * Fields with this column name, changed all fields is read only
  */
-export const FIELDS_READ_ONLY_FORM = [
-  {
-    columnName: 'IsActive', // column name of field
-    defaultValue: true, // default value when loading
-    valueIsReadOnlyForm: false, // value that activates read-only form
-    isChangedAllForm: false // change the entire form to read only including this field
-  },
-  {
-    columnName: 'Processed',
-    defaultValue: false,
-    valueIsReadOnlyForm: true,
-    isChangedAllForm: true
-  },
-  {
-    columnName: 'Processing',
-    defaultValue: true,
-    valueIsReadOnlyForm: false,
-    isChangedAllForm: true
-  }
+export const COLUMNS_READ_ONLY_FORM = [
+  COLUMN_IS_ACTIVE,
+  COLUMN_PROCESSED,
+  COLUMN_PROCESSING
 ]
 
 export const FIELDS_DECIMALS = [