From 1ac405ef53512d895fe71d3971ad4ef4848d98c4 Mon Sep 17 00:00:00 2001
From: elsiosanchez <45974454+elsiosanchez@users.noreply.github.com>
Date: Tue, 14 Apr 2020 00:09:53 -0400
Subject: [PATCH] Bugfix/validate filled fields before saving (#444)

* Validate filled fields before saving

* remove console
---
 src/store/modules/ADempiere/panel.js | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/store/modules/ADempiere/panel.js b/src/store/modules/ADempiere/panel.js
index 4d4c4dd3..2e42d953 100644
--- a/src/store/modules/ADempiere/panel.js
+++ b/src/store/modules/ADempiere/panel.js
@@ -654,6 +654,10 @@ const panel = {
         }
 
         if (isSendToServer) {
+          const fieldsEmpty = getters.getFieldListEmptyMandatory({
+            containerUuid,
+            fieldsList
+          })
           if (panelType === 'table' || isAdvancedQuery) {
             if (field.isShowedFromUser && (field.oldValue !== field.value ||
               ['NULL', 'NOT_NULL'].includes(field.operator) ||
@@ -703,7 +707,7 @@ const panel = {
                   console.warn(`Error getting Advanced Query (notifyFieldChange): ${error.message}. Code: ${error.code}.`)
                 })
             }
-          } else if (!getters.isNotReadyForSubmit(containerUuid)) {
+          } else if (isEmptyValue(fieldsEmpty)) {
             // TODO: refactory for it and change for a standard method
             if (field.panelType === 'browser' && fieldIsDisplayed(field)) {
               let isReadyForQuery = true
@@ -788,10 +792,6 @@ const panel = {
               }
             }
           } else {
-            const fieldsEmpty = getters.getFieldListEmptyMandatory({
-              containerUuid,
-              fieldsList
-            })
             showMessage({
               message: language.t('notifications.mandatoryFieldMissing') + fieldsEmpty,
               type: 'info'