From f2a5c365de28d288091cc652124575ef16791423 Mon Sep 17 00:00:00 2001 From: neverland Date: Sat, 5 Jan 2019 21:53:41 +0800 Subject: [PATCH] [improvement] create sfc method name (#2445) --- packages/actionsheet/index.js | 10 ++++++---- packages/badge-group/index.js | 4 ++-- packages/badge/index.js | 4 ++-- 3 files changed, 10 insertions(+), 8 deletions(-) diff --git a/packages/actionsheet/index.js b/packages/actionsheet/index.js index e9a1fbbf9..6529aa45d 100644 --- a/packages/actionsheet/index.js +++ b/packages/actionsheet/index.js @@ -1,10 +1,10 @@ -import create from '../utils/create'; +import createSfc from '../utils/create'; import createBem from '../utils/bem'; import Popup from '../mixins/popup'; const bem = createBem('van-actionsheet'); -export default create({ +export default createSfc({ name: 'actionsheet', mixins: [Popup], @@ -25,7 +25,7 @@ export default create({ }, methods: { - onSelect(item, event) { + onSelect(event, item) { event.stopPropagation(); if (!item.disabled && !item.loading) { @@ -64,7 +64,9 @@ export default create({ item.className, 'van-hairline--top' ]} - onClick={this.onSelect.bind(this, item)} + onClick={event => { + this.onSelect(event, item); + }} > {item.loading ? ( diff --git a/packages/badge-group/index.js b/packages/badge-group/index.js index bee6085ba..48ec3aa8a 100644 --- a/packages/badge-group/index.js +++ b/packages/badge-group/index.js @@ -1,9 +1,9 @@ -import create from '../utils/create'; +import createSfc from '../utils/create'; import createBem from '../utils/bem'; const bem = createBem('van-badge-group'); -export default create({ +export default createSfc({ name: 'badge-group', props: { diff --git a/packages/badge/index.js b/packages/badge/index.js index 28810ebd8..f07499825 100644 --- a/packages/badge/index.js +++ b/packages/badge/index.js @@ -1,10 +1,10 @@ import Info from '../info'; -import create from '../utils/create'; +import createSfc from '../utils/create'; import createBem from '../utils/bem'; const bem = createBem('van-badge'); -export default create({ +export default createSfc({ name: 'badge', props: {