From e686738fd57586d15400ede6bc029e0fead17ead Mon Sep 17 00:00:00 2001 From: chenjiahan Date: Tue, 25 Aug 2020 15:12:53 +0800 Subject: [PATCH] perf: simplify watch param --- src/circle/index.js | 2 +- src/count-down/index.js | 6 +----- src/image/index.js | 2 +- src/sidebar-item/index.js | 2 +- src/sidebar/index.js | 8 ++++---- 5 files changed, 8 insertions(+), 12 deletions(-) diff --git a/src/circle/index.js b/src/circle/index.js index dfa818678..f26f2adc0 100644 --- a/src/circle/index.js +++ b/src/circle/index.js @@ -78,7 +78,7 @@ export default createComponent({ }); watch( - computed(() => props.rate), + () => props.rate, (rate) => { let rafId; const startTime = Date.now(); diff --git a/src/count-down/index.js b/src/count-down/index.js index 26fc846cd..fcd06a18e 100644 --- a/src/count-down/index.js +++ b/src/count-down/index.js @@ -116,11 +116,7 @@ export default createComponent({ } }; - watch( - computed(() => props.time), - reset, - { immediate: true } - ); + watch(() => props.time, reset, { immediate: true }); onActivated(() => { if (keepAlived) { diff --git a/src/image/index.js b/src/image/index.js index 46e129166..5b85a1152 100644 --- a/src/image/index.js +++ b/src/image/index.js @@ -59,7 +59,7 @@ export default createComponent({ }); watch( - computed(() => props.src), + () => props.src, () => { error.value = false; loading.value = true; diff --git a/src/sidebar-item/index.js b/src/sidebar-item/index.js index 43d89f4b4..4e36a9b49 100644 --- a/src/sidebar-item/index.js +++ b/src/sidebar-item/index.js @@ -21,7 +21,7 @@ export default createComponent({ setup(props, { emit }) { const { parent, index } = useParent(SIDEBAR_KEY, ref()); - const selected = computed(() => index.value === +parent.active.value); + const selected = computed(() => index.value === +parent.active()); return (vm) => { const { dot, badge, title, disabled } = props; diff --git a/src/sidebar/index.js b/src/sidebar/index.js index 7a240d844..b72bef65d 100644 --- a/src/sidebar/index.js +++ b/src/sidebar/index.js @@ -1,4 +1,4 @@ -import { ref, watch, provide, computed } from 'vue'; +import { ref, watch, provide } from 'vue'; import { createNamespace } from '../utils'; const [createComponent, bem] = createNamespace('sidebar'); @@ -18,7 +18,7 @@ export default createComponent({ setup(props, { emit, slots }) { const children = ref([]); const index = ref(+props.modelValue); - const active = computed(() => props.modelValue); + const active = () => props.modelValue; const setIndex = (value) => { if (value !== index.value) { @@ -27,8 +27,8 @@ export default createComponent({ } }; - watch(active, (val) => { - setIndex(+val); + watch(active, (value) => { + setIndex(+value); }); provide(SIDEBAR_KEY, {