From d92edf871e40b324bc1dd02333e950a4441fadd3 Mon Sep 17 00:00:00 2001 From: neverland Date: Mon, 23 Apr 2018 13:07:19 +0800 Subject: [PATCH] [bugfix] Popup: should remove touch event listener when distroyed (#912) --- packages/mixins/popup/index.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/mixins/popup/index.js b/packages/mixins/popup/index.js index c530ac5ea..bbcf15459 100644 --- a/packages/mixins/popup/index.js +++ b/packages/mixins/popup/index.js @@ -88,10 +88,10 @@ export default { this.renderOverlay(); if (this.lockScroll) { + on(document, 'touchstart', this.touchStart); + on(document, 'touchmove', this.onTouchMove); if (!context.lockCount) { document.body.classList.add('van-overflow-hidden'); - on(document, 'touchstart', this.touchStart); - on(document, 'touchmove', this.onTouchMove); } context.lockCount++; } @@ -104,10 +104,10 @@ export default { if (this.lockScroll) { context.lockCount--; + off(document, 'touchstart', this.touchStart); + off(document, 'touchmove', this.onTouchMove); if (!context.lockCount) { document.body.classList.remove('van-overflow-hidden'); - off(document, 'touchstart', this.touchStart); - off(document, 'touchmove', this.onTouchMove); } }