From d8ff9f3d34abeaa2d9fed40afdcd1b98e4ccffa1 Mon Sep 17 00:00:00 2001
From: neverland <chenjiahan@buaa.edu.cn>
Date: Fri, 30 Nov 2018 15:45:50 +0800
Subject: [PATCH] [improvement] add Cell props mixin (#2189)

---
 packages/cell/en-US.md           |  3 +++
 packages/cell/index.vue          | 19 +++----------------
 packages/cell/zh-CN.md           |  3 +++
 packages/collapse-item/index.vue | 13 +++----------
 packages/collapse/en-US.md       |  3 +++
 packages/collapse/zh-CN.md       |  7 +++++--
 packages/field/index.vue         | 13 +++----------
 packages/mixins/cell.js          | 22 ++++++++++++++++++++++
 8 files changed, 45 insertions(+), 38 deletions(-)
 create mode 100644 packages/mixins/cell.js

diff --git a/packages/cell/en-US.md b/packages/cell/en-US.md
index 86045999d..67d6c280e 100644
--- a/packages/cell/en-US.md
+++ b/packages/cell/en-US.md
@@ -103,6 +103,9 @@ Vue.use(Cell).use(CellGroup);
 | is-link | Whether to show link icon | `Boolean` | `false` |
 | required | Whether to show required mark | `Boolean` | `false` |
 | arrow-direction | Can be set to `left` `up` `down` | `String` | - |
+| title-class | Title className | `String` | - |
+| value-class | Value className | `String` | - |
+| label-class | Label className | `String` | - |
 
 ### Cell Event
 
diff --git a/packages/cell/index.vue b/packages/cell/index.vue
index c65280d1f..e332e29da 100644
--- a/packages/cell/index.vue
+++ b/packages/cell/index.vue
@@ -52,6 +52,7 @@
 
 <script>
 import Icon from '../icon';
+import CellMixin from '../mixins/cell';
 import RouterLink from '../mixins/router-link';
 import create from '../utils/create-basic';
 
@@ -62,26 +63,12 @@ export default create({
     Icon
   },
 
-  mixins: [RouterLink],
+  mixins: [CellMixin, RouterLink],
 
   props: {
-    icon: String,
     size: String,
-    center: Boolean,
-    isLink: Boolean,
-    required: Boolean,
     clickable: Boolean,
-    titleClass: String,
-    valueClass: String,
-    labelClass: String,
-    title: [String, Number],
-    value: [String, Number],
-    label: [String, Number],
-    arrowDirection: String,
-    border: {
-      type: Boolean,
-      default: true
-    }
+    arrowDirection: String
   },
 
   computed: {
diff --git a/packages/cell/zh-CN.md b/packages/cell/zh-CN.md
index cb337a077..d97cddc3c 100644
--- a/packages/cell/zh-CN.md
+++ b/packages/cell/zh-CN.md
@@ -105,6 +105,9 @@ Vue.use(Cell).use(CellGroup);
 | required | 是否显示表单必填星号 | `Boolean` | `false` | - |
 | center | 是否使内容垂直居中 | `Boolean` | `false` | 1.0.3 |
 | arrow-direction | 箭头方向，可选值为 `left` `up` `down` | `String` | - | 1.1.10 |
+| title-class | 左侧标题额外类名 | `String` | - | 1.4.8 |
+| value-class | 右侧内容额外类名 | `String` | - | 1.4.8 |
+| label-class | 描述信息额外类名 | `String` | - | 1.4.8 |
 
 ### Cell Event
 
diff --git a/packages/collapse-item/index.vue b/packages/collapse-item/index.vue
index 80f6e430f..cafc296e9 100644
--- a/packages/collapse-item/index.vue
+++ b/packages/collapse-item/index.vue
@@ -39,24 +39,17 @@
 <script>
 import { raf } from '../utils/raf';
 import create from '../utils/create';
-import findParent from '../mixins/find-parent';
+import CellMixin from '../mixins/cell';
+import FindParent from '../mixins/find-parent';
 
 export default create({
   name: 'collapse-item',
 
-  mixins: [findParent],
+  mixins: [CellMixin, FindParent],
 
   props: {
-    icon: String,
-    label: String,
     name: [String, Number],
-    title: [String, Number],
-    value: [String, Number],
     disabled: Boolean,
-    border: {
-      type: Boolean,
-      default: true
-    },
     isLink: {
       type: Boolean,
       default: true
diff --git a/packages/collapse/en-US.md b/packages/collapse/en-US.md
index 61983b8f6..55fdc8283 100644
--- a/packages/collapse/en-US.md
+++ b/packages/collapse/en-US.md
@@ -92,6 +92,9 @@ export default {
 | border | Whether to show inner border | `Boolean` | `true` |
 | disabled | Whether to disabled collapse | `Boolean` | `false` |
 | is-link | Whether to show link icon | `Boolean` | `true` |
+| title-class | Title className | `String` | - |
+| value-class | Value className | `String` | - |
+| label-class | Label className | `String` | - |
 
 ### CollapseItem Slot
 
diff --git a/packages/collapse/zh-CN.md b/packages/collapse/zh-CN.md
index 217b4cc20..1afa75f50 100644
--- a/packages/collapse/zh-CN.md
+++ b/packages/collapse/zh-CN.md
@@ -97,13 +97,16 @@ export default {
 | 参数 | 说明 | 类型 | 默认值 | 版本 |
 |------|------|------|------|------|------|
 | name | 唯一标识符，默认为索引值 | `String | Number` | `index` | - |
-| title | 标题栏左侧内容 | `String | Number` | - | - |
 | icon | 标题栏左侧图标名称或图片链接，可选值见 Icon 组件 | `String` | - | 1.2.1 |
+| title | 标题栏左侧内容 | `String | Number` | - | - |
 | value | 标题栏右侧内容 | `String | Number` | - | 1.2.1 |
-| label | 标题栏描述信息 | `String` | - | 1.2.1 |
+| label | 标题栏描述信息 | `String | Number`  | - | 1.2.1 |
 | border | 是否显示内边框 | `Boolean` | `true` | 1.2.1 |
 | is-link | 是否展示标题栏右侧箭头并开启点击反馈 | `Boolean` | `true` | 1.2.1 |
 | disabled | 是否禁用面板 | `Boolean` | `false` | 1.3.6 |
+| title-class | 左侧标题额外类名 | `String` | - | 1.4.8 |
+| value-class | 右侧内容额外类名 | `String` | - | 1.4.8 |
+| label-class | 描述信息额外类名 | `String` | - | 1.4.8 |
 
 ### CollapseItem Slot
 
diff --git a/packages/field/index.vue b/packages/field/index.vue
index f2f29da0d..b578d509f 100644
--- a/packages/field/index.vue
+++ b/packages/field/index.vue
@@ -73,6 +73,7 @@
 
 <script>
 import create from '../utils/create';
+import CellMixin from '../mixins/cell';
 import { isObj } from '../utils';
 
 export default create({
@@ -80,16 +81,12 @@ export default create({
 
   inheritAttrs: false,
 
+  mixins: [CellMixin],
+
   props: {
-    value: [String, Number],
-    icon: String,
-    label: String,
     error: Boolean,
-    center: Boolean,
-    isLink: Boolean,
     leftIcon: String,
     readonly: Boolean,
-    required: Boolean,
     clearable: Boolean,
     labelAlign: String,
     inputAlign: String,
@@ -99,10 +96,6 @@ export default create({
     type: {
       type: String,
       default: 'text'
-    },
-    border: {
-      type: Boolean,
-      default: true
     }
   },
 
diff --git a/packages/mixins/cell.js b/packages/mixins/cell.js
new file mode 100644
index 000000000..008459632
--- /dev/null
+++ b/packages/mixins/cell.js
@@ -0,0 +1,22 @@
+/**
+ * Common Cell Props
+ */
+
+export default {
+  props: {
+    icon: String,
+    center: Boolean,
+    isLink: Boolean,
+    required: Boolean,
+    titleClass: String,
+    valueClass: String,
+    labelClass: String,
+    value: [String, Number],
+    label: [String, Number],
+    title: [String, Number],
+    border: {
+      type: Boolean,
+      default: true
+    }
+  }
+};