blackteay/vant
1
0
Fork 0
mirror of https://gitee.com/vant-contrib/vant.git synced 2025-04-06 03:57:59 +08:00
Code Issues Projects Releases Wiki Activity

fix(Tabs): incorrect nav scroll animation in some cases (#11116)

Browse Source 
* fix(Tabs): incorrect nav scroll animation in some cases

* chore: fix snapshot
This commit is contained in:
neverland 2022-10-06 16:23:05 +08:00 committed by chenjiahan
parent 8f12b6c715
commit d88c04cae4
2 changed files with 9 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/vant/src/coupon-list/test/__snapshots__/index.spec.ts.snap
View File

@ -346,7 +346,7 @@ exports[`should have two "van-coupon-list__empty" classes when render coupon lis
</span> </span>
</div> </div>
<div class="van-tabs__line" <div class="van-tabs__line"
style="transform: translateX(50px) translateX(-50%); transition-duration: 0.3s;" style="transform: translateX(50px) translateX(-50%);"
> >
</div> </div>
</div> </div>

14
packages/vant/src/tabs/Tabs.tsx
View File

@ -253,7 +253,14 @@ export default defineComponent({
const newName = getTabName(newTab, newIndex); const newName = getTabName(newTab, newIndex);
const shouldEmitChange = state.currentIndex !== null; const shouldEmitChange = state.currentIndex !== null;
state.currentIndex = newIndex; if (state.currentIndex !== newIndex) {
state.currentIndex = newIndex;
if (!skipScrollIntoView) {
scrollIntoView();
}
setLine();
}
if (newName !== props.active) { if (newName !== props.active) {
emit('update:active', newName); emit('update:active', newName);
@ -263,11 +270,6 @@ export default defineComponent({
} }
} }
if (!skipScrollIntoView) {
scrollIntoView();
}
setLine();
// scroll to correct position // scroll to correct position
if (stickyFixed && !props.scrollspy) { if (stickyFixed && !props.scrollspy) {
setRootScrollTop( setRootScrollTop(