From c74d90c561669473b2c9f314a3e893436d6da58d Mon Sep 17 00:00:00 2001
From: neverland <chenjiahan@youzan.com>
Date: Thu, 8 Aug 2019 20:01:41 +0800
Subject: [PATCH] [improvement] optimize eslint-disable (#4070)

---
 build/build-entry.js                | 3 +--
 src/address-edit/test/index.spec.js | 1 -
 src/coupon-list/demo/index.vue      | 1 -
 src/index.ts                        | 1 -
 src/rate/index.tsx                  | 1 -
 src/search/test/index.spec.js       | 5 +----
 src/sku/Sku.js                      | 1 -
 src/sku/components/SkuMessages.js   | 2 +-
 src/sku/demo/data.js                | 1 -
 src/tab/index.js                    | 2 +-
 src/utils/deep-assign.ts            | 2 +-
 src/utils/dom/event.ts              | 6 +++---
 src/utils/validate/number.ts        | 3 +--
 13 files changed, 9 insertions(+), 20 deletions(-)

diff --git a/build/build-entry.js b/build/build-entry.js
index d5f623c7e..825efaa2a 100644
--- a/build/build-entry.js
+++ b/build/build-entry.js
@@ -5,8 +5,7 @@ const Components = require('./get-components')();
 const packageJson = require('../package.json');
 
 const version = process.env.VERSION || packageJson.version;
-const tips = `/* eslint-disable */
-// This file is auto gererated by build/build-entry.js`;
+const tips = '// This file is auto gererated by build/build-entry.js';
 
 function buildEntry() {
   const uninstallComponents = [
diff --git a/src/address-edit/test/index.spec.js b/src/address-edit/test/index.spec.js
index 079c84e4d..eb4598661 100644
--- a/src/address-edit/test/index.spec.js
+++ b/src/address-edit/test/index.spec.js
@@ -1,4 +1,3 @@
-/* eslint-disable camelcase */
 import AddressEdit from '..';
 import areaList from '../../area/demo/area.simple';
 import { mount, later } from '../../../test/utils';
diff --git a/src/coupon-list/demo/index.vue b/src/coupon-list/demo/index.vue
index 41965eac2..0bcceb5d9 100644
--- a/src/coupon-list/demo/index.vue
+++ b/src/coupon-list/demo/index.vue
@@ -24,7 +24,6 @@
 </template>
 
 <script>
-/* eslint-disable camelcase */
 export default {
   i18n: {
     'zh-CN': {
diff --git a/src/index.ts b/src/index.ts
index 622e181fc..6efc743ee 100644
--- a/src/index.ts
+++ b/src/index.ts
@@ -1,4 +1,3 @@
-/* eslint-disable */
 // This file is auto gererated by build/build-entry.js
 import { VueConstructor } from 'vue/types';
 import ActionSheet from './action-sheet';
diff --git a/src/rate/index.tsx b/src/rate/index.tsx
index b36ff0897..e271e5e09 100644
--- a/src/rate/index.tsx
+++ b/src/rate/index.tsx
@@ -1,4 +1,3 @@
-/* eslint-disable prefer-spread */
 import { createNamespace, addUnit } from '../utils';
 import { emit, inherit } from '../utils/functional';
 import { preventDefault } from '../utils/dom/event';
diff --git a/src/search/test/index.spec.js b/src/search/test/index.spec.js
index 3d8e5e5df..a3eaa278e 100644
--- a/src/search/test/index.spec.js
+++ b/src/search/test/index.spec.js
@@ -1,4 +1,3 @@
-/* eslint-disable object-shorthand */
 import Search from '..';
 import { mount } from '../../../test/utils';
 
@@ -99,9 +98,7 @@ test('right-icon prop', () => {
 test('right-icon slot', () => {
   const wrapper = mount(Search, {
     scopedSlots: {
-      'right-icon'() {
-        return 'Custom Right Icon';
-      }
+      'right-icon': () => 'Custom Right Icon'
     }
   });
 
diff --git a/src/sku/Sku.js b/src/sku/Sku.js
index 325fa437b..f262b5fef 100644
--- a/src/sku/Sku.js
+++ b/src/sku/Sku.js
@@ -1,4 +1,3 @@
-/* eslint-disable camelcase */
 import Vue from 'vue';
 import Popup from '../popup';
 import Toast from '../toast';
diff --git a/src/sku/components/SkuMessages.js b/src/sku/components/SkuMessages.js
index 6e145a8a0..8fa6640ad 100644
--- a/src/sku/components/SkuMessages.js
+++ b/src/sku/components/SkuMessages.js
@@ -100,7 +100,7 @@ export default createComponent({
 
         if (value === '') {
           // 必填字段的校验
-          if (String(message.required) === '1') { // eslint-disable-line
+          if (String(message.required) === '1') {
             const textType = message.type === 'image'
               ? '请上传'
               : '请填写';
diff --git a/src/sku/demo/data.js b/src/sku/demo/data.js
index 31ebb6462..37df50828 100644
--- a/src/sku/demo/data.js
+++ b/src/sku/demo/data.js
@@ -1,4 +1,3 @@
-/* eslint-disable */
 export default {
   goods_id: '946755',
   quota: 15,
diff --git a/src/tab/index.js b/src/tab/index.js
index 72ca1707e..eea393bcf 100644
--- a/src/tab/index.js
+++ b/src/tab/index.js
@@ -1,4 +1,3 @@
-/* eslint-disable object-shorthand */
 import { createNamespace } from '../utils';
 import { ChildrenMixin } from '../mixins/relation';
 
@@ -30,6 +29,7 @@ export default createComponent({
   },
 
   watch: {
+    // eslint-disable-next-line object-shorthand
     'parent.currentIndex'() {
       this.inited = this.inited || this.isActive;
     },
diff --git a/src/utils/deep-assign.ts b/src/utils/deep-assign.ts
index e2a4653e9..5686ef425 100644
--- a/src/utils/deep-assign.ts
+++ b/src/utils/deep-assign.ts
@@ -1,4 +1,3 @@
-/* eslint-disable no-use-before-define */
 import { isDef, isObj } from '.';
 import { ObjectIndex } from './types';
 
@@ -14,6 +13,7 @@ function assignKey(to: ObjectIndex, from: ObjectIndex, key: string) {
   if (!hasOwnProperty.call(to, key) || !isObj(val) || typeof val === 'function') {
     to[key] = val;
   } else {
+    // eslint-disable-next-line no-use-before-define
     to[key] = deepAssign(Object(to[key]), from[key]);
   }
 }
diff --git a/src/utils/dom/event.ts b/src/utils/dom/event.ts
index add54873d..dfd3dcd10 100644
--- a/src/utils/dom/event.ts
+++ b/src/utils/dom/event.ts
@@ -1,21 +1,21 @@
-/* eslint-disable no-empty */
-/* eslint-disable getter-return */
-/* eslint-disable import/no-mutable-exports */
 import { isServer } from '..';
 import { EventHandler } from '../types';
 
+// eslint-disable-next-line import/no-mutable-exports
 export let supportsPassive = false;
 
 if (!isServer) {
   try {
     const opts = {};
     Object.defineProperty(opts, 'passive', {
+      // eslint-disable-next-line getter-return
       get() {
         /* istanbul ignore next */
         supportsPassive = true;
       }
     });
     window.addEventListener('test-passive', null as any, opts);
+  // eslint-disable-next-line no-empty
   } catch (e) {}
 }
 
diff --git a/src/utils/validate/number.ts b/src/utils/validate/number.ts
index 254e580b2..e5c3bffec 100644
--- a/src/utils/validate/number.ts
+++ b/src/utils/validate/number.ts
@@ -1,5 +1,3 @@
-/* eslint-disable no-self-compare */
-
 export function isNumber(value: string): boolean {
   return /^\d+(\.\d+)?$/.test(value);
 }
@@ -9,5 +7,6 @@ export function isNaN(value: any): boolean {
     return Number.isNaN(value);
   }
 
+  // eslint-disable-next-line no-self-compare
   return value !== value;
 }