From c05124b3ec7aa60d18a988f14630adb9fef6f4ce Mon Sep 17 00:00:00 2001
From: neverland <chenjiahan@youzan.com>
Date: Fri, 14 Jun 2019 16:50:37 +0800
Subject: [PATCH] [improvement] Tab: optimize event binding (#3512)

---
 packages/mixins/bind-event.js |  8 ++--
 packages/tabs/index.js        | 76 +++++++++++++----------------------
 2 files changed, 32 insertions(+), 52 deletions(-)

diff --git a/packages/mixins/bind-event.js b/packages/mixins/bind-event.js
index a25897d1d..8ca15c597 100644
--- a/packages/mixins/bind-event.js
+++ b/packages/mixins/bind-event.js
@@ -3,14 +3,14 @@ import { on, off } from '../utils/dom/event';
 export function BindEventMixin(handler) {
   function bind() {
     if (!this.binded) {
-      handler.call(this, on);
+      handler.call(this, on, true);
       this.binded = true;
     }
   }
 
   function unbind() {
     if (this.binded) {
-      handler.call(this, off);
+      handler.call(this, off, false);
       this.binded = false;
     }
   }
@@ -18,7 +18,7 @@ export function BindEventMixin(handler) {
   return {
     mounted: bind,
     activated: bind,
-    destroyed: unbind,
-    deactivated: unbind
+    deactivated: unbind,
+    beforeDestroy: unbind
   };
 }
diff --git a/packages/tabs/index.js b/packages/tabs/index.js
index 9e39d9bc8..c60f3714e 100644
--- a/packages/tabs/index.js
+++ b/packages/tabs/index.js
@@ -3,6 +3,7 @@ import { raf } from '../utils/dom/raf';
 import { on, off } from '../utils/dom/event';
 import { TouchMixin } from '../mixins/touch';
 import { ParentMixin } from '../mixins/relation';
+import { BindEventMixin } from '../mixins/bind-event';
 import {
   setScrollTop,
   getScrollTop,
@@ -14,7 +15,14 @@ const [sfc, bem] = use('tabs');
 const tabBem = use('tab')[1];
 
 export default sfc({
-  mixins: [TouchMixin, ParentMixin('vanTabs')],
+  mixins: [
+    TouchMixin,
+    ParentMixin('vanTabs'),
+    BindEventMixin(function (bind, isBind) {
+      this.bindScrollEvent(isBind);
+      bind(window, 'resize', this.setLine, true);
+    })
+  ],
 
   model: {
     prop: 'active'
@@ -68,16 +76,13 @@ export default sfc({
   },
 
   data() {
+    this.scrollEvent = false;
+
     return {
       position: '',
       curActive: null,
       lineStyle: {
         backgroundColor: this.color
-      },
-      events: {
-        resize: false,
-        sticky: false,
-        swipeable: false
       }
     };
   },
@@ -149,12 +154,8 @@ export default sfc({
       }
     },
 
-    sticky() {
-      this.handlers(true);
-    },
-
-    swipeable() {
-      this.handlers(true);
+    sticky(val) {
+      this.bindScrollEvent(val);
     }
   },
 
@@ -167,54 +168,23 @@ export default sfc({
     this.setLine();
   },
 
-  deactivated() {
-    this.handlers(false);
-  },
-
-  beforeDestroy() {
-    this.handlers(false);
-  },
-
   methods: {
     onShow() {
       this.$nextTick(() => {
         this.inited = true;
-        this.handlers(true);
         this.scrollIntoView(true);
       });
     },
 
-    // whether to bind sticky listener
-    handlers(bind) {
-      const { events } = this;
-      const sticky = this.sticky && bind;
-      const swipeable = this.swipeable && bind;
+    bindScrollEvent(isBind) {
+      const sticky = this.sticky && isBind;
 
-      // listen to window resize event
-      if (events.resize !== bind) {
-        events.resize = bind;
-        (bind ? on : off)(window, 'resize', this.setLine, true);
-      }
-
-      // listen to scroll event
-      if (events.sticky !== sticky) {
-        events.sticky = sticky;
+      if (this.scrollEvent !== sticky) {
+        this.scrollEvent = sticky;
         this.scrollEl = this.scrollEl || getScrollEventTarget(this.$el);
         (sticky ? on : off)(this.scrollEl, 'scroll', this.onScroll, true);
         this.onScroll();
       }
-
-      // listen to touch event
-      if (events.swipeable !== swipeable) {
-        events.swipeable = swipeable;
-        const { content } = this.$refs;
-        const action = swipeable ? on : off;
-
-        action(content, 'touchstart', this.touchStart);
-        action(content, 'touchmove', this.touchMove);
-        action(content, 'touchend', this.onTouchEnd);
-        action(content, 'touchcancel', this.onTouchEnd);
-      }
     },
 
     // watch swipe touch end
@@ -434,6 +404,16 @@ export default sfc({
       </div>
     ));
 
+    let contentListeners;
+    if (this.swipeable) {
+      contentListeners = {
+        touchstart: this.touchStart,
+        touchmove: this.touchMove,
+        touchend: this.onTouchEnd,
+        touchcancel: this.onTouchEnd
+      };
+    }
+
     return (
       <div class={bem([type])}>
         <div
@@ -451,7 +431,7 @@ export default sfc({
             {this.slots('nav-right')}
           </div>
         </div>
-        <div ref="content" class={bem('content', { animated })}>
+        <div class={bem('content', { animated })} {...{ on: contentListeners }}>
           {animated ? (
             <div class={bem('track')} style={this.trackStyle}>
               {this.slots()}