blackteay/vant
1
0
Fork 0
mirror of https://gitee.com/vant-contrib/vant.git synced 2025-04-06 03:57:59 +08:00
Code Issues Projects Releases Wiki Activity

[bugfix] Popup: click-overlay triggered twice

Browse Source
This commit is contained in:
陈嘉涵 2019-05-05 10:14:30 +08:00
parent a857574908
commit be5270dea1
2 changed files with 13 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
packages/overlay/index.tsx
View File

@ -39,9 +39,6 @@ function Overlay(
event.preventDefault(); event.preventDefault();
event.stopPropagation(); event.stopPropagation();
}} }}
onClick={(event: Event) => {
emit(ctx, 'click', event);
}}
{...inherit(ctx, true)} {...inherit(ctx, true)}
/> />
</transition> </transition>

15
packages/popup/test/index.spec.js
View File

@ -146,12 +146,18 @@ test('watch overlay prop', () => {
expect(div.querySelector('.van-overlay')).toBeTruthy(); expect(div.querySelector('.van-overlay')).toBeTruthy();
}); });
test('close on click modal', () => { test('close on click overlay', () => {
const div = document.createElement('div'); const div = document.createElement('div');
const onClickOverlay = jest.fn();
wrapper = mount({ wrapper = mount({
template: ` template: `
<div> <div>
<popup v-model="value" :get-container="getContainer" /> <popup
v-model="value"
:get-container="getContainer"
@click-overlay="onClickOverlay"
/>
</div> </div>
`, `,
components: { components: {
@ -162,13 +168,18 @@ test('close on click modal', () => {
value: true, value: true,
getContainer: () => div getContainer: () => div
}; };
},
methods: {
onClickOverlay
} }
}); });
const modal = div.querySelector('.van-overlay'); const modal = div.querySelector('.van-overlay');
triggerDrag(modal, 0, -30); triggerDrag(modal, 0, -30);
modal.click(); modal.click();
expect(wrapper.vm.value).toBeFalsy(); expect(wrapper.vm.value).toBeFalsy();
expect(onClickOverlay).toHaveBeenCalledTimes(1);
}); });
test('oepn & close event', () => { test('oepn & close event', () => {