blackteay/vant
1
0
Fork 0
mirror of https://gitee.com/vant-contrib/vant.git synced 2025-04-06 03:57:59 +08:00
Code Issues Projects Releases Wiki Activity

fix(DatePicker): fix display back wrong of date-picker (#11656)

Browse Source 
* fix(DatePicker): fix display back wrong of date-picker

* feat: add test case for multi-column picker
This commit is contained in:
Gavin 2023-03-14 08:49:23 +08:00 committed by GitHub
parent 13a91147ce
commit b9862b3c41
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 52 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
packages/vant/src/picker/Picker.tsx
View File

@ -275,6 +275,7 @@ export default defineComponent({
!isSameValue(newValues, lastEmittedModelValue)
) {
selectedValues.value = newValues.slice(0);
lastEmittedModelValue = newValues.slice(0);
}
},
{ deep: true }

52
packages/vant/src/picker/test/index.spec.tsx
View File

@ -1,5 +1,5 @@
import { later, mount, triggerDrag } from '../../../test';
import { Picker } from '..';
import { Picker, type PickerConfirmEventParams } from '..';
const simpleColumn = [
{ text: '1990', value: '1990' },
@ -295,3 +295,53 @@ test('columns-field-names responsiveness', async () => {
});
expect(wrapper.findAll('.van-ellipsis')[0].text()).toEqual('server1');
});
test('should be displayed correctly whhen the component is reused', async () => {
const wrapper = mount(Picker, {
props: {
showToolbar: true,
columns: [
[
{ text: '1990', value: '1990' },
{ text: '1991', value: '1991' },
{ text: '1992', value: '1992' },
{ text: '1993', value: '1993' },
{ text: '1994', value: '1994' },
{ text: '1995', value: '1995' },
],
[
{ text: '01', value: '01' },
{ text: '02', value: '02' },
{ text: '03', value: '03' },
{ text: '04', value: '04' },
],
],
},
});
await wrapper.setProps({ modelValue: ['1990', '01'] });
await wrapper.find('.van-picker__confirm').trigger('click');
expect(
wrapper.emitted<[PickerConfirmEventParams]>('confirm')![0][0].selectedValues
).toEqual(['1990', '01']);
await wrapper.setProps({ modelValue: ['1992', '03'] });
await wrapper.find('.van-picker__confirm').trigger('click');
expect(
wrapper.emitted<[PickerConfirmEventParams]>('confirm')![1][0].selectedValues
).toEqual(['1992', '03']);
// Test the scenario when a component is assigned multiple times in multiple columns
// https://github.com/youzan/vant/issues/11644
await wrapper.setProps({ modelValue: ['1990', '01'] });
await wrapper.find('.van-picker__confirm').trigger('click');
expect(
wrapper.emitted<[PickerConfirmEventParams]>('confirm')![2][0].selectedValues
).toEqual(['1990', '01']);
await wrapper.setProps({ modelValue: ['1992', '03'] });
await wrapper.find('.van-picker__confirm').trigger('click');
expect(
wrapper.emitted<[PickerConfirmEventParams]>('confirm')![3][0].selectedValues
).toEqual(['1992', '03']);
});