blackteay/vant
1
0
Fork 0
mirror of https://gitee.com/vant-contrib/vant.git synced 2025-04-06 03:57:59 +08:00
Code Issues Projects Releases Wiki Activity

fix(Field): incorrect maxlength slicing (#7284)

Browse Source 
* fix(Field): incorrect maxlength slicing

* chore: robust
This commit is contained in:
neverland 2020-09-30 11:42:23 +08:00 committed by GitHub
parent f15534928e
commit 950dd10372
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 17 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/field/index.js
View File

@ -294,10 +294,15 @@ export default createComponent({
updateValue(value, trigger = 'onChange') {
value = isDef(value) ? String(value) : '';
// native maxlength not work when type is number
// native maxlength have incorrect line-break counting
// see: https://github.com/youzan/vant/issues/5033
const { maxlength } = this;
if (isDef(maxlength) && value.length > maxlength) {
value = value.slice(0, maxlength);
if (this.value && this.value.length === +maxlength) {
({ value } = this);
} else {
value = value.slice(0, maxlength);
}
}
if (this.type === 'number' || this.type === 'digit') {

12
src/field/test/index.spec.js
View File

@ -171,17 +171,25 @@ test('maxlength', async () => {
value: 1234,
type: 'number',
},
listeners: {
input(value) {
wrapper && wrapper.setProps({ value });
},
},
});
const input = wrapper.find('input');
expect(input.element.value).toEqual('123');
input.element.value = 1234;
await later();
input.trigger('input');
expect(input.element.value).toEqual('123');
expect(wrapper.emitted('input')[0][0]).toEqual('123');
// see: https://github.com/youzan/vant/issues/7265
input.element.value = 1423;
input.trigger('input');
expect(input.element.value).toEqual('123');
});
test('clearable prop', () => {