From 92f5ac9143c59a918ff5b0bd46debfad2a488741 Mon Sep 17 00:00:00 2001
From: neverland <chenjiahan@youzan.com>
Date: Fri, 20 Sep 2019 20:17:28 +0800
Subject: [PATCH] feat(Popup): improvement accessibility of close icon (#4516)

---
 src/popup/index.js                              | 8 +++++++-
 src/popup/test/__snapshots__/index.spec.js.snap | 2 +-
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/src/popup/index.js b/src/popup/index.js
index 6226db427..c183a9c23 100644
--- a/src/popup/index.js
+++ b/src/popup/index.js
@@ -77,7 +77,13 @@ export default createComponent({
         >
           {this.slots()}
           {this.closeable && (
-            <Icon name={this.closeIcon} class={bem('close-icon', this.closeIconPosition)} onClick={this.close} />
+            <Icon
+              role="button"
+              tabindex="0"
+              name={this.closeIcon}
+              class={bem('close-icon', this.closeIconPosition)}
+              onClick={this.close}
+            />
           )}
         </div>
       </transition>
diff --git a/src/popup/test/__snapshots__/index.spec.js.snap b/src/popup/test/__snapshots__/index.spec.js.snap
index 41ac59084..8398b7e31 100644
--- a/src/popup/test/__snapshots__/index.spec.js.snap
+++ b/src/popup/test/__snapshots__/index.spec.js.snap
@@ -1,7 +1,7 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
 exports[`close-icon prop 1`] = `
-<div class="van-popup van-popup--center" name="van-fade"><i class="van-icon van-icon-success van-popup__close-icon van-popup__close-icon--top-right">
+<div class="van-popup van-popup--center" name="van-fade"><i role="button" tabindex="0" class="van-icon van-icon-success van-popup__close-icon van-popup__close-icon--top-right">
     <!----></i></div>
 `;