blackteay/vant
1
0
Fork 0
mirror of https://gitee.com/vant-contrib/vant.git synced 2025-04-06 03:57:59 +08:00
Code Issues Projects Releases Wiki Activity

feat(Popover): improve a11y (#7624)

Browse Source
This commit is contained in:
neverland 2020-11-24 17:25:27 +08:00 committed by GitHub
parent 1f5f078aec
commit 89ce8345b4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/popover/index.js
View File

@ -114,13 +114,14 @@ export default createComponent({
renderAction(action, index) { renderAction(action, index) {
const { icon, text, disabled, className } = action; const { icon, text, disabled, className } = action;
return ( return (
<div <button
type="button"
class={[bem('action', { disabled, 'with-icon': icon }), className]} class={[bem('action', { disabled, 'with-icon': icon }), className]}
onClick={() => this.onClickAction(action, index)} onClick={() => this.onClickAction(action, index)}
> >
{icon && <Icon name={icon} class={bem('action-icon')} />} {icon && <Icon name={icon} class={bem('action-icon')} />}
<div class={[bem('action-text'), BORDER_BOTTOM]}>{text}</div> <div class={[bem('action-text'), BORDER_BOTTOM]}>{text}</div>
</div> </button>
); );
}, },

2
src/popover/index.less
View File

@ -34,6 +34,8 @@
padding: 0 @padding-md; padding: 0 @padding-md;
font-size: @popover-action-font-size; font-size: @popover-action-font-size;
line-height: @line-height-md; line-height: @line-height-md;
background-color: transparent;
border: none;
cursor: pointer; cursor: pointer;
&:last-child { &:last-child {

4
src/popover/test/__snapshots__/index.spec.js.snap
View File

@ -1,9 +1,9 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP // Jest Snapshot v1, https://goo.gl/fbAQLP
exports[`should allow to custom the className of action 1`] = ` exports[`should allow to custom the className of action 1`] = `
<div class="van-popover__action foo"> <button type="button" class="van-popover__action foo">
<div class="van-popover__action-text van-hairline--bottom">Option</div> <div class="van-popover__action-text van-hairline--bottom">Option</div>
</div> </button>
`; `;
exports[`should locate to reference element when showed 1`] = `<!---->`; exports[`should locate to reference element when showed 1`] = `<!---->`;