diff --git a/breaking-changes.md b/breaking-changes.md deleted file mode 100644 index e69de29bb..000000000 diff --git a/docs/markdown/changelog-v3.zh-CN.md b/docs/markdown/changelog-v3.zh-CN.md index f940e1491..095abbe30 100644 --- a/docs/markdown/changelog-v3.zh-CN.md +++ b/docs/markdown/changelog-v3.zh-CN.md @@ -41,13 +41,14 @@ Vant 遵循 [Semver](https://semver.org/lang/zh-CN/) 语义化版本规范。 以下改动是为了规范 API 命名: +- SwipeCell: `on-close` 属性重命名为 `before-close`,并调整参数结构 - Toast: `mask` 属性重命名为 `overlay` - TreeSelect: `navclick` 事件重命名为 `click-nav` - TreeSelect: `itemclick` 事件重命名为 `click-item` ##### 重命名徽标属性 -在之前的版本中,我们通过 info 属性来展示图标右上角的徽标信息,为了表达更符合社区的命名习惯,我们将这个属性重命名为 badge,影响以下组件: +在之前的版本中,我们通过 info 属性来展示图标右上角的徽标信息,为了更符合社区的命名习惯,我们将这个属性重命名为 badge,影响以下组件: - Tab - Icon diff --git a/src/swipe-cell/index.js b/src/swipe-cell/index.js index b7a31aab3..65e9647fd 100644 --- a/src/swipe-cell/index.js +++ b/src/swipe-cell/index.js @@ -20,9 +20,6 @@ export default createComponent({ ], props: { - // @deprecated - // should be removed in next major version, use beforeClose instead - onClose: Function, disabled: Boolean, leftWidth: [Number, String], rightWidth: [Number, String], @@ -177,8 +174,6 @@ export default createComponent({ name: this.name, instance: this, }); - } else if (this.onClose) { - this.onClose(position, this, { name: this.name }); } else { this.close(position); } diff --git a/src/swipe-cell/test/index.spec.js b/src/swipe-cell/test/index.spec.js index 0f1d11693..ebc3f8c3f 100644 --- a/src/swipe-cell/test/index.spec.js +++ b/src/swipe-cell/test/index.spec.js @@ -41,43 +41,6 @@ test('drag and show right part', () => { expect(wrapper).toMatchSnapshot(); }); -test('on-close prop', () => { - let position; - let instance; - - const wrapper = mount(SwipeCell, { - ...defaultProps, - propsData: { - ...defaultProps.propsData, - onClose(pos, ins) { - position = pos; - instance = ins; - }, - }, - }); - - wrapper.trigger('click'); - expect(position).toEqual(undefined); - - wrapper.vm.open('left'); - wrapper.trigger('click'); - expect(position).toEqual('cell'); - - wrapper.find('.van-swipe-cell__left').trigger('click'); - expect(position).toEqual('left'); - - wrapper.find('.van-swipe-cell__right').trigger('click'); - expect(position).toEqual('right'); - - instance.close(); - expect(instance.offset).toEqual(0); - - instance.open('left'); - wrapper.setData({ onClose: null }); - wrapper.trigger('click'); - expect(wrapper.vm.offset).toEqual(0); -}); - test('before-close prop', () => { let position; let instance;