blackteay/vant
1
0
Fork 0
mirror of https://gitee.com/vant-contrib/vant.git synced 2025-04-05 19:41:42 +08:00
Code Issues Projects Releases Wiki Activity

fix(Field): should not set for attr to label when using input slot (#11966)

Browse Source 
* fix(Field): when using input slot, the label's for attribute will not be set

* test(Field): add test case
This commit is contained in:
inottn 2023-06-17 21:07:20 +08:00 committed by GitHub
parent 58a05627ab
commit 79564847b3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 28 additions and 49 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/vant/src/config-provider/test/__snapshots__/demo-ssr.spec.ts.snap
View File

@ -24,7 +24,6 @@ exports[`should render demo and match snapshot 1`] = `
>
<!--[-->
<label id="van-field-label"
for="van-field-input"
style
>
Rate
@ -123,7 +122,6 @@ exports[`should render demo and match snapshot 1`] = `
>
<!--[-->
<label id="van-field-label"
for="van-field-input"
style
>
Slider
@ -188,7 +186,6 @@ exports[`should render demo and match snapshot 1`] = `
>
<!--[-->
<label id="van-field-label"
for="van-field-input"
style
>
Rate
@ -287,7 +284,6 @@ exports[`should render demo and match snapshot 1`] = `
>
<!--[-->
<label id="van-field-label"
for="van-field-input"
style
>
Slider

16
packages/vant/src/config-provider/test/__snapshots__/demo.spec.ts.snap
View File

@ -15,9 +15,7 @@ exports[`should render demo and match snapshot 1`] = `
<form class="van-form">
<div class="van-cell van-field">
<div class="van-cell__title van-field__label">
<label id="van-field-label"
for="van-field-input"
>
<label id="van-field-label">
Rate
</label>
</div>
@ -87,9 +85,7 @@ exports[`should render demo and match snapshot 1`] = `
</div>
<div class="van-cell van-field">
<div class="van-cell__title van-field__label">
<label id="van-field-label"
for="van-field-input"
>
<label id="van-field-label">
Slider
</label>
</div>
@ -137,9 +133,7 @@ exports[`should render demo and match snapshot 1`] = `
<form class="van-form">
<div class="van-cell van-field">
<div class="van-cell__title van-field__label">
<label id="van-field-label"
for="van-field-input"
>
<label id="van-field-label">
Rate
</label>
</div>
@ -209,9 +203,7 @@ exports[`should render demo and match snapshot 1`] = `
</div>
<div class="van-cell van-field">
<div class="van-cell__title van-field__label">
<label id="van-field-label"
for="van-field-input"
>
<label id="van-field-label">
Slider
</label>
</div>

2
packages/vant/src/field/Field.tsx
View File

@ -583,7 +583,7 @@ export default defineComponent({
return (
<label
id={`${id}-label`}
for={getInputId()}
for={slots.input ? undefined : getInputId()}
onClick={(event: MouseEvent) => {
// https://github.com/youzan/vant/issues/11831
preventDefault(event);

15
packages/vant/src/field/test/index.spec.js
View File

@ -533,3 +533,18 @@ test('should render label correctly when dynamically set empty label', async ()
await wrapper.setProps({ label: '' });
expect(wrapper.find('.van-field__label').exists()).toBeFalsy();
});
test("should not be set label's for attribute when using input slot", async () => {
const wrapper = mount(Field, {
props: {
label: 'abc',
},
slots: {
input: '',
},
});
expect(
wrapper.find('.van-field__label label').attributes('for')
).toBeUndefined();
});

8
packages/vant/src/form/test/__snapshots__/demo-ssr.spec.ts.snap
View File

@ -208,7 +208,6 @@ exports[`should render demo and match snapshot 1`] = `
>
<!--[-->
<label id="van-field-label"
for="van-field-input"
style
>
Switch
@ -238,7 +237,6 @@ exports[`should render demo and match snapshot 1`] = `
>
<!--[-->
<label id="van-field-label"
for="van-field-input"
style
>
Checkbox
@ -275,7 +273,6 @@ exports[`should render demo and match snapshot 1`] = `
>
<!--[-->
<label id="van-field-label"
for="van-field-input"
style
>
Checkbox Group
@ -339,7 +336,6 @@ exports[`should render demo and match snapshot 1`] = `
>
<!--[-->
<label id="van-field-label"
for="van-field-input"
style
>
Radio
@ -405,7 +401,6 @@ exports[`should render demo and match snapshot 1`] = `
>
<!--[-->
<label id="van-field-label"
for="van-field-input"
style
>
Stepper
@ -451,7 +446,6 @@ exports[`should render demo and match snapshot 1`] = `
>
<!--[-->
<label id="van-field-label"
for="van-field-input"
style
>
Rate
@ -550,7 +544,6 @@ exports[`should render demo and match snapshot 1`] = `
>
<!--[-->
<label id="van-field-label"
for="van-field-input"
style
>
Slider
@ -592,7 +585,6 @@ exports[`should render demo and match snapshot 1`] = `
>
<!--[-->
<label id="van-field-label"
for="van-field-input"
style
>
Uploader

32
packages/vant/src/form/test/__snapshots__/demo.spec.ts.snap
View File

@ -160,9 +160,7 @@ exports[`should render demo and match snapshot 1`] = `
<div class="van-cell-group van-cell-group--inset">
<div class="van-cell van-field">
<div class="van-cell__title van-field__label">
<label id="van-field-label"
for="van-field-input"
>
<label id="van-field-label">
Switch
</label>
</div>
@ -183,9 +181,7 @@ exports[`should render demo and match snapshot 1`] = `
</div>
<div class="van-cell van-field">
<div class="van-cell__title van-field__label">
<label id="van-field-label"
for="van-field-input"
>
<label id="van-field-label">
Checkbox
</label>
</div>
@ -208,9 +204,7 @@ exports[`should render demo and match snapshot 1`] = `
</div>
<div class="van-cell van-field">
<div class="van-cell__title van-field__label">
<label id="van-field-label"
for="van-field-input"
>
<label id="van-field-label">
Checkbox Group
</label>
</div>
@ -251,9 +245,7 @@ exports[`should render demo and match snapshot 1`] = `
</div>
<div class="van-cell van-field">
<div class="van-cell__title van-field__label">
<label id="van-field-label"
for="van-field-input"
>
<label id="van-field-label">
Radio
</label>
</div>
@ -296,9 +288,7 @@ exports[`should render demo and match snapshot 1`] = `
</div>
<div class="van-cell van-field">
<div class="van-cell__title van-field__label">
<label id="van-field-label"
for="van-field-input"
>
<label id="van-field-label">
Stepper
</label>
</div>
@ -332,9 +322,7 @@ exports[`should render demo and match snapshot 1`] = `
</div>
<div class="van-cell van-field">
<div class="van-cell__title van-field__label">
<label id="van-field-label"
for="van-field-input"
>
<label id="van-field-label">
Rate
</label>
</div>
@ -404,9 +392,7 @@ exports[`should render demo and match snapshot 1`] = `
</div>
<div class="van-cell van-field">
<div class="van-cell__title van-field__label">
<label id="van-field-label"
for="van-field-input"
>
<label id="van-field-label">
Slider
</label>
</div>
@ -436,9 +422,7 @@ exports[`should render demo and match snapshot 1`] = `
</div>
<div class="van-cell van-field">
<div class="van-cell__title van-field__label">
<label id="van-field-label"
for="van-field-input"
>
<label id="van-field-label">
Uploader
</label>
</div>