blackteay/vant
1
0
Fork 0
mirror of https://gitee.com/vant-contrib/vant.git synced 2025-04-06 03:57:59 +08:00
Code Issues Projects Releases Wiki Activity

fix(Popup): close event emiited twice (#10132)

Browse Source
This commit is contained in:
neverland 2021-12-30 21:15:42 +08:00 committed by GitHub
parent 9c16f4240a
commit 7831553bee
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 20 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
packages/vant/src/popup/Popup.tsx
View File

@ -213,10 +213,11 @@ export default defineComponent({
watch( watch(
() => props.show, () => props.show,
(value) => { (show) => {
if (value) { if (show && !opened) {
open(); open();
} else { }
if (!show && opened) {
opened = false; opened = false;
emit('close'); emit('close');
} }

16
packages/vant/src/popup/test/index.spec.js
View File

@ -129,6 +129,22 @@ test('should emit close event when show prop is set to false', async () => {
expect(onClose).toHaveBeenCalledTimes(1); expect(onClose).toHaveBeenCalledTimes(1);
}); });
test('should emit close event after clicking the overlay', async () => {
const onClose = jest.fn();
wrapper = mount(Popup, {
props: {
show: true,
onClose,
'onUpdate:show': (show) => {
wrapper.setProps({ show });
},
},
});
await wrapper.find('.van-overlay').trigger('click');
expect(onClose).toHaveBeenCalledTimes(1);
});
test('should change duration when using duration prop', () => { test('should change duration when using duration prop', () => {
wrapper = mount(Popup, { wrapper = mount(Popup, {
props: { props: {