From 68ffe0bddcf8568451c486744e3466393a5c277e Mon Sep 17 00:00:00 2001
From: neverland <chenjiahan@youzan.com>
Date: Thu, 27 Jun 2019 20:40:13 +0800
Subject: [PATCH] [improvement] Icon: add fit mode for image content (#3667)

---
 src/button/test/__snapshots__/demo.spec.js.snap | 2 +-
 src/icon/index.tsx                              | 2 +-
 src/icon/test/__snapshots__/index.spec.js.snap  | 4 ++--
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/button/test/__snapshots__/demo.spec.js.snap b/src/button/test/__snapshots__/demo.spec.js.snap
index 94c9a2ec5..a0bd8e34c 100644
--- a/src/button/test/__snapshots__/demo.spec.js.snap
+++ b/src/button/test/__snapshots__/demo.spec.js.snap
@@ -19,7 +19,7 @@ exports[`renders demo correctly 1`] = `
   <div><button class="van-button van-button--primary van-button--normal"><i class="van-icon van-icon-star-o van-button__icon">
         <!----></i></button> <button class="van-button van-button--primary van-button--normal"><i class="van-icon van-icon-star-o van-button__icon">
         <!----></i><span class="van-button__text">按钮</span></button> <button class="van-button van-button--primary van-button--normal van-button--plain"><i class="van-icon van-button__icon">
-        <div class="van-image van-icon__image"><img src="https://img.yzcdn.cn/vant/logo.png" class="van-image__img">
+        <div class="van-image van-icon__image"><img src="https://img.yzcdn.cn/vant/logo.png" class="van-image__img" style="object-fit: contain;">
           <div class="van-image__loading"><i class="van-icon van-icon-photo-o" style="font-size: 22px;">
               <!----></i></div>
         </div>
diff --git a/src/icon/index.tsx b/src/icon/index.tsx
index 832bdf7c1..22a85e735 100644
--- a/src/icon/index.tsx
+++ b/src/icon/index.tsx
@@ -44,7 +44,7 @@ function Icon(
       {...inherit(ctx, true)}
     >
       {slots.default && slots.default()}
-      {imageIcon && <Image class={bem('image')} src={props.name} />}
+      {imageIcon && <Image class={bem('image')} fit="contain" src={props.name} />}
       <Info info={props.info} />
     </props.tag>
   );
diff --git a/src/icon/test/__snapshots__/index.spec.js.snap b/src/icon/test/__snapshots__/index.spec.js.snap
index 0b1ffa937..25dd41d44 100644
--- a/src/icon/test/__snapshots__/index.spec.js.snap
+++ b/src/icon/test/__snapshots__/index.spec.js.snap
@@ -12,7 +12,7 @@ exports[`render icon with builtin icon name 1`] = `
 
 exports[`render icon with local image 1`] = `
 <i class="van-icon">
-  <div class="van-image van-icon__image"><img src="/assets/icon.jpg" class="van-image__img">
+  <div class="van-image van-icon__image"><img src="/assets/icon.jpg" class="van-image__img" style="object-fit: contain;">
     <div class="van-image__loading"><i class="van-icon van-icon-photo-o" style="font-size: 22px;">
         <!----></i></div>
   </div>
@@ -22,7 +22,7 @@ exports[`render icon with local image 1`] = `
 
 exports[`render icon with url name 1`] = `
 <i class="van-icon">
-  <div class="van-image van-icon__image"><img src="https://img.yzcdn.com/icon.jpg" class="van-image__img">
+  <div class="van-image van-icon__image"><img src="https://img.yzcdn.com/icon.jpg" class="van-image__img" style="object-fit: contain;">
     <div class="van-image__loading"><i class="van-icon van-icon-photo-o" style="font-size: 22px;">
         <!----></i></div>
   </div>