blackteay/vant
1
0
Fork 0
mirror of https://gitee.com/vant-contrib/vant.git synced 2025-04-06 03:57:59 +08:00
Code Issues Projects Releases Wiki Activity

[improvement] Dialog: enable lazy-render (#2495)

Browse Source
This commit is contained in:
neverland 2019-01-11 21:22:41 +08:00 committed by GitHub
parent c65e21e586
commit 5e623c1e34
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/address-edit/test/index.spec.js
View File

@ -218,6 +218,8 @@ test('delete address', async () => {
const deleteButton = wrapper.findAll('.van-button').at(1); const deleteButton = wrapper.findAll('.van-button').at(1);
deleteButton.trigger('click'); deleteButton.trigger('click');
await later();
document.querySelector('.van-dialog__cancel').click(); document.querySelector('.van-dialog__cancel').click();
deleteButton.trigger('click'); deleteButton.trigger('click');
document.querySelector('.van-dialog__confirm').click(); document.querySelector('.van-dialog__confirm').click();

2
packages/contact-card/test/index.spec.js
View File

@ -95,6 +95,8 @@ describe('ContactEdit', () => {
const deleteButton = wrapper.findAll('.van-button').at(1); const deleteButton = wrapper.findAll('.van-button').at(1);
deleteButton.trigger('click'); deleteButton.trigger('click');
await later();
document.querySelector('.van-dialog__confirm').click(); document.querySelector('.van-dialog__confirm').click();
await later(); await later();

1
packages/dialog/Dialog.vue
View File

@ -1,6 +1,7 @@
<template> <template>
<transition name="van-dialog-bounce"> <transition name="van-dialog-bounce">
<div <div
v-if="shouldRender"
v-show="value" v-show="value"
:class="[b(), className]" :class="[b(), className]"
> >

1
packages/dialog/demo/index.vue
View File

@ -38,6 +38,7 @@
<van-dialog <van-dialog
v-model="show" v-model="show"
show-cancel-button show-cancel-button
:lazy-render="false"
:before-close="beforeClose" :before-close="beforeClose"
> >
<van-field <van-field

4
packages/dialog/test/index.spec.js
View File

@ -9,10 +9,11 @@ test('Dialog function call', async () => {
Dialog.close(); Dialog.close();
Dialog.alert('1'); Dialog.alert('1');
await later();
const callback = jest.fn(); const callback = jest.fn();
const dialog = document.querySelector('.van-dialog'); const dialog = document.querySelector('.van-dialog');
await later();
expect(dialog.style.display).toEqual(''); expect(dialog.style.display).toEqual('');
Dialog.close(); Dialog.close();
@ -33,6 +34,7 @@ test('Dialog function call', async () => {
test('before close', () => { test('before close', () => {
const wrapper = mount(DialogVue, { const wrapper = mount(DialogVue, {
propsData: { propsData: {
value: true,
beforeClose: (action, done) => done(false) beforeClose: (action, done) => done(false)
} }
}); });