blackteay/vant
1
0
Fork 0
mirror of https://gitee.com/vant-contrib/vant.git synced 2025-05-21 22:09:16 +08:00
Code Issues Projects Releases Wiki Activity

[fix] Stepper: not fire event on changing the value prop #545 (#546)

Browse Source
This commit is contained in:
Li Chuangbo 2018-01-18 16:37:36 +13:00 committed by neverland
parent 633b835e01
commit 5c39921742
2 changed files with 24 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
packages/stepper/index.vue
View File

@ -77,11 +77,6 @@ export default create({
},
watch: {
currentValue(val) {
this.$emit('input', val);
this.$emit('change', val);
},
value(val) {
val = this.correctValue(+val);
if (val !== this.currentValue) {
@ -105,6 +100,7 @@ export default create({
onInput(event) {
const val = +event.target.value;
this.currentValue = this.correctValue(val);
this.emitInput();
},
onChange(type) {
@ -116,7 +112,13 @@ export default create({
const step = +this.step;
const currentValue = +this.currentValue;
this.currentValue = type === 'minus' ? (currentValue - step) : (currentValue + step);
this.emitInput();
this.$emit(type);
},
emitInput() {
this.$emit('input', this.currentValue);
this.$emit('change', this.currentValue);
}
}
});

20
test/unit/specs/stepper.spec.js
View File

@ -79,13 +79,11 @@ describe('Stepper', () => {
});
expect(wrapper.hasClass('van-stepper')).to.be.true;
const eventStub = sinon.stub(wrapper.vm, '$emit');
wrapper.vm.value = 2;
wrapper.update();
wrapper.vm.$nextTick(() => {
expect(eventStub.calledWith('input'));
expect(eventStub.calledWith('change'));
expect(wrapper.vm.currentValue).to.equal(2);
done();
});
});
@ -135,4 +133,20 @@ describe('Stepper', () => {
done();
});
});
it('should not fire any event on props changed', (done) => {
wrapper = mount(Stepper, {
propsData: {
value: 1
}
});
const eventStub = sinon.stub(wrapper.vm, '$emit');
wrapper.vm.value = 2;
wrapper.update();
wrapper.vm.$nextTick(() => {
expect(eventStub.called).to.be.false;
done();
});
});
});