blackteay/vant
1
0
Fork 0
mirror of https://gitee.com/vant-contrib/vant.git synced 2025-05-21 22:09:16 +08:00
Code Issues Projects Releases Wiki Activity

[Improvement] Mixins: treat empty string as true for boolean props (#468)

Browse Source
This commit is contained in:
Li Chuangbo 2017-12-22 17:08:50 +13:00 committed by neverland
parent b67c9956b2
commit 57abc04346
5 changed files with 23 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/actionsheet/index.vue
View File

@ -51,9 +51,11 @@ export default create({
default: () => []
},
overlay: {
type: Boolean,
default: true
},
closeOnClickOverlay: {
type: Boolean,
default: true
}
},

3
packages/dialog/dialog.vue
View File

@ -59,12 +59,15 @@ export default create({
default: false
},
overlay: {
type: Boolean,
default: true
},
closeOnClickOverlay: {
type: Boolean,
default: false
},
lockOnScroll: {
type: Boolean,
default: true
}
},

2
packages/image-preview/image-preview.vue
View File

@ -33,9 +33,11 @@ export default create({
props: {
overlay: {
type: Boolean,
default: true
},
closeOnClickOverlay: {
type: Boolean,
default: true
}
},

3
packages/popup/index.vue
View File

@ -18,12 +18,15 @@ export default create({
props: {
transition: String,
overlay: {
type: Boolean,
default: true
},
lockOnScroll: {
type: Boolean,
default: false
},
closeOnClickOverlay: {
type: Boolean,
default: true
},
position: {

12
test/unit/specs/popup.spec.js
View File

@ -113,4 +113,16 @@ describe('Popup', () => {
}, 300);
}, 300);
});
it('treat empty string as true for boolean props', () => {
wrapper = mount(Popup, {
propsData: {
overlay: '',
lockOnScroll: '',
closeOnClickOverlay: ''
}
});
expect(wrapper.vm.lockOnScroll).to.be.true;
});
});