From 4b8bd8e9be6b8c0ff52746e9f6a8803d69e20411 Mon Sep 17 00:00:00 2001
From: neverland <chenjiahan@buaa.edu.cn>
Date: Fri, 11 Jan 2019 23:19:41 +0800
Subject: [PATCH] [improvement] Collapse: jsx (#2501)

---
 .../collapse-item/{index.vue => index.js}     | 83 +++++++++----------
 packages/collapse/{index.vue => index.js}     | 21 ++---
 .../test/__snapshots__/demo.spec.js.snap      | 38 +++++----
 packages/collapse/zh-CN.md                    |  1 -
 4 files changed, 66 insertions(+), 77 deletions(-)
 rename packages/collapse-item/{index.vue => index.js} (67%)
 rename packages/collapse/{index.vue => index.js} (66%)

diff --git a/packages/collapse-item/index.vue b/packages/collapse-item/index.js
similarity index 67%
rename from packages/collapse-item/index.vue
rename to packages/collapse-item/index.js
index e9f62c405..773e3d14c 100644
--- a/packages/collapse-item/index.vue
+++ b/packages/collapse-item/index.js
@@ -1,50 +1,13 @@
-<template>
-  <div :class="[b(), { 'van-hairline--top': index }]">
-    <cell
-      v-bind="$props"
-      :class="b('title', { disabled, expanded })"
-      @click="onClick"
-    >
-      <slot
-        name="title"
-        slot="title"
-      />
-      <slot
-        name="icon"
-        slot="icon"
-      />
-      <slot name="value" />
-      <slot
-        name="right-icon"
-        slot="right-icon"
-      />
-    </cell>
-    <div
-      v-if="inited"
-      v-show="show"
-      ref="wrapper"
-      :class="b('wrapper')"
-      @transitionend="onTransitionEnd"
-    >
-      <div
-        ref="content"
-        :class="b('content')"
-      >
-        <slot />
-      </div>
-    </div>
-  </div>
-</template>
-
-<script>
+import { use, isDef } from '../utils';
 import { raf } from '../utils/raf';
-import create from '../utils/create';
+import Cell from '../cell';
 import CellMixin from '../mixins/cell';
 import FindParent from '../mixins/find-parent';
 
-export default create({
-  name: 'collapse-item',
+const [sfc, bem] = use('collapse-item');
+const CELL_SLOTS = ['title', 'icon', 'right-icon'];
 
+export default sfc({
   mixins: [CellMixin, FindParent],
 
   props: {
@@ -73,7 +36,7 @@ export default create({
     },
 
     currentName() {
-      return this.isDef(this.name) ? this.name : this.index;
+      return isDef(this.name) ? this.name : this.index;
     },
 
     expanded() {
@@ -144,6 +107,38 @@ export default create({
         this.$refs.wrapper.style.height = null;
       }
     }
+  },
+
+  render(h) {
+    const Title = (
+      <Cell
+        class={bem('title', { disabled: this.disabled, expanded: this.expanded })}
+        onClick={this.onClick}
+        {...{ props: this.$props }}
+      >
+        {this.$slots.value}
+        {CELL_SLOTS.map(slot => h('template', { slot }, this.$slots[slot]))}
+      </Cell>
+    );
+
+    const Content = this.inited && (
+      <div
+        v-show={this.show}
+        ref="wrapper"
+        class={bem('wrapper')}
+        onTransitionend={this.onTransitionEnd}
+      >
+        <div ref="content" class={bem('content')}>
+          {this.$slots.default}
+        </div>
+      </div>
+    );
+
+    return (
+      <div class={[bem(), { 'van-hairline--top': this.index }]}>
+        {Title}
+        {Content}
+      </div>
+    );
   }
 });
-</script>
diff --git a/packages/collapse/index.vue b/packages/collapse/index.js
similarity index 66%
rename from packages/collapse/index.vue
rename to packages/collapse/index.js
index 337a6391c..b209f5312 100644
--- a/packages/collapse/index.vue
+++ b/packages/collapse/index.js
@@ -1,18 +1,8 @@
-<template>
-  <div
-    :class="b()"
-    class="van-hairline--top-bottom"
-  >
-    <slot />
-  </div>
-</template>
+import { use } from '../utils';
 
-<script>
-import create from '../utils/create';
-
-export default create({
-  name: 'collapse',
+const [sfc, bem] = use('collapse');
 
+export default sfc({
   props: {
     accordion: Boolean,
     value: [String, Number, Array]
@@ -34,6 +24,9 @@ export default create({
       this.$emit('change', name);
       this.$emit('input', name);
     }
+  },
+
+  render(h) {
+    return <div class={[bem(), 'van-hairline--top-bottom']}>{this.$slots.default}</div>;
   }
 });
-</script>
diff --git a/packages/collapse/test/__snapshots__/demo.spec.js.snap b/packages/collapse/test/__snapshots__/demo.spec.js.snap
index 06ae6199f..ca4a18e30 100644
--- a/packages/collapse/test/__snapshots__/demo.spec.js.snap
+++ b/packages/collapse/test/__snapshots__/demo.spec.js.snap
@@ -3,12 +3,13 @@
 exports[`renders demo correctly 1`] = `
 <div>
   <div>
-    <div class="van-hairline--top-bottom van-collapse">
+    <div class="van-collapse van-hairline--top-bottom">
       <div class="van-collapse-item">
         <div class="van-cell van-cell--clickable van-collapse-item__title van-collapse-item__title--expanded">
           <div class="van-cell__title"><span>有赞微商城</span>
           </div>
-          <div class="van-cell__value"> </div>
+          <div class="van-cell__value">
+          </div>
           <i class="van-icon van-icon-arrow van-cell__right-icon" style="color:undefined;font-size:undefined;">
             <!---->
             <!----></i>
@@ -21,33 +22,34 @@ exports[`renders demo correctly 1`] = `
         <div class="van-cell van-cell--clickable van-collapse-item__title">
           <div class="van-cell__title"><span>有赞零售</span>
           </div>
-          <div class="van-cell__value"> </div>
+          <div class="van-cell__value">
+          </div>
           <i class="van-icon van-icon-arrow van-cell__right-icon" style="color:undefined;font-size:undefined;">
             <!---->
             <!----></i>
         </div>
-        <!---->
       </div>
       <div class="van-collapse-item van-hairline--top">
-        <div disabled="disabled" class="van-cell van-cell--clickable van-collapse-item__title van-collapse-item__title--disabled">
+        <div class="van-cell van-cell--clickable van-collapse-item__title van-collapse-item__title--disabled">
           <div class="van-cell__title"><span>有赞美业</span>
           </div>
-          <div class="van-cell__value"> </div>
+          <div class="van-cell__value">
+          </div>
           <i class="van-icon van-icon-arrow van-cell__right-icon" style="color:undefined;font-size:undefined;">
             <!---->
             <!----></i>
         </div>
-        <!---->
       </div>
     </div>
   </div>
   <div>
-    <div class="van-hairline--top-bottom van-collapse">
+    <div class="van-collapse van-hairline--top-bottom">
       <div class="van-collapse-item">
         <div class="van-cell van-cell--clickable van-collapse-item__title van-collapse-item__title--expanded">
           <div class="van-cell__title"><span>有赞微商城</span>
           </div>
-          <div class="van-cell__value"> </div>
+          <div class="van-cell__value">
+          </div>
           <i class="van-icon van-icon-arrow van-cell__right-icon" style="color:undefined;font-size:undefined;">
             <!---->
             <!----></i>
@@ -60,28 +62,28 @@ exports[`renders demo correctly 1`] = `
         <div class="van-cell van-cell--clickable van-collapse-item__title">
           <div class="van-cell__title"><span>有赞零售</span>
           </div>
-          <div class="van-cell__value"> </div>
+          <div class="van-cell__value">
+          </div>
           <i class="van-icon van-icon-arrow van-cell__right-icon" style="color:undefined;font-size:undefined;">
             <!---->
             <!----></i>
         </div>
-        <!---->
       </div>
       <div class="van-collapse-item van-hairline--top">
         <div class="van-cell van-cell--clickable van-collapse-item__title">
           <div class="van-cell__title"><span>有赞美业</span>
           </div>
-          <div class="van-cell__value"> </div>
+          <div class="van-cell__value">
+          </div>
           <i class="van-icon van-icon-arrow van-cell__right-icon" style="color:undefined;font-size:undefined;">
             <!---->
             <!----></i>
         </div>
-        <!---->
       </div>
     </div>
   </div>
   <div>
-    <div class="van-hairline--top-bottom van-collapse">
+    <div class="van-collapse van-hairline--top-bottom">
       <div class="van-collapse-item">
         <div class="van-cell van-cell--clickable van-collapse-item__title">
           <div class="van-cell__title">
@@ -89,12 +91,12 @@ exports[`renders demo correctly 1`] = `
                 <!---->
                 <!----></i></div>
           </div>
-          <div class="van-cell__value"> </div>
+          <div class="van-cell__value">
+          </div>
           <i class="van-icon van-icon-arrow van-cell__right-icon" style="color:undefined;font-size:undefined;">
             <!---->
             <!----></i>
         </div>
-        <!---->
       </div>
       <div class="van-collapse-item van-hairline--top">
         <div class="van-cell van-cell--clickable van-collapse-item__title"><i class="van-icon van-icon-shop-o van-cell__left-icon" style="color:undefined;font-size:undefined;">
@@ -102,12 +104,12 @@ exports[`renders demo correctly 1`] = `
             <!----></i>
           <div class="van-cell__title"><span>有赞零售</span>
           </div>
-          <div class="van-cell__value"> </div>
+          <div class="van-cell__value">
+          </div>
           <i class="van-icon van-icon-arrow van-cell__right-icon" style="color:undefined;font-size:undefined;">
             <!---->
             <!----></i>
         </div>
-        <!---->
       </div>
     </div>
   </div>
diff --git a/packages/collapse/zh-CN.md b/packages/collapse/zh-CN.md
index 9ea611e28..00ce3bf74 100644
--- a/packages/collapse/zh-CN.md
+++ b/packages/collapse/zh-CN.md
@@ -121,4 +121,3 @@ export default {
 | icon | 自定义`icon` |
 | title | 自定义`title` |
 | right-icon | 自定义右侧按钮，默认是`arrow` |
-