From 46a7aefc659fd0bbff84f0b0c11f5799baf4aef1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E9=99=88=E5=98=89=E6=B6=B5?= Date: Thu, 19 Dec 2019 14:10:09 +0800 Subject: [PATCH] fix(cli): should exit process when lint failed --- packages/vant-cli/src/commands/lint.ts | 26 +++++++++++++++++--------- 1 file changed, 17 insertions(+), 9 deletions(-) diff --git a/packages/vant-cli/src/commands/lint.ts b/packages/vant-cli/src/commands/lint.ts index 0949aaacb..47b22136d 100644 --- a/packages/vant-cli/src/commands/lint.ts +++ b/packages/vant-cli/src/commands/lint.ts @@ -22,28 +22,36 @@ function lintScript() { const formatted = formatter(report.results); if (formatted) { stepper.error('ESLint Failed', '\n' + formatter(report.results)); - } else { - stepper.success('ESLint Passed'); + return false; } + + stepper.success('ESLint Passed'); + return true; } -function lintStyle() { +async function lintStyle(): Promise { stepper.start('Stylelint Start'); - stylelint({ + return stylelint({ fix: true, formatter: 'string', files: ['src/**/*.css', 'src/**/*.less', 'src/**/*.scss', 'src/**/*.vue'] }).then(result => { if (result.errored) { stepper.error('Stylelint Failed', '\n' + result.output); - } else { - stepper.success('Stylelint Passed'); + return false; } + + stepper.success('Stylelint Passed'); + return true; }); } -export function lint() { - lintScript(); - lintStyle(); +export async function lint() { + const scriptPassed = lintScript(); + const stylePassed = await lintStyle(); + + if (!scriptPassed || !stylePassed) { + process.exit(1); + } }