From 38afa3dffd034182ec111f2d4984e0674b200a33 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E9=99=88=E5=98=89=E6=B6=B5?= <chenjiahan@youzan.com>
Date: Sat, 25 May 2019 12:33:52 +0800
Subject: [PATCH] [bugfix] GoodsAction: should have tabindex

---
 packages/circle/test/__snapshots__/demo.spec.js.snap   |  4 ++--
 packages/goods-action-icon/index.less                  |  4 ++++
 packages/goods-action-icon/index.tsx                   |  1 +
 .../goods-action/test/__snapshots__/demo.spec.js.snap  | 10 +++++-----
 .../goods-action/test/__snapshots__/index.spec.js.snap |  2 +-
 5 files changed, 13 insertions(+), 8 deletions(-)

diff --git a/packages/circle/test/__snapshots__/demo.spec.js.snap b/packages/circle/test/__snapshots__/demo.spec.js.snap
index 412a16ec4..3e9802090 100644
--- a/packages/circle/test/__snapshots__/demo.spec.js.snap
+++ b/packages/circle/test/__snapshots__/demo.spec.js.snap
@@ -5,9 +5,9 @@ exports[`renders demo correctly 1`] = `
   <div>
     <div class="van-circle" style="width: 120px; height: 120px;"><svg viewBox="0 0 1060 1060">
         <path d="M 530 530 m -500, 0 a 500, 500 0 1, 1 1000, 0 a 500, 500 0 1, 1 -1000, 0" class="van-circle__hover" style="fill: none; stroke: #fff; stroke-width: 40px;"></path>
-        <path d="M 530 530 m -500, 0 a 500, 500 0 1, 1 1000, 0 a 500, 500 0 1, 1 -1000, 0" class="van-circle__layer" style="stroke: #1989fa; stroke-dashoffset: 3140px; stroke-width: 41px;"></path>
+        <path d="M 530 530 m -500, 0 a 500, 500 0 1, 1 1000, 0 a 500, 500 0 1, 1 -1000, 0" class="van-circle__layer" style="stroke: #1989fa; stroke-dashoffset: 3083.48px; stroke-width: 41px;"></path>
       </svg>
-      <div class="van-circle__text">0%</div>
+      <div class="van-circle__text">2%</div>
     </div>
     <div class="van-circle" style="width: 120px; height: 120px;"><svg viewBox="0 0 1060 1060">
         <path d="M 530 530 m -500, 0 a 500, 500 0 1, 1 1000, 0 a 500, 500 0 1, 1 -1000, 0" class="van-circle__hover" style="fill: #fff; stroke: #ebedf0; stroke-width: 60px;"></path>
diff --git a/packages/goods-action-icon/index.less b/packages/goods-action-icon/index.less
index 1b6e7a217..ac85f7094 100644
--- a/packages/goods-action-icon/index.less
+++ b/packages/goods-action-icon/index.less
@@ -16,6 +16,10 @@
     border-left-width: 1px;
   }
 
+  &:focus {
+    outline: none;
+  }
+
   &:active {
     background-color: @goods-action-icon-active-color;
   }
diff --git a/packages/goods-action-icon/index.tsx b/packages/goods-action-icon/index.tsx
index faa41b52d..472da2bba 100644
--- a/packages/goods-action-icon/index.tsx
+++ b/packages/goods-action-icon/index.tsx
@@ -30,6 +30,7 @@ function GoodsActionIcon(
   return (
     <div
       role="button"
+      tabindex="0"
       class={[bem(), 'van-hairline']}
       onClick={onClick}
       {...inherit(ctx)}
diff --git a/packages/goods-action/test/__snapshots__/demo.spec.js.snap b/packages/goods-action/test/__snapshots__/demo.spec.js.snap
index 114bb1742..bf739351c 100644
--- a/packages/goods-action/test/__snapshots__/demo.spec.js.snap
+++ b/packages/goods-action/test/__snapshots__/demo.spec.js.snap
@@ -4,12 +4,12 @@ exports[`renders demo correctly 1`] = `
 <div>
   <div>
     <div class="van-goods-action">
-      <div role="button" class="van-goods-action-icon van-hairline">
+      <div role="button" tabindex="0" class="van-goods-action-icon van-hairline">
         <div class="van-icon van-icon-chat-o van-goods-action-icon__icon">
           <!---->
         </div>客服
       </div>
-      <div role="button" class="van-goods-action-icon van-hairline">
+      <div role="button" tabindex="0" class="van-goods-action-icon van-hairline">
         <div class="van-icon van-icon-cart-o van-goods-action-icon__icon">
           <!---->
         </div>购物车
@@ -18,17 +18,17 @@ exports[`renders demo correctly 1`] = `
   </div>
   <div>
     <div class="van-goods-action">
-      <div role="button" class="van-goods-action-icon van-hairline">
+      <div role="button" tabindex="0" class="van-goods-action-icon van-hairline">
         <div class="van-icon van-icon-chat-o van-goods-action-icon__icon">
           <!---->
         </div>客服
       </div>
-      <div role="button" class="van-goods-action-icon van-hairline">
+      <div role="button" tabindex="0" class="van-goods-action-icon van-hairline">
         <div class="van-icon van-icon-cart-o van-goods-action-icon__icon">
           <div class="van-info">5</div>
         </div>购物车
       </div>
-      <div role="button" class="van-goods-action-icon van-hairline">
+      <div role="button" tabindex="0" class="van-goods-action-icon van-hairline">
         <div class="van-icon van-icon-shop-o van-goods-action-icon__icon">
           <!---->
         </div>店铺
diff --git a/packages/goods-action/test/__snapshots__/index.spec.js.snap b/packages/goods-action/test/__snapshots__/index.spec.js.snap
index b9abe7806..33a411174 100644
--- a/packages/goods-action/test/__snapshots__/index.spec.js.snap
+++ b/packages/goods-action/test/__snapshots__/index.spec.js.snap
@@ -3,7 +3,7 @@
 exports[`Button render default slot 1`] = `<button class="van-button van-button--default van-button--large van-button--square van-goods-action-button"><span class="van-button__text">Default Content</span></button>`;
 
 exports[`Icon render default slot 1`] = `
-<div role="button" class="van-goods-action-icon van-hairline">
+<div role="button" tabindex="0" class="van-goods-action-icon van-hairline">
   <div class="van-icon van-icon-undefined van-goods-action-icon__icon">
     <!---->
   </div>Default Content