From 1f917e9a2ac3059d0602c5f1b368283a93aa9a9b Mon Sep 17 00:00:00 2001 From: neverland Date: Sun, 13 Nov 2022 10:26:41 +0800 Subject: [PATCH] fix(Picker): empty column will cause error (#11249) --- packages/vant/src/picker/PickerColumn.tsx | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/packages/vant/src/picker/PickerColumn.tsx b/packages/vant/src/picker/PickerColumn.tsx index f566222c3..7e5fa5d14 100644 --- a/packages/vant/src/picker/PickerColumn.tsx +++ b/packages/vant/src/picker/PickerColumn.tsx @@ -97,8 +97,10 @@ export default defineComponent({ currentOffset.value = offset; }; + const isReadonly = () => props.readonly || !props.options.length; + const onClickOption = (index: number) => { - if (moving || props.readonly) { + if (moving || isReadonly()) { return; } @@ -134,7 +136,7 @@ export default defineComponent({ }; const onTouchStart = (event: TouchEvent) => { - if (props.readonly) { + if (isReadonly()) { return; } @@ -153,7 +155,7 @@ export default defineComponent({ }; const onTouchMove = (event: TouchEvent) => { - if (props.readonly) { + if (isReadonly()) { return; } @@ -178,7 +180,7 @@ export default defineComponent({ }; const onTouchEnd = () => { - if (props.readonly) { + if (isReadonly()) { return; }