blackteay/vant
1
0
Fork 0
mirror of https://gitee.com/vant-contrib/vant.git synced 2025-04-06 03:57:59 +08:00
Code Issues Projects Releases Wiki Activity

fix(Tabs): incorrect scroll position when offset-top has unit (#7143)

Browse Source
This commit is contained in:
neverland 2020-09-09 18:00:15 +08:00 committed by GitHub
parent 3dddeaa7a3
commit 14b2f343e2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/tabs/index.js
View File

@ -4,6 +4,7 @@ import { scrollLeftTo, scrollTopTo } from './utils';
import { route } from '../utils/router'; import { route } from '../utils/router';
import { isHidden } from '../utils/dom/style'; import { isHidden } from '../utils/dom/style';
import { on, off } from '../utils/dom/event'; import { on, off } from '../utils/dom/event';
import { unitToPx } from '../utils/format/unit';
import { BORDER_TOP_BOTTOM } from '../utils/constant'; import { BORDER_TOP_BOTTOM } from '../utils/constant';
import { callInterceptor } from '../utils/interceptor'; import { callInterceptor } from '../utils/interceptor';
import { import {
@ -119,9 +120,13 @@ export default createComponent({
} }
}, },
offsetTopPx() {
return unitToPx(this.offsetTop);
},
scrollOffset() { scrollOffset() {
if (this.sticky) { if (this.sticky) {
return +this.offsetTop + this.tabHeight; return this.offsetTopPx + this.tabHeight;
} }
return 0; return 0;
}, },
@ -151,7 +156,7 @@ export default createComponent({
// scroll to correct position // scroll to correct position
if (this.stickyFixed && !this.scrollspy) { if (this.stickyFixed && !this.scrollspy) {
setRootScrollTop(Math.ceil(getElementTop(this.$el) - this.offsetTop)); setRootScrollTop(Math.ceil(getElementTop(this.$el) - this.offsetTopPx));
} }
}, },