From 0164c33fa5449c6ffd6ed673861d9048409339a1 Mon Sep 17 00:00:00 2001
From: neverland <chenjiahan@youzan.com>
Date: Thu, 7 Nov 2019 17:30:21 +0800
Subject: [PATCH] fix(List): may trigger load event repeatedly (#4953)

---
 src/list/index.js           | 67 ++++++++++++++++++++++++++-----------
 src/list/test/index.spec.js |  5 +--
 2 files changed, 49 insertions(+), 23 deletions(-)

diff --git a/src/list/index.js b/src/list/index.js
index f7f22a132..a824d1f29 100644
--- a/src/list/index.js
+++ b/src/list/index.js
@@ -42,6 +42,13 @@ export default createComponent({
     }
   },
 
+  data() {
+    return {
+      // use sync innerLoading state to avoid repeated loading in some edge cases
+      innerLoading: this.loading
+    };
+  },
+
   mounted() {
     if (this.immediateCheck) {
       this.check();
@@ -49,14 +56,17 @@ export default createComponent({
   },
 
   watch: {
-    loading: 'check',
-    finished: 'check'
+    finished: 'check',
+    loading(val) {
+      this.innerLoading = val;
+      this.check();
+    }
   },
 
   methods: {
     check() {
       this.$nextTick(() => {
-        if (this.loading || this.finished || this.error) {
+        if (this.innerLoading || this.finished || this.error) {
           return;
         }
 
@@ -89,6 +99,7 @@ export default createComponent({
         }
 
         if (isReachEdge) {
+          this.innerLoading = true;
           this.$emit('input', true);
           this.$emit('load');
         }
@@ -98,6 +109,36 @@ export default createComponent({
     clickErrorText() {
       this.$emit('update:error', false);
       this.check();
+    },
+
+    genLoading() {
+      if (this.innerLoading) {
+        return (
+          <div class={bem('loading')} key="loading">
+            {this.slots('loading') || (
+              <Loading size="16">{this.loadingText || t('loading')}</Loading>
+            )}
+          </div>
+        );
+      }
+    },
+
+    genFinishedText() {
+      if (this.finished && this.finishedText) {
+        return (
+          <div class={bem('finished-text')}>{this.finishedText}</div>
+        );
+      }
+    },
+
+    genErrorText() {
+      if (this.error && this.errorText) {
+        return (
+          <div onClick={this.clickErrorText} class={bem('error-text')}>
+            {this.errorText}
+          </div>
+        );
+      }
     }
   },
 
@@ -105,23 +146,11 @@ export default createComponent({
     const Placeholder = <div ref="placeholder" class={bem('placeholder')} />;
 
     return (
-      <div class={bem()} role="feed" aria-busy={this.loading}>
+      <div class={bem()} role="feed" aria-busy={this.innerLoading}>
         {this.direction === 'down' ? this.slots() : Placeholder}
-        {this.loading && (
-          <div class={bem('loading')} key="loading">
-            {this.slots('loading') || (
-              <Loading size="16">{this.loadingText || t('loading')}</Loading>
-            )}
-          </div>
-        )}
-        {this.finished && this.finishedText && (
-          <div class={bem('finished-text')}>{this.finishedText}</div>
-        )}
-        {this.error && this.errorText && (
-          <div onClick={this.clickErrorText} class={bem('error-text')}>
-            {this.errorText}
-          </div>
-        )}
+        {this.genLoading()}
+        {this.genFinishedText()}
+        {this.genErrorText()}
         {this.direction === 'up' ? this.slots() : Placeholder}
       </div>
     );
diff --git a/src/list/test/index.spec.js b/src/list/test/index.spec.js
index c13606d53..8a709bfec 100644
--- a/src/list/test/index.spec.js
+++ b/src/list/test/index.spec.js
@@ -108,7 +108,7 @@ test('check the case that scroller is not window', async () => {
   restoreMock();
 });
 
-test('check the direction props', async () => {
+test('check the direction props', () => {
   const wrapper = mount(List, {
     slots: {
       default: '<div class="list-item">list item</div>'
@@ -118,8 +118,6 @@ test('check the direction props', async () => {
     }
   });
 
-  await later();
-
   let children = wrapper.findAll('.van-list > div');
   expect(children.at(0).is('.van-list__placeholder')).toBeTruthy();
   expect(children.at(1).is('.list-item')).toBeTruthy();
@@ -129,7 +127,6 @@ test('check the direction props', async () => {
     direction: 'down'
   });
 
-  await later();
   children = wrapper.findAll('.van-list > div');
   expect(children.at(0).is('.list-item')).toBeTruthy();
   expect(children.at(1).is('.van-list__placeholder')).toBeTruthy();