blackteay/vant-weapp
1
0
Fork 0
mirror of https://gitee.com/vant-contrib/vant-weapp.git synced 2025-04-05 19:41:45 +08:00
Code Issues Projects Releases Wiki Activity

[improvement] Icon: reduce setData (#1009)

Browse Source
This commit is contained in:
neverland 2018-12-04 14:36:14 +08:00 committed by GitHub
parent 5064c0c397
commit 4303aa34b5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 11 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
build/compiler.js
View File

@ -10,7 +10,7 @@ const postcss = require('gulp-postcss');
const isProduction = process.env.NODE_ENV === 'production'; const isProduction = process.env.NODE_ENV === 'production';
const src = path.join(__dirname, '../packages'); const src = path.join(__dirname, '../packages');
const dist = path.join(__dirname, isProduction ? '../dist' : '../example/dist'); const dist = path.join(__dirname, isProduction ? '../dist' : '../example/dist');
const ext = ['ts', 'less', 'json', 'wxml']; const ext = ['ts', 'less', 'json', 'wxml', 'wxs'];
function copy(ext) { function copy(ext) {
return gulp.src([src + '/**/*.' + ext]).pipe(gulp.dest(dist)); return gulp.src([src + '/**/*.' + ext]).pipe(gulp.dest(dist));
@ -45,6 +45,7 @@ gulp.task('compile-ts', () =>
}) })
.pipe(gulp.dest(dist)) .pipe(gulp.dest(dist))
); );
gulp.task('compile-wxs', () => copy('wxs'));
gulp.task('compile-json', () => copy('json')); gulp.task('compile-json', () => copy('json'));
gulp.task('compile-wxml', () => copy('wxml')); gulp.task('compile-wxml', () => copy('wxml'));
gulp.task('build', ext.map(ext => 'compile-' + ext)); gulp.task('build', ext.map(ext => 'compile-' + ext));

5
packages/common/utils.ts
View File

@ -11,13 +11,8 @@ function isNumber(value) {
return /^\d+$/.test(value); return /^\d+$/.test(value);
} }
function isSrc(url) {
return /^(https?:)?\/\/|data:image/.test(url);
}
export { export {
isObj, isObj,
isDef, isDef,
isSrc,
isNumber isNumber
}; };

5
packages/common/utils.wxs Normal file
View File

@ -0,0 +1,5 @@
function isSrc(url) {
return url.indexOf('http') === 0 || url.indexOf('data:image') === 0;
}
module.exports.isSrc = isSrc;

7
packages/icon/index.ts
View File

@ -1,4 +1,3 @@
import { isSrc } from '../common/utils';
import { VantComponent } from '../common/component'; import { VantComponent } from '../common/component';
VantComponent({ VantComponent({
@ -14,12 +13,6 @@ VantComponent({
} }
}, },
computed: {
isSrc() {
return isSrc(this.data.name);
}
},
methods: { methods: {
onClick() { onClick() {
this.$emit('click'); this.$emit('click');

6
packages/icon/index.wxml
View File

@ -1,5 +1,5 @@
<view <view
class="custom-class {{ classPrefix }} {{ isSrc ? 'van-icon--image' : classPrefix + '-' + name }}" class="custom-class {{ classPrefix }} {{ utils.isSrc(name) ? 'van-icon--image' : classPrefix + '-' + name }}"
style="{{ color ? 'color: ' + color + ';' : '' }}{{ size ? 'font-size: ' + size + ';' : '' }}{{ customStyle }}" style="{{ color ? 'color: ' + color + ';' : '' }}{{ size ? 'font-size: ' + size + ';' : '' }}{{ customStyle }}"
bind:tap="onClick" bind:tap="onClick"
> >
@ -10,7 +10,9 @@
{{ info }} {{ info }}
</view> </view>
<image <image
wx:if="{{ isSrc }}" wx:if="{{ utils.isSrc(name) }}"
src="{{ name }}" src="{{ name }}"
/> />
</view> </view>
<wxs src="../common/utils.wxs" module="utils" />