blackteay/vant-weapp
1
0
Fork 0
mirror of https://gitee.com/vant-contrib/vant-weapp.git synced 2025-04-06 03:58:05 +08:00
Code Issues Projects Releases Wiki Activity

perf(Rate): remove unreachable code (#2332)

Browse Source
This commit is contained in:
rex 2019-11-18 21:13:25 +08:00 committed by GitHub
parent 60ecf66954
commit 3ccb51c4c6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 4 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
example/pages/rate/index.wxml
View File

@ -21,7 +21,7 @@
custom-class="van-rate" custom-class="van-rate"
data-key="value3" data-key="value3"
value="{{ value3 }}" value="{{ value3 }}"
size="{{ 250 }}" size="{{ 25 }}"
color="#ee0a24" color="#ee0a24"
void-color="#eee" void-color="#eee"
void-icon="star" void-icon="star"

14
packages/rate/index.ts
View File

@ -12,10 +12,7 @@ VantComponent({
readonly: Boolean, readonly: Boolean,
disabled: Boolean, disabled: Boolean,
allowHalf: Boolean, allowHalf: Boolean,
size: { size: null,
type: null,
observer: 'setSizeWithUnit'
},
icon: { icon: {
type: String, type: String,
value: 'star' value: 'star'
@ -52,8 +49,7 @@ VantComponent({
data: { data: {
innerValue: 0, innerValue: 0,
gutterWithUnit: undefined, gutterWithUnit: undefined
sizeWithUnit: '20px'
}, },
watch: { watch: {
@ -65,12 +61,6 @@ VantComponent({
}, },
methods: { methods: {
setSizeWithUnit(val) {
this.setData({
sizeWithUnit: addUnit(val)
});
},
setGutterWithUnit(val) { setGutterWithUnit(val) {
this.setData({ this.setData({
gutterWithUnit: addUnit(val) gutterWithUnit: addUnit(val)

2
packages/rate/index.wxml
View File

@ -8,7 +8,7 @@
class="van-rate__item" class="van-rate__item"
wx:for="{{ count }}" wx:for="{{ count }}"
wx:key="index" wx:key="index"
style="font-size: {{ sizeWithUnit }};padding-right: {{ index !== count - 1 ? gutterWithUnit : '' }}" style="padding-right: {{ index !== count - 1 ? gutterWithUnit : '' }}"
> >
<van-icon <van-icon
name="{{ index + 1 <= innerValue ? icon : voidIcon }}" name="{{ index + 1 <= innerValue ? icon : voidIcon }}"