diff --git a/__test__/app/autocomplete.spec.ts b/__test__/app/autocomplete.spec.ts new file mode 100644 index 00000000..49c25787 --- /dev/null +++ b/__test__/app/autocomplete.spec.ts @@ -0,0 +1,29 @@ +import { installAutocompleteDefaults } from '@/app-components/provider/AppAutocompleteDefaults' + +describe('autocomplete defaults', () => { + it('handles present and newly mounted controls and respects explicit opt-ins', async () => { + const root = document.createElement('div') + + root.innerHTML = + '
' + const stop = installAutocompleteDefaults(root) + + try { + expect(root.querySelector('input')?.autocomplete).toBe('off') + expect(root.querySelector('input[autocomplete=email]')).not.toBeNull() + expect(root.querySelector('textarea')?.hasAttribute('autocomplete')).toBe( + false, + ) + + const portal = document.createElement('div') + + portal.innerHTML = '' + root.append(portal) + await new Promise((resolve) => setTimeout(resolve, 0)) + expect(portal.querySelector('input')?.autocomplete).toBe('off') + expect(portal.querySelector('textarea')?.autocomplete).toBe('off') + } finally { + stop() + } + }) +}) diff --git a/src/app-components/provider/AppAutocompleteDefaults/index.ts b/src/app-components/provider/AppAutocompleteDefaults/index.ts new file mode 100644 index 00000000..025a27db --- /dev/null +++ b/src/app-components/provider/AppAutocompleteDefaults/index.ts @@ -0,0 +1,32 @@ +const controls = + 'input:not([type="hidden"],[type="checkbox"],[type="radio"],[type="button"],[type="submit"],[type="file"],[type="reset"]), textarea, select' + +export function installAutocompleteDefaults(root: HTMLElement) { + const apply = (element: Element) => { + if (element.hasAttribute('autocomplete')) return + + const form = (element as HTMLInputElement).form + + if (form?.getAttribute('autocomplete') === 'on') return + + element.setAttribute('autocomplete', 'off') + } + + const applyToTree = (node: Node) => { + if (!(node instanceof Element)) return + + if (node.matches(controls)) apply(node) + + node.querySelectorAll(controls).forEach(apply) + } + + applyToTree(root) + // 只检查新增子树,同时覆盖 Teleport 到 body 的搜索框、弹窗和下拉面板。 + const observer = new MutationObserver((mutations) => { + for (const mutation of mutations) mutation.addedNodes.forEach(applyToTree) + }) + + observer.observe(root, { childList: true, subtree: true }) + + return () => observer.disconnect() +} diff --git a/src/components/RForm/src/Form.tsx b/src/components/RForm/src/Form.tsx index 394b6f9e..4286ea25 100644 --- a/src/components/RForm/src/Form.tsx +++ b/src/components/RForm/src/Form.tsx @@ -1,4 +1,4 @@ -import { call, unrefElement } from '@/utils' +import { call } from '@/utils' import { useEventListener } from '@vueuse/core' import { NForm, NSpin } from 'naive-ui' import { useTemplateRef } from 'vue' @@ -42,16 +42,6 @@ export default defineComponent({ if (onRegister && formRef.value) { call(onRegister, formRef.value) } - - if (formRef.value) { - const formElement = unrefElement( - formRef.value as unknown as HTMLFormElement, - ) - - if (formElement) { - formElement.autocomplete = props.autocomplete - } - } }) expose() @@ -62,7 +52,7 @@ export default defineComponent({ }, render() { const { $attrs, $props, $slots } = this - const { loading, loadingDescription, ...restProps } = $props + const { loading, loadingDescription, autocomplete, ...restProps } = $props return (