tidy code

This commit is contained in:
wenxu12345 2021-12-28 21:17:41 +08:00
parent 39ceb20332
commit 47a3c3c253
5 changed files with 34 additions and 14 deletions

View File

@ -94,7 +94,7 @@ func (s *groupServer) CreateGroup(ctx context.Context, req *pbGroup.CreateGroupR
} }
//to group member //to group member
groupMember := imdb.GroupMember{GroupID: groupId, RoleLevel: 1} groupMember := imdb.GroupMember{GroupID: groupId, RoleLevel: constant.GroupOwner}
utils.CopyStructFields(&groupMember, us) utils.CopyStructFields(&groupMember, us)
err = im_mysql_model.InsertIntoGroupMember(groupMember) err = im_mysql_model.InsertIntoGroupMember(groupMember)
if err != nil { if err != nil {
@ -114,7 +114,7 @@ func (s *groupServer) CreateGroup(ctx context.Context, req *pbGroup.CreateGroupR
log.NewError(req.OperationID, "FindUserByUID failed ", err.Error(), user.UserID) log.NewError(req.OperationID, "FindUserByUID failed ", err.Error(), user.UserID)
continue continue
} }
if user.RoleLevel == 1 { if user.RoleLevel == constant.GroupOwner {
log.NewError(req.OperationID, "only one owner, failed ", user) log.NewError(req.OperationID, "only one owner, failed ", user)
continue continue
} }
@ -224,7 +224,7 @@ func (s *groupServer) InviteUserToGroup(ctx context.Context, req *pbGroup.Invite
var toInsertInfo imdb.GroupMember var toInsertInfo imdb.GroupMember
utils.CopyStructFields(&toInsertInfo, toUserInfo) utils.CopyStructFields(&toInsertInfo, toUserInfo)
toInsertInfo.GroupID = req.GroupID toInsertInfo.GroupID = req.GroupID
toInsertInfo.RoleLevel = 0 toInsertInfo.RoleLevel = constant.GroupOrdinaryUsers
err = imdb.InsertIntoGroupMember(toInsertInfo) err = imdb.InsertIntoGroupMember(toInsertInfo)
if err != nil { if err != nil {
log.NewError(req.OperationID, "InsertIntoGroupMember failed ", req.GroupID, toUserInfo.UserID, toUserInfo.Nickname, toUserInfo.FaceUrl) log.NewError(req.OperationID, "InsertIntoGroupMember failed ", req.GroupID, toUserInfo.UserID, toUserInfo.Nickname, toUserInfo.FaceUrl)
@ -331,7 +331,7 @@ func (s *groupServer) KickGroupMember(ctx context.Context, req *pbGroup.KickGrou
groupOwnerUserID := "" groupOwnerUserID := ""
for _, v := range ownerList { for _, v := range ownerList {
if v.RoleLevel == 1 { if v.RoleLevel == constant.GroupOwner {
groupOwnerUserID = v.UserID groupOwnerUserID = v.UserID
} }
} }

View File

@ -3,12 +3,12 @@ package constant
const ( const (
//group admin //group admin
OrdinaryMember = 0 // OrdinaryMember = 0
GroupOwner = 1 // GroupOwner = 1
Administrator = 2 // Administrator = 2
//group application //group application
Application = 0 // Application = 0
AgreeApplication = 1 // AgreeApplication = 1
//friend related //friend related
BlackListFlag = 1 BlackListFlag = 1
@ -117,4 +117,16 @@ var ContentType2PushContent = map[int64]string{
Common: "你收到一条新消息", Common: "你收到一条新消息",
} }
const (
AppOrdinaryUsers = 1
AppAdmin = 2
GroupOrdinaryUsers = 1
GroupOwner = 2
GroupAdmin = 3
Male = 1
Female = 2
)
const FriendAcceptTip = "You have successfully become friends, so start chatting" const FriendAcceptTip = "You have successfully become friends, so start chatting"

View File

@ -1,6 +1,7 @@
package im_mysql_model package im_mysql_model
import ( import (
"Open_IM/pkg/common/constant"
"Open_IM/pkg/common/db" "Open_IM/pkg/common/db"
"time" "time"
) )
@ -23,6 +24,9 @@ func InsertIntoGroupMember(toInsertInfo GroupMember) error {
return err return err
} }
toInsertInfo.JoinSource = time.Now() toInsertInfo.JoinSource = time.Now()
if toInsertInfo.RoleLevel == 0 {
toInsertInfo.RoleLevel = constant.GroupOrdinaryUsers
}
err = dbConn.Table("group_member").Create(toInsertInfo).Error err = dbConn.Table("group_member").Create(toInsertInfo).Error
if err != nil { if err != nil {
return err return err
@ -138,7 +142,7 @@ func GetGroupOwnerInfoByGroupID(groupID string) (*GroupMember, error) {
return nil, err return nil, err
} }
for _, v := range omList { for _, v := range omList {
if v.RoleLevel == 1 { if v.RoleLevel == constant.GroupOwner {
return &v, nil return &v, nil
} }
} }

View File

@ -1,6 +1,7 @@
package im_mysql_model package im_mysql_model
import ( import (
"Open_IM/pkg/common/constant"
"Open_IM/pkg/common/db" "Open_IM/pkg/common/db"
"time" "time"
) )
@ -88,7 +89,7 @@ func GetGroupApplicationList(userID string) ([]GroupRequest, error) {
return nil, err return nil, err
} }
for _, v := range memberList { for _, v := range memberList {
if v.RoleLevel > 0 { if v.RoleLevel > constant.GroupOrdinaryUsers {
list, err := GetGroupRequestByGroupID(v.GroupID) list, err := GetGroupRequestByGroupID(v.GroupID)
if err != nil { if err != nil {
continue continue

View File

@ -2,6 +2,7 @@ package im_mysql_model
import ( import (
"Open_IM/pkg/common/config" "Open_IM/pkg/common/config"
"Open_IM/pkg/common/constant"
"Open_IM/pkg/common/db" "Open_IM/pkg/common/db"
"Open_IM/pkg/utils" "Open_IM/pkg/utils"
"fmt" "fmt"
@ -21,7 +22,7 @@ func init() {
var appMgr User var appMgr User
appMgr.UserID = v appMgr.UserID = v
appMgr.Nickname = "AppManager" + utils.IntToString(k+1) appMgr.Nickname = "AppManager" + utils.IntToString(k+1)
appMgr.AppMangerLevel = 2 appMgr.AppMangerLevel = constant.AppAdmin
err = UserRegister(appMgr) err = UserRegister(appMgr)
if err != nil { if err != nil {
fmt.Println("AppManager insert error", err.Error()) fmt.Println("AppManager insert error", err.Error())
@ -36,7 +37,9 @@ func UserRegister(user User) error {
return err return err
} }
user.CreateTime = time.Now() user.CreateTime = time.Now()
if user.AppMangerLevel == 0 {
user.AppMangerLevel = constant.AppOrdinaryUsers
}
err = dbConn.Table("user").Create(&user).Error err = dbConn.Table("user").Create(&user).Error
if err != nil { if err != nil {
return err return err