From 2f7561bf49d622af7e47dd4d01fdad204fb2efcd Mon Sep 17 00:00:00 2001 From: dsx137 <70027572+dsx137@users.noreply.github.com> Date: Wed, 22 Jul 2026 15:46:44 +0800 Subject: [PATCH] refactor(core): select discovery backend from configured type (#3773) * refactor(core): select discovery backend from configured type * refactor(core): select discovery backend from configured type * refactor(core): select discovery backend from configured type * refactor(core): select discovery backend from configured type --- .gitignore | 5 +++- pkg/common/discovery/discoveryregister.go | 28 ++++++++++++++++------- 2 files changed, 24 insertions(+), 9 deletions(-) diff --git a/.gitignore b/.gitignore index 77cf855b7..1b5cf874d 100644 --- a/.gitignore +++ b/.gitignore @@ -387,4 +387,7 @@ Sessionx.vim # End of https://www.toptal.com/developers/gitignore/api/go,git,vim,tags,test,emacs,backup,jetbrains .idea -dist/ \ No newline at end of file +dist/ + +.omo +.sisyphus \ No newline at end of file diff --git a/pkg/common/discovery/discoveryregister.go b/pkg/common/discovery/discoveryregister.go index 29ed5929f..3e053775b 100644 --- a/pkg/common/discovery/discoveryregister.go +++ b/pkg/common/discovery/discoveryregister.go @@ -15,13 +15,14 @@ package discovery import ( + "strings" "time" "google.golang.org/grpc" "github.com/openimsdk/open-im-server/v3/pkg/common/config" "github.com/openimsdk/tools/discovery" - "github.com/openimsdk/tools/discovery/inprocess" + "github.com/openimsdk/tools/discovery/standalone" "github.com/openimsdk/tools/utils/runtimeenv" "github.com/openimsdk/tools/discovery/kubernetes" @@ -33,17 +34,28 @@ import ( // NewDiscoveryRegister creates a new service discovery and registry client based on the provided environment type. func NewDiscoveryRegister(discovery *config.Discovery, watchNames []string) (discovery.SvcDiscoveryRegistry, error) { if config.Standalone() { - return inprocess.GetSvcDiscoveryRegistry(), nil + return standalone.GetSvcDiscoveryRegistry(), nil } - if runtimeenv.RuntimeEnvironment() == config.KUBERNETES { - return kubernetes.NewConnManager(discovery.Kubernetes.Namespace, nil, + + runtimeEnvironment := runtimeenv.RuntimeEnvironment() + discoveryType := discovery.Enable + if discoveryType == "" && runtimeEnvironment == config.KUBERNETES { + discoveryType = config.KUBERNETES + } + if discoveryType == config.KUBERNETES && runtimeEnvironment != config.KUBERNETES { + return nil, errs.New("unsupported discovery type", "type", discoveryType).Wrap() + } + switch discoveryType { + case config.KUBERNETES: + for i := range watchNames { + watchNames[i] = strings.Split(watchNames[i], ":")[0] + } + return kubernetes.NewConnManager(discovery.Kubernetes.Namespace, watchNames, grpc.WithDefaultCallOptions( grpc.MaxCallSendMsgSize(1024*1024*20), ), + grpc.WithDefaultServiceConfig(`{"loadBalancingPolicy":"round_robin"}`), ) - } - - switch discovery.Enable { case config.ETCD: return etcd.NewSvcDiscoveryRegistry( discovery.Etcd.RootDirectory, @@ -53,6 +65,6 @@ func NewDiscoveryRegister(discovery *config.Discovery, watchNames []string) (dis etcd.WithMaxCallSendMsgSize(20*1024*1024), etcd.WithUsernameAndPassword(discovery.Etcd.Username, discovery.Etcd.Password)) default: - return nil, errs.New("unsupported discovery type", "type", discovery.Enable).Wrap() + return nil, errs.New("unsupported discovery type", "type", discoveryType).Wrap() } }