From 0f7b183e7c499c2baa337b045907d7c26455043e Mon Sep 17 00:00:00 2001 From: skiffer-git <44203734@qq.com> Date: Thu, 5 Jan 2023 15:52:48 +0800 Subject: [PATCH] Error code standardization --- internal/rpc/group/group.go | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/internal/rpc/group/group.go b/internal/rpc/group/group.go index 35eb1460d..4f41591ff 100644 --- a/internal/rpc/group/group.go +++ b/internal/rpc/group/group.go @@ -880,14 +880,20 @@ func (s *groupServer) GetGroupsInfo(ctx context.Context, req *pbGroup.GetGroupsI return &resp, nil } -func CheckPermission(ctx context.Context, groupID string, userID string) error { +func CheckPermission(ctx context.Context, groupID string, userID string) (err error) { + defer func() { + trace_log.SetContextInfo(ctx, utils.GetSelfFuncName(), err, "groupID", groupID, "userID", userID) + }() + if !token_verify.IsManagerUserID(userID) && !imdb.IsGroupOwnerAdmin(groupID, userID) { + return constant.ErrNoPermission + } return nil } func (s *groupServer) GroupApplicationResponse(ctx context.Context, req *pbGroup.GroupApplicationResponseReq) (*pbGroup.GroupApplicationResponseResp, error) { trace_log.SetRpcReqInfo(trace_log.NewRpcCtx(ctx, utils.GetSelfFuncName(), req.OperationID), utils.GetSelfFuncName(), req.String()) defer trace_log.ShowLog(ctx) - resp := pbGroup.GroupApplicationResponseResp{CommonResp: &pbGroup.CommonResp{}} + resp := pbGroup.GroupApplicationResponseResp{CommonResp: &open_im_sdk.CommonResp{}} if err := CheckPermission(ctx, req.GroupID, req.OpUserID); err != nil { SetErrorForResp(err, &resp.CommonResp.ErrCode, &resp.CommonResp.ErrMsg) return &resp, nil