mirror of
https://github.com/gin-gonic/gin.git
synced 2025-04-06 03:57:46 +08:00
4ea7d51dea
When the response has been written, the status code saved in `responseWriter` should no longer be changed by subsequent calls to `WriteHeader()`. This fixes for example the logging possibly showing the wrong status code, or any other middleware function checking the status code.
137 lines
3.6 KiB
Go
137 lines
3.6 KiB
Go
// Copyright 2014 Manu Martinez-Almeida. All rights reserved.
|
|
// Use of this source code is governed by a MIT style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package gin
|
|
|
|
import (
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
// TODO
|
|
// func (w *responseWriter) Hijack() (net.Conn, *bufio.ReadWriter, error) {
|
|
// func (w *responseWriter) CloseNotify() <-chan bool {
|
|
// func (w *responseWriter) Flush() {
|
|
|
|
var _ ResponseWriter = &responseWriter{}
|
|
var _ http.ResponseWriter = &responseWriter{}
|
|
var _ http.ResponseWriter = ResponseWriter(&responseWriter{})
|
|
var _ http.Hijacker = ResponseWriter(&responseWriter{})
|
|
var _ http.Flusher = ResponseWriter(&responseWriter{})
|
|
var _ http.CloseNotifier = ResponseWriter(&responseWriter{})
|
|
|
|
func init() {
|
|
SetMode(TestMode)
|
|
}
|
|
|
|
func TestResponseWriterReset(t *testing.T) {
|
|
testWriter := httptest.NewRecorder()
|
|
writer := &responseWriter{}
|
|
var w ResponseWriter = writer
|
|
|
|
writer.reset(testWriter)
|
|
assert.Equal(t, -1, writer.size)
|
|
assert.Equal(t, http.StatusOK, writer.status)
|
|
assert.Equal(t, testWriter, writer.ResponseWriter)
|
|
assert.Equal(t, -1, w.Size())
|
|
assert.Equal(t, http.StatusOK, w.Status())
|
|
assert.False(t, w.Written())
|
|
}
|
|
|
|
func TestResponseWriterWriteHeader(t *testing.T) {
|
|
testWriter := httptest.NewRecorder()
|
|
writer := &responseWriter{}
|
|
writer.reset(testWriter)
|
|
w := ResponseWriter(writer)
|
|
|
|
w.WriteHeader(http.StatusMultipleChoices)
|
|
assert.False(t, w.Written())
|
|
assert.Equal(t, http.StatusMultipleChoices, w.Status())
|
|
assert.NotEqual(t, http.StatusMultipleChoices, testWriter.Code)
|
|
|
|
w.WriteHeader(-1)
|
|
assert.Equal(t, http.StatusMultipleChoices, w.Status())
|
|
}
|
|
|
|
func TestResponseWriterWriteHeadersNow(t *testing.T) {
|
|
testWriter := httptest.NewRecorder()
|
|
writer := &responseWriter{}
|
|
writer.reset(testWriter)
|
|
w := ResponseWriter(writer)
|
|
|
|
w.WriteHeader(http.StatusMultipleChoices)
|
|
w.WriteHeaderNow()
|
|
|
|
assert.True(t, w.Written())
|
|
assert.Equal(t, 0, w.Size())
|
|
assert.Equal(t, http.StatusMultipleChoices, testWriter.Code)
|
|
|
|
writer.size = 10
|
|
w.WriteHeaderNow()
|
|
assert.Equal(t, 10, w.Size())
|
|
|
|
w.WriteHeader(http.StatusOK)
|
|
assert.Equal(t, http.StatusMultipleChoices, w.Status())
|
|
assert.Equal(t, http.StatusMultipleChoices, testWriter.Code)
|
|
}
|
|
|
|
func TestResponseWriterWrite(t *testing.T) {
|
|
testWriter := httptest.NewRecorder()
|
|
writer := &responseWriter{}
|
|
writer.reset(testWriter)
|
|
w := ResponseWriter(writer)
|
|
|
|
n, err := w.Write([]byte("hola"))
|
|
assert.Equal(t, 4, n)
|
|
assert.Equal(t, 4, w.Size())
|
|
assert.Equal(t, http.StatusOK, w.Status())
|
|
assert.Equal(t, http.StatusOK, testWriter.Code)
|
|
assert.Equal(t, "hola", testWriter.Body.String())
|
|
assert.NoError(t, err)
|
|
|
|
n, err = w.Write([]byte(" adios"))
|
|
assert.Equal(t, 6, n)
|
|
assert.Equal(t, 10, w.Size())
|
|
assert.Equal(t, "hola adios", testWriter.Body.String())
|
|
assert.NoError(t, err)
|
|
}
|
|
|
|
func TestResponseWriterHijack(t *testing.T) {
|
|
testWriter := httptest.NewRecorder()
|
|
writer := &responseWriter{}
|
|
writer.reset(testWriter)
|
|
w := ResponseWriter(writer)
|
|
|
|
assert.Panics(t, func() {
|
|
_, _, err := w.Hijack()
|
|
assert.NoError(t, err)
|
|
})
|
|
assert.True(t, w.Written())
|
|
|
|
assert.Panics(t, func() {
|
|
w.CloseNotify()
|
|
})
|
|
|
|
w.Flush()
|
|
}
|
|
|
|
func TestResponseWriterFlush(t *testing.T) {
|
|
testServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
writer := &responseWriter{}
|
|
writer.reset(w)
|
|
|
|
writer.WriteHeader(http.StatusInternalServerError)
|
|
writer.Flush()
|
|
}))
|
|
defer testServer.Close()
|
|
|
|
// should return 500
|
|
resp, err := http.Get(testServer.URL)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, http.StatusInternalServerError, resp.StatusCode)
|
|
}
|