Compare commits

...

4 Commits

Author SHA1 Message Date
SAURABH CHAUHAN
8539f0b206
Merge cd9b91bb2ef67d3b409e8c2465c806a2d68f5178 into 5f4f9643258dc2a65e684b63f12c8d543c936c67 2026-05-15 04:08:53 +08:00
dependabot[bot]
5f4f964325
chore(deps): bump the actions group across 1 directory with 2 updates (#4640)
Bumps the actions group with 2 updates in the / directory: [codecov/codecov-action](https://github.com/codecov/codecov-action) and [aquasecurity/trivy-action](https://github.com/aquasecurity/trivy-action).


Updates `codecov/codecov-action` from 5 to 6
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/codecov/codecov-action/compare/v5...v6)

Updates `aquasecurity/trivy-action` from 0.35.0 to 0.36.0
- [Release notes](https://github.com/aquasecurity/trivy-action/releases)
- [Commits](https://github.com/aquasecurity/trivy-action/compare/0.35.0...v0.36.0)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-version: '6'
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: actions
- dependency-name: aquasecurity/trivy-action
  dependency-version: 0.36.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: actions
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-05-09 10:20:32 +08:00
sh9336
cd9b91bb2e Fix lint issues: error wrapping, require assertions, formatting 2026-01-10 10:26:46 +05:30
sh9336
4a81d5807a Wrap EOF with helpful message for empty JSON request body 2026-01-09 17:27:06 +05:30
4 changed files with 48 additions and 3 deletions

View File

@ -78,6 +78,6 @@ jobs:
run: make test
- name: Upload coverage to Codecov
uses: codecov/codecov-action@v5
uses: codecov/codecov-action@v6
with:
flags: ${{ matrix.os }},go-${{ matrix.go }},${{ matrix.test-tags }}

View File

@ -27,7 +27,7 @@ jobs:
fetch-depth: 0
- name: Run Trivy vulnerability scanner (source code)
uses: aquasecurity/trivy-action@0.35.0
uses: aquasecurity/trivy-action@v0.36.0
with:
scan-type: "fs"
scan-ref: "."
@ -44,7 +44,7 @@ jobs:
sarif_file: "trivy-results.sarif"
- name: Run Trivy scanner (table output for logs)
uses: aquasecurity/trivy-action@0.35.0
uses: aquasecurity/trivy-action@v0.36.0
if: always()
with:
scan-type: "fs"

View File

@ -7,6 +7,7 @@ package binding
import (
"bytes"
"errors"
"fmt"
"io"
"net/http"
@ -50,7 +51,12 @@ func decodeJSON(r io.Reader, obj any) error {
decoder.DisallowUnknownFields()
}
if err := decoder.Decode(obj); err != nil {
if errors.Is(err, io.EOF) {
return fmt.Errorf("empty request body: %w", err)
}
return err
}
return validate(obj)
}

View File

@ -0,0 +1,39 @@
package binding_test
import (
"bytes"
"io"
"net/http"
"net/http/httptest"
"testing"
"github.com/gin-gonic/gin"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
func TestJSONBindingEmptyBodyReturnsHelpfulError(t *testing.T) {
type Req struct {
Name string `json:"name" binding:"required"`
}
w := httptest.NewRecorder()
c, _ := gin.CreateTestContext(w)
req, err := http.NewRequest(http.MethodPost, "/", bytes.NewBuffer(nil))
require.NoError(t, err)
req.Header.Set("Content-Type", "application/json")
c.Request = req
var r Req
err = c.ShouldBindJSON(&r)
require.Error(t, err)
// Error message should be more descriptive than plain EOF,
// while still preserving io.EOF via wrapping.
assert.NotEqual(t, "EOF", err.Error())
assert.Contains(t, err.Error(), "empty request body")
assert.ErrorIs(t, err, io.EOF)
}