Merge 929794596f18ada3ca5edfeae193c3b1a1c33823 into e88fc8927a52b74f55bec0351604a56ac0aa1c51

ci(sec): schedule Trivy security scans to run daily at midnight UTC (#4439 )
- Change Trivy scan schedule from quarterly to daily runs at 00:00 UTC Signed-off-by: appleboy <appleboy.tw@gmail.com>
2026-07-05 01:31:21 +08:00 · 2025-11-18 23:29:53 +08:00 · 2025-11-18 23:05:54 +08:00 · 2023-08-02 00:13:28 +02:00
3 changed files with 10 additions and 4 deletions
--- a/.github/workflows/trivy-scan.yml
+++ b/.github/workflows/trivy-scan.yml
@ -8,9 +8,8 @@ on:
    branches:
      - master
  schedule:
-    # Run every 3 months (quarterly) on the 1st day at 00:00 UTC
-    # Months: January (1), April (4), July (7), October (10)
-    - cron: '0 0 1 1,4,7,10 *'
+    # Run daily at 00:00 UTC
+    - cron: '0 0 * * *'
  workflow_dispatch: # Allow manual trigger

 permissions:
--- a/context.go
+++ b/context.go
@ -1094,7 +1094,7 @@ func (c *Context) SetCookie(name, value string, maxAge int, path, domain string,
 	}
 	http.SetCookie(c.Writer, &http.Cookie{
 		Name:     name,
-		Value:    url.QueryEscape(value),
+		Value:    value,
 		MaxAge:   maxAge,
 		Path:     path,
 		Domain:   domain,
--- a/context_test.go
+++ b/context_test.go
@ -1002,6 +1002,13 @@ func TestContextSetCookiePathEmpty(t *testing.T) {
 	assert.Equal(t, "user=gin; Path=/; Domain=localhost; Max-Age=1; HttpOnly; Secure; SameSite=Lax", c.Writer.Header().Get("Set-Cookie"))
 }

+func TestContextSetCookieWithSpace(t *testing.T) {
+	c, _ := CreateTestContext(httptest.NewRecorder())
+	c.SetSameSite(http.SameSiteLaxMode)
+	c.SetCookie("user", "gin test", 1, "/", "localhost", true, true)
+	assert.Equal(t, "user=\"gin test\"; Path=/; Domain=localhost; Max-Age=1; HttpOnly; Secure; SameSite=Lax", c.Writer.Header().Get("Set-Cookie"))
+}
+
 func TestContextGetCookie(t *testing.T) {
 	c, _ := CreateTestContext(httptest.NewRecorder())
 	c.Request, _ = http.NewRequest(http.MethodGet, "/get", nil)
Author	SHA1	Message	Date
Ludovico Cavedon	069a7de2e4	Merge 929794596f18ada3ca5edfeae193c3b1a1c33823 into e88fc8927a52b74f55bec0351604a56ac0aa1c51	2025-11-18 23:29:53 +08:00
Bo-Yi Wu	e88fc8927a	ci(sec): schedule Trivy security scans to run daily at midnight UTC (#4439 ) - Change Trivy scan schedule from quarterly to daily runs at 00:00 UTC Signed-off-by: appleboy <appleboy.tw@gmail.com>	2025-11-18 23:05:54 +08:00
Ludovico Cavedon	929794596f	Do not QueryEscape cookies (#1717 ) Cookies values are already sanitized by the Go http library, so there is no need to invoke QueryEscape() on them. Furthermore, QueryEscape() has the undesirable effect of replacing spaces wiith "+" characters.	2023-08-02 00:13:28 +02:00