add open redirect test case

https://github.com/gin-gonic/gin/pull/3907
fixed open redirect
2026-07-16 00:01:25 +08:00 · 2024-04-01 14:52:28 +08:00 · 2024-04-01 14:50:18 +08:00
2 changed files with 7 additions and 2 deletions
--- a/gin.go
+++ b/gin.go
@ -699,7 +699,7 @@ func redirectTrailingSlash(c *Context) {
 		p = prefix + "/" + req.URL.Path
 	}
 	req.URL.Path = p + "/"
-	p = regRemoveRepeatedChar.ReplaceAllString(p, "/")
+	p = regexp.MustCompile("^/{2,}").ReplaceAllString(p, "/")
 	if length := len(p); length > 1 && p[length-1] == '/' {
 		req.URL.Path = p[:length-1]
 	}
--- a/routes_test.go
+++ b/routes_test.go
@ -149,8 +149,13 @@ func TestRouteRedirectTrailingSlash(t *testing.T) {
 	router.GET("/path2/", func(c *Context) {})
 	router.POST("/path3", func(c *Context) {})
 	router.PUT("/path4/", func(c *Context) {})
+	router.GET("/:param1/:param2", func(c *Context) {})

-	w := PerformRequest(router, http.MethodGet, "/path/")
+	w := PerformRequest(router, http.MethodGet, "//path/")
+	assert.Equal(t, "/path", w.Header().Get("Location"))
+	assert.Equal(t, http.StatusMovedPermanently, w.Code)
+
+	w = PerformRequest(router, http.MethodGet, "/path/")
 	assert.Equal(t, "/path", w.Header().Get("Location"))
 	assert.Equal(t, http.StatusMovedPermanently, w.Code)
Author	SHA1	Message	Date
cyal1	b7dd5120ef	add open redirect test case https://github.com/gin-gonic/gin/pull/3907	2024-04-01 14:52:28 +08:00
cyal1	29db90e1fc	fixed open redirect	2024-04-01 14:50:18 +08:00