test: add PDF rendering tests including 204 No Content in context_test.go

.github/workflows/gin.yml

@@ -26,14 +26,14 @@ jobs:
       - name: Setup golangci-lint
         uses: golangci/golangci-lint-action@v9
         with:
-          version: v2.9
+          version: v2.6
           args: --verbose
   test:
     needs: lint
     strategy:
       matrix:
         os: [ubuntu-latest, macos-latest]
-        go: ["1.24", "1.25", "1.26"]
+        go: ["1.24", "1.25"]
         test-tags:
           [
             "",

.github/workflows/goreleaser.yml

@@ -21,7 +21,7 @@ jobs:
         with:
           go-version: "^1"
       - name: Run GoReleaser
-        uses: goreleaser/goreleaser-action@v7
+        uses: goreleaser/goreleaser-action@v6
         with:
           # either 'goreleaser' (default) or 'goreleaser-pro'
           distribution: goreleaser

.github/workflows/trivy-scan.yml

@@ -9,7 +9,7 @@ on:
       - master
   schedule:
     # Run daily at 00:00 UTC
-    - cron: "0 0 * * *"
+    - cron: '0 0 * * *'
   workflow_dispatch: # Allow manual trigger
 
 permissions:
@@ -27,30 +27,30 @@ jobs:
           fetch-depth: 0
 
       - name: Run Trivy vulnerability scanner (source code)
-        uses: aquasecurity/trivy-action@0.34.1
+        uses: aquasecurity/trivy-action@0.33.1
         with:
-          scan-type: "fs"
-          scan-ref: "."
-          scanners: "vuln,secret,misconfig"
-          format: "sarif"
-          output: "trivy-results.sarif"
-          severity: "CRITICAL,HIGH,MEDIUM"
+          scan-type: 'fs'
+          scan-ref: '.'
+          scanners: 'vuln,secret,misconfig'
+          format: 'sarif'
+          output: 'trivy-results.sarif'
+          severity: 'CRITICAL,HIGH,MEDIUM'
           ignore-unfixed: true
 
       - name: Upload Trivy results to GitHub Security tab
         uses: github/codeql-action/upload-sarif@v4
         if: always()
         with:
-          sarif_file: "trivy-results.sarif"
+          sarif_file: 'trivy-results.sarif'
 
       - name: Run Trivy scanner (table output for logs)
-        uses: aquasecurity/trivy-action@0.34.1
+        uses: aquasecurity/trivy-action@0.33.1
         if: always()
         with:
-          scan-type: "fs"
-          scan-ref: "."
-          scanners: "vuln,secret,misconfig"
-          format: "table"
-          severity: "CRITICAL,HIGH,MEDIUM"
+          scan-type: 'fs'
+          scan-ref: '.'
+          scanners: 'vuln,secret,misconfig'
+          format: 'table'
+          severity: 'CRITICAL,HIGH,MEDIUM'
           ignore-unfixed: true
-          exit-code: "1"
+          exit-code: '1'

CONTRIBUTING.md

@@ -36,6 +36,6 @@ Please ensure your pull request meets the following requirements:
 - All tests pass in available continuous integration systems (e.g., GitHub Actions).
 - Add or modify tests to cover your code changes.
 - If your pull request introduces a new feature, document it in [`docs/doc.md`](docs/doc.md), not in the README.
-- Follow the checklist in the [Pull Request Template](.github/PULL_REQUEST_TEMPLATE.md).
+- Follow the checklist in the [Pull Request Template](.github/PULL_REQUEST_TEMPLATE.md:1).
 
 Thank you for contributing!

benchmarks_test.go

@@ -154,7 +154,7 @@ func runRequest(B *testing.B, r *Engine, method, path string) {
 	w := newMockWriter()
 	B.ReportAllocs()
 	B.ResetTimer()
-	for B.Loop() {
+	for i := 0; i < B.N; i++ {
 		r.ServeHTTP(w, req)
 	}
 }

binding/binding.go

@@ -23,7 +23,6 @@ const (
 	MIMEYAML              = "application/x-yaml"
 	MIMEYAML2             = "application/yaml"
 	MIMETOML              = "application/toml"
-	MIMEBSON              = "application/bson"
 )
 
 // Binding describes the interface which needs to be implemented for binding the
@@ -87,7 +86,6 @@ var (
 	Header        Binding     = headerBinding{}
 	Plain         BindingBody = plainBinding{}
 	TOML          BindingBody = tomlBinding{}
-	BSON          BindingBody = bsonBinding{}
 )
 
 // Default returns the appropriate Binding instance based on the HTTP method
@@ -112,8 +110,6 @@ func Default(method, contentType string) Binding {
 		return TOML
 	case MIMEMultipartPOSTForm:
 		return FormMultipart
-	case MIMEBSON:
-		return BSON
 	default: // case MIMEPOSTForm:
 		return Form
 	}

binding/binding_nomsgpack.go

@@ -21,7 +21,6 @@ const (
 	MIMEYAML              = "application/x-yaml"
 	MIMEYAML2             = "application/yaml"
 	MIMETOML              = "application/toml"
-	MIMEBSON              = "application/bson"
 )
 
 // Binding describes the interface which needs to be implemented for binding the
@@ -83,7 +82,6 @@ var (
 	Header        = headerBinding{}
 	TOML          = tomlBinding{}
 	Plain         = plainBinding{}
-	BSON          BindingBody = bsonBinding{}
 )
 
 // Default returns the appropriate Binding instance based on the HTTP method
@@ -106,8 +104,6 @@ func Default(method, contentType string) Binding {
 		return FormMultipart
 	case MIMETOML:
 		return TOML
-	case MIMEBSON:
-		return BSON
 	default: // case MIMEPOSTForm:
 		return Form
 	}

binding/binding_test.go

@@ -21,7 +21,6 @@ import (
 	"github.com/gin-gonic/gin/testdata/protoexample"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
-	"go.mongodb.org/mongo-driver/v2/bson"
 	"google.golang.org/protobuf/proto"
 )
 
@@ -173,9 +172,6 @@ func TestBindingDefault(t *testing.T) {
 
 	assert.Equal(t, TOML, Default(http.MethodPost, MIMETOML))
 	assert.Equal(t, TOML, Default(http.MethodPut, MIMETOML))
-
-	assert.Equal(t, BSON, Default(http.MethodPost, MIMEBSON))
-	assert.Equal(t, BSON, Default(http.MethodPut, MIMEBSON))
 }
 
 func TestBindingJSONNilBody(t *testing.T) {
@@ -735,18 +731,6 @@ func TestBindingProtoBufFail(t *testing.T) {
 		string(data), string(data[1:]))
 }
 
-func TestBindingBSON(t *testing.T) {
-	var obj FooStruct
-	obj.Foo = "bar"
-	data, _ := bson.Marshal(&obj)
-	testBodyBinding(t,
-		BSON, "bson",
-		"/", "/",
-		string(data),
-		// note: for badbody, we remove first byte to make it invalid
-		string(data[1:]))
-}
-
 func TestValidationFails(t *testing.T) {
 	var obj FooStruct
 	req := requestWithBody(http.MethodPost, "/", `{"bar": "foo"}`)

binding/bson.go

@@ -1,30 +0,0 @@
-// Copyright 2025 Gin Core Team. All rights reserved.
-// Use of this source code is governed by a MIT style
-// license that can be found in the LICENSE file.
-
-package binding
-
-import (
-	"io"
-	"net/http"
-
-	"go.mongodb.org/mongo-driver/v2/bson"
-)
-
-type bsonBinding struct{}
-
-func (bsonBinding) Name() string {
-	return "bson"
-}
-
-func (b bsonBinding) Bind(req *http.Request, obj any) error {
-	buf, err := io.ReadAll(req.Body)
-	if err == nil {
-		err = b.BindBody(buf, obj)
-	}
-	return err
-}
-
-func (bsonBinding) BindBody(body []byte, obj any) error {
-	return bson.Unmarshal(body, obj)
-}

binding/default_validator.go

@@ -27,7 +27,7 @@ func (err SliceValidationError) Error() string {
 	}
 
 	var b strings.Builder
-	for i := range len(err) {
+	for i := 0; i < len(err); i++ {
 		if err[i] != nil {
 			if b.Len() > 0 {
 				b.WriteString("\n")
@@ -58,7 +58,7 @@ func (v *defaultValidator) ValidateStruct(obj any) error {
 	case reflect.Slice, reflect.Array:
 		count := value.Len()
 		validateRet := make(SliceValidationError, 0)
-		for i := range count {
+		for i := 0; i < count; i++ {
 			if err := v.ValidateStruct(value.Index(i).Interface()); err != nil {
 				validateRet = append(validateRet, err)
 			}

binding/form_mapping.go

@@ -119,7 +119,7 @@ func mapping(value reflect.Value, field reflect.StructField, setter setter, tag
 		tValue := value.Type()
 
 		var isSet bool
-		for i := range value.NumField() {
+		for i := 0; i < value.NumField(); i++ {
 			sf := tValue.Field(i)
 			if sf.PkgPath != "" && !sf.Anonymous { // unexported
 				continue

context.go

@@ -40,7 +40,6 @@ const (
 	MIMEYAML2             = binding.MIMEYAML2
 	MIMETOML              = binding.MIMETOML
 	MIMEPROTOBUF          = binding.MIMEPROTOBUF
-	MIMEBSON              = binding.MIMEBSON
 )
 
 // BodyBytesKey indicates a default body bytes key.
@@ -387,11 +386,6 @@ func (c *Context) GetDuration(key any) time.Duration {
 	return getTyped[time.Duration](c, key)
 }
 
-// GetError returns the value associated with the key as an error.
-func (c *Context) GetError(key any) error {
-	return getTyped[error](c, key)
-}
-
 // GetIntSlice returns the value associated with the key as a slice of integers.
 func (c *Context) GetIntSlice(key any) []int {
 	return getTyped[[]int](c, key)
@@ -457,11 +451,6 @@ func (c *Context) GetStringSlice(key any) []string {
 	return getTyped[[]string](c, key)
 }
 
-// GetErrorSlice returns the value associated with the key as a slice of errors.
-func (c *Context) GetErrorSlice(key any) []error {
-	return getTyped[[]error](c, key)
-}
-
 // GetStringMap returns the value associated with the key as a map of interfaces.
 func (c *Context) GetStringMap(key any) map[string]any {
 	return getTyped[map[string]any](c, key)
@@ -751,8 +740,8 @@ func (c *Context) SaveUploadedFile(file *multipart.FileHeader, dst string, perm
 //	"application/json" --> JSON binding
 //	"application/xml"  --> XML binding
 //
-// It parses the request's body based on the Content-Type (e.g., JSON or XML).
-// It decodes the payload into the struct specified as a pointer.
+// It parses the request's body as JSON if Content-Type == "application/json" using JSON or XML as a JSON input.
+// It decodes the json payload into the struct specified as a pointer.
 // It writes a 400 error and sets Content-Type header "text/plain" in the response if input is not valid.
 func (c *Context) Bind(obj any) error {
 	b := binding.Default(c.Request.Method, c.ContentType())
@@ -832,8 +821,8 @@ func (c *Context) MustBindWith(obj any, b binding.Binding) error {
 //	"application/json" --> JSON binding
 //	"application/xml"  --> XML binding
 //
-// It parses the request's body based on the Content-Type (e.g., JSON or XML).
-// It decodes the payload into the struct specified as a pointer.
+// It parses the request's body as JSON if Content-Type == "application/json" using JSON or XML as a JSON input.
+// It decodes the json payload into the struct specified as a pointer.
 // Like c.Bind() but this method does not set the response status code to 400 or abort if input is not valid.
 func (c *Context) ShouldBind(obj any) error {
 	b := binding.Default(c.Request.Method, c.ContentType())
@@ -1056,10 +1045,9 @@ func (c *Context) requestHeader(key string) string {
 /************************************/
 
 // bodyAllowedForStatus is a copy of http.bodyAllowedForStatus non-exported function.
-// Uses http.StatusContinue constant for better code clarity.
 func bodyAllowedForStatus(status int) bool {
 	switch {
-	case status >= http.StatusContinue && status < http.StatusOK:
+	case status >= 100 && status <= 199:
 		return false
 	case status == http.StatusNoContent:
 		return false
@@ -1245,11 +1233,6 @@ func (c *Context) ProtoBuf(code int, obj any) {
 	c.Render(code, render.ProtoBuf{Data: obj})
 }
 
-// BSON serializes the given struct as BSON into the response body.
-func (c *Context) BSON(code int, obj any) {
-	c.Render(code, render.BSON{Data: obj})
-}
-
 // String writes the given string into the response body.
 func (c *Context) String(code int, format string, values ...any) {
 	c.Render(code, render.String{Format: format, Data: values})
@@ -1357,7 +1340,6 @@ type Negotiate struct {
 	Data         any
 	TOMLData     any
 	PROTOBUFData any
-	BSONData     any
 }
 
 // Negotiate calls different Render according to acceptable Accept format.
@@ -1387,10 +1369,6 @@ func (c *Context) Negotiate(code int, config Negotiate) {
 		data := chooseData(config.PROTOBUFData, config.Data)
 		c.ProtoBuf(code, data)
 
-	case binding.MIMEBSON:
-		data := chooseData(config.BSONData, config.Data)
-		c.BSON(code, data)
-
 	default:
 		c.AbortWithError(http.StatusNotAcceptable, errors.New("the accepted formats are not offered by the server")) //nolint: errcheck
 	}

context_test.go

@@ -32,7 +32,6 @@ import (
 	testdata "github.com/gin-gonic/gin/testdata/protoexample"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
-	"go.mongodb.org/mongo-driver/v2/bson"
 	"google.golang.org/protobuf/proto"
 )
 
@@ -517,14 +516,6 @@ func TestContextGetDuration(t *testing.T) {
 	assert.Equal(t, time.Second, c.GetDuration("duration"))
 }
 
-func TestContextGetError(t *testing.T) {
-	c, _ := CreateTestContext(httptest.NewRecorder())
-	key := "error"
-	value := errors.New("test error")
-	c.Set(key, value)
-	assert.Equal(t, value, c.GetError(key))
-}
-
 func TestContextGetIntSlice(t *testing.T) {
 	c, _ := CreateTestContext(httptest.NewRecorder())
 	key := "int-slice"
@@ -627,14 +618,6 @@ func TestContextGetStringSlice(t *testing.T) {
 	assert.Equal(t, []string{"foo"}, c.GetStringSlice("slice"))
 }
 
-func TestContextGetErrorSlice(t *testing.T) {
-	c, _ := CreateTestContext(httptest.NewRecorder())
-	key := "error-slice"
-	value := []error{errors.New("error1"), errors.New("error2")}
-	c.Set(key, value)
-	assert.Equal(t, value, c.GetErrorSlice(key))
-}
-
 func TestContextGetStringMap(t *testing.T) {
 	c, _ := CreateTestContext(httptest.NewRecorder())
 	m := make(map[string]any)
@@ -1031,7 +1014,6 @@ func TestContextGetCookie(t *testing.T) {
 }
 
 func TestContextBodyAllowedForStatus(t *testing.T) {
-	assert.False(t, bodyAllowedForStatus(http.StatusContinue))
 	assert.False(t, bodyAllowedForStatus(http.StatusProcessing))
 	assert.False(t, bodyAllowedForStatus(http.StatusNoContent))
 	assert.False(t, bodyAllowedForStatus(http.StatusNotModified))
@@ -1730,23 +1712,6 @@ func TestContextNegotiationWithPROTOBUF(t *testing.T) {
 	assert.Equal(t, "application/x-protobuf", w.Header().Get("Content-Type"))
 }
 
-func TestContextNegotiationWithBSON(t *testing.T) {
-	w := httptest.NewRecorder()
-	c, _ := CreateTestContext(w)
-	c.Request, _ = http.NewRequest(http.MethodPost, "", nil)
-
-	c.Negotiate(http.StatusOK, Negotiate{
-		Offered: []string{MIMEBSON, MIMEXML, MIMEJSON, MIMEYAML, MIMEYAML2},
-		Data:    H{"foo": "bar"},
-	})
-
-	bData, _ := bson.Marshal(H{"foo": "bar"})
-
-	assert.Equal(t, http.StatusOK, w.Code)
-	assert.Equal(t, string(bData), w.Body.String())
-	assert.Equal(t, "application/bson", w.Header().Get("Content-Type"))
-}
-
 func TestContextNegotiationNotSupport(t *testing.T) {
 	w := httptest.NewRecorder()
 	c, _ := CreateTestContext(w)
@@ -2975,16 +2940,6 @@ func TestContextGetRawData(t *testing.T) {
 	assert.Equal(t, "Fetch binary post data", string(data))
 }
 
-func TestContextGetRawDataNilBody(t *testing.T) {
-	c, _ := CreateTestContext(httptest.NewRecorder())
-	c.Request, _ = http.NewRequest(http.MethodPost, "/", nil)
-
-	data, err := c.GetRawData()
-	assert.Nil(t, data)
-	require.Error(t, err)
-	assert.Equal(t, "cannot read nil body", err.Error())
-}
-
 func TestContextRenderDataFromReader(t *testing.T) {
 	w := httptest.NewRecorder()
 	c, _ := CreateTestContext(w)
@@ -3573,24 +3528,6 @@ func TestContextSetCookieData(t *testing.T) {
 		setCookie := c.Writer.Header().Get("Set-Cookie")
 		assert.Contains(t, setCookie, "SameSite=None")
 	})
-
-	// Test that SameSiteDefaultMode inherits from context's sameSite
-	t.Run("SameSiteDefaultMode inherits context sameSite", func(t *testing.T) {
-		c, _ := CreateTestContext(httptest.NewRecorder())
-		c.SetSameSite(http.SameSiteStrictMode)
-		cookie := &http.Cookie{
-			Name:     "user",
-			Value:    "gin",
-			Path:     "/",
-			Domain:   "localhost",
-			Secure:   true,
-			HttpOnly: true,
-			SameSite: http.SameSiteDefaultMode,
-		}
-		c.SetCookieData(cookie)
-		setCookie := c.Writer.Header().Get("Set-Cookie")
-		assert.Contains(t, setCookie, "SameSite=Strict")
-	})
 }
 
 func TestGetMapFromFormData(t *testing.T) {
@@ -3751,22 +3688,22 @@ func BenchmarkGetMapFromFormData(b *testing.B) {
 
 	// Test case 3: Large dataset with many bracket keys
 	largeData := make(map[string][]string)
-	for i := range 100 {
+	for i := 0; i < 100; i++ {
 		key := fmt.Sprintf("ids[%d]", i)
 		largeData[key] = []string{fmt.Sprintf("value%d", i)}
 	}
-	for i := range 50 {
+	for i := 0; i < 50; i++ {
 		key := fmt.Sprintf("names[%d]", i)
 		largeData[key] = []string{fmt.Sprintf("name%d", i)}
 	}
-	for i := range 25 {
+	for i := 0; i < 25; i++ {
 		key := fmt.Sprintf("other[key%d]", i)
 		largeData[key] = []string{fmt.Sprintf("other%d", i)}
 	}
 
 	// Test case 4: Dataset with many non-matching keys (worst case)
 	worstCaseData := make(map[string][]string)
-	for i := range 100 {
+	for i := 0; i < 100; i++ {
 		key := fmt.Sprintf("nonmatching%d", i)
 		worstCaseData[key] = []string{fmt.Sprintf("value%d", i)}
 	}
@@ -3802,7 +3739,7 @@ func BenchmarkGetMapFromFormData(b *testing.B) {
 	for _, bm := range benchmarks {
 		b.Run(bm.name, func(b *testing.B) {
 			b.ReportAllocs()
-			for b.Loop() {
+			for i := 0; i < b.N; i++ {
 				_, _ = getMapFromFormData(bm.data, bm.key)
 			}
 		})

docs/doc.md

@@ -22,7 +22,6 @@
   - [How to write log file](#how-to-write-log-file)
   - [Custom Log Format](#custom-log-format)
   - [Controlling Log output coloring](#controlling-log-output-coloring)
-  - [Avoid logging query strings](#avoid-loging-query-strings)
   - [Model binding and validation](#model-binding-and-validation)
   - [Custom Validators](#custom-validators)
   - [Only Bind Query String](#only-bind-query-string)
@@ -593,20 +592,6 @@ func main() {
 }
 ```
 
-### Avoid logging query strings
-
-```go
-func main() {
-  router := gin.New()
-  
-  // SkipQueryString indicates that the logger should not log the query string.
-  // For example, /path?q=1 will be logged as /path
-  loggerConfig := gin.LoggerConfig{SkipQueryString: true}
-  
-  router.Use(gin.LoggerWithConfig(loggerConfig))
-}
-```
-
 ### Model binding and validation
 
 To bind a request body into a type, use model binding. We currently support binding of JSON, XML, YAML, TOML and standard form values (foo=bar&boo=baz).

errors.go

@@ -26,6 +26,8 @@ const (
 	ErrorTypePublic ErrorType = 1 << 1
 	// ErrorTypeAny indicates any other error.
 	ErrorTypeAny ErrorType = 1<<64 - 1
+	// ErrorTypeNu indicates any other error.
+	ErrorTypeNu = 2
 )
 
 // Error represents a error's specification.

gin_integration_test.go

@@ -400,7 +400,7 @@ func TestConcurrentHandleContext(t *testing.T) {
 	var wg sync.WaitGroup
 	iterations := 200
 	wg.Add(iterations)
-	for range iterations {
+	for i := 0; i < iterations; i++ {
 		go func() {
 			req, err := http.NewRequest(http.MethodGet, "/", nil)
 			assert.NoError(t, err)

go.mod

@@ -2,46 +2,41 @@ module github.com/gin-gonic/gin
 
 go 1.24.0
 
-toolchain go1.24.7
-
 require (
-	github.com/bytedance/sonic v1.15.0
+	github.com/bytedance/sonic v1.14.2
 	github.com/gin-contrib/sse v1.1.0
-	github.com/go-playground/validator/v10 v10.30.1
-	github.com/goccy/go-json v0.10.5
-	github.com/goccy/go-yaml v1.19.2
+	github.com/go-playground/validator/v10 v10.28.0
+	github.com/goccy/go-json v0.10.2
+	github.com/goccy/go-yaml v1.19.0
 	github.com/json-iterator/go v1.1.12
 	github.com/mattn/go-isatty v0.0.20
 	github.com/modern-go/reflect2 v1.0.2
 	github.com/pelletier/go-toml/v2 v2.2.4
-	github.com/quic-go/quic-go v0.59.0
+	github.com/quic-go/quic-go v0.57.1
 	github.com/stretchr/testify v1.11.1
 	github.com/ugorji/go/codec v1.3.1
-	go.mongodb.org/mongo-driver/v2 v2.5.0
-	golang.org/x/net v0.50.0
+	golang.org/x/net v0.47.0
 	google.golang.org/protobuf v1.36.10
 )
 
-require gopkg.in/yaml.v3 v3.0.1 // indirect
-
 require (
 	github.com/bytedance/gopkg v0.1.3 // indirect
-	github.com/bytedance/sonic/loader v0.5.0 // indirect
+	github.com/bytedance/sonic/loader v0.4.0 // indirect
 	github.com/cloudwego/base64x v0.1.6 // indirect
 	github.com/davecgh/go-spew v1.1.1 // indirect
-	github.com/gabriel-vasile/mimetype v1.4.12 // indirect
+	github.com/gabriel-vasile/mimetype v1.4.10 // indirect
 	github.com/go-playground/locales v0.14.1 // indirect
 	github.com/go-playground/universal-translator v0.18.1 // indirect
 	github.com/klauspost/cpuid/v2 v2.3.0 // indirect
 	github.com/kr/text v0.2.0 // indirect
 	github.com/leodido/go-urn v1.4.0 // indirect
-	github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd // indirect
+	github.com/modern-go/concurrent v0.0.0-20180228061459-e0a39a4cb421 // indirect
 	github.com/pmezard/go-difflib v1.0.0 // indirect
 	github.com/quic-go/qpack v0.6.0 // indirect
 	github.com/twitchyliquid64/golang-asm v0.15.1 // indirect
-	go.uber.org/mock v0.6.0 // indirect
-	golang.org/x/arch v0.22.0 // indirect
-	golang.org/x/crypto v0.48.0 // indirect
-	golang.org/x/sys v0.41.0 // indirect
-	golang.org/x/text v0.34.0 // indirect
+	golang.org/x/arch v0.20.0 // indirect
+	golang.org/x/crypto v0.45.0 // indirect
+	golang.org/x/sys v0.38.0 // indirect
+	golang.org/x/text v0.31.0 // indirect
+	gopkg.in/yaml.v3 v3.0.1 // indirect
 )

go.sum

@@ -1,17 +1,17 @@
 github.com/bytedance/gopkg v0.1.3 h1:TPBSwH8RsouGCBcMBktLt1AymVo2TVsBVCY4b6TnZ/M=
 github.com/bytedance/gopkg v0.1.3/go.mod h1:576VvJ+eJgyCzdjS+c4+77QF3p7ubbtiKARP3TxducM=
-github.com/bytedance/sonic v1.15.0 h1:/PXeWFaR5ElNcVE84U0dOHjiMHQOwNIx3K4ymzh/uSE=
-github.com/bytedance/sonic v1.15.0/go.mod h1:tFkWrPz0/CUCLEF4ri4UkHekCIcdnkqXw9VduqpJh0k=
-github.com/bytedance/sonic/loader v0.5.0 h1:gXH3KVnatgY7loH5/TkeVyXPfESoqSBSBEiDd5VjlgE=
-github.com/bytedance/sonic/loader v0.5.0/go.mod h1:AR4NYCk5DdzZizZ5djGqQ92eEhCCcdf5x77udYiSJRo=
+github.com/bytedance/sonic v1.14.2 h1:k1twIoe97C1DtYUo+fZQy865IuHia4PR5RPiuGPPIIE=
+github.com/bytedance/sonic v1.14.2/go.mod h1:T80iDELeHiHKSc0C9tubFygiuXoGzrkjKzX2quAx980=
+github.com/bytedance/sonic/loader v0.4.0 h1:olZ7lEqcxtZygCK9EKYKADnpQoYkRQxaeY2NYzevs+o=
+github.com/bytedance/sonic/loader v0.4.0/go.mod h1:AR4NYCk5DdzZizZ5djGqQ92eEhCCcdf5x77udYiSJRo=
 github.com/cloudwego/base64x v0.1.6 h1:t11wG9AECkCDk5fMSoxmufanudBtJ+/HemLstXDLI2M=
 github.com/cloudwego/base64x v0.1.6/go.mod h1:OFcloc187FXDaYHvrNIjxSe8ncn0OOM8gEHfghB2IPU=
 github.com/creack/pty v1.1.9/go.mod h1:oKZEueFk5CKHvIhNR5MUki03XCEU+Q6VDXinZuGJ33E=
 github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
 github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=
 github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
-github.com/gabriel-vasile/mimetype v1.4.12 h1:e9hWvmLYvtp846tLHam2o++qitpguFiYCKbn0w9jyqw=
-github.com/gabriel-vasile/mimetype v1.4.12/go.mod h1:d+9Oxyo1wTzWdyVUPMmXFvp4F9tea18J8ufA774AB3s=
+github.com/gabriel-vasile/mimetype v1.4.10 h1:zyueNbySn/z8mJZHLt6IPw0KoZsiQNszIpU+bX4+ZK0=
+github.com/gabriel-vasile/mimetype v1.4.10/go.mod h1:d+9Oxyo1wTzWdyVUPMmXFvp4F9tea18J8ufA774AB3s=
 github.com/gin-contrib/sse v1.1.0 h1:n0w2GMuUpWDVp7qSpvze6fAu9iRxJY4Hmj6AmBOU05w=
 github.com/gin-contrib/sse v1.1.0/go.mod h1:hxRZ5gVpWMT7Z0B0gSNYqqsSCNIJMjzvm6fqCz9vjwM=
 github.com/go-playground/assert/v2 v2.2.0 h1:JvknZsQTYeFEAhQwI4qEt9cyV5ONwRHC+lYKSsYSR8s=
@@ -20,12 +20,12 @@ github.com/go-playground/locales v0.14.1 h1:EWaQ/wswjilfKLTECiXz7Rh+3BjFhfDFKv/o
 github.com/go-playground/locales v0.14.1/go.mod h1:hxrqLVvrK65+Rwrd5Fc6F2O76J/NuW9t0sjnWqG1slY=
 github.com/go-playground/universal-translator v0.18.1 h1:Bcnm0ZwsGyWbCzImXv+pAJnYK9S473LQFuzCbDbfSFY=
 github.com/go-playground/universal-translator v0.18.1/go.mod h1:xekY+UJKNuX9WP91TpwSH2VMlDf28Uj24BCp08ZFTUY=
-github.com/go-playground/validator/v10 v10.30.1 h1:f3zDSN/zOma+w6+1Wswgd9fLkdwy06ntQJp0BBvFG0w=
-github.com/go-playground/validator/v10 v10.30.1/go.mod h1:oSuBIQzuJxL//3MelwSLD5hc2Tu889bF0Idm9Dg26cM=
-github.com/goccy/go-json v0.10.5 h1:Fq85nIqj+gXn/S5ahsiTlK3TmC85qgirsdTP/+DeaC4=
-github.com/goccy/go-json v0.10.5/go.mod h1:oq7eo15ShAhp70Anwd5lgX2pLfOS3QCiwU/PULtXL6M=
-github.com/goccy/go-yaml v1.19.2 h1:PmFC1S6h8ljIz6gMRBopkjP1TVT7xuwrButHID66PoM=
-github.com/goccy/go-yaml v1.19.2/go.mod h1:XBurs7gK8ATbW4ZPGKgcbrY1Br56PdM69F7LkFRi1kA=
+github.com/go-playground/validator/v10 v10.28.0 h1:Q7ibns33JjyW48gHkuFT91qX48KG0ktULL6FgHdG688=
+github.com/go-playground/validator/v10 v10.28.0/go.mod h1:GoI6I1SjPBh9p7ykNE/yj3fFYbyDOpwMn5KXd+m2hUU=
+github.com/goccy/go-json v0.10.2 h1:CrxCmQqYDkv1z7lO7Wbh2HN93uovUHgrECaO5ZrCXAU=
+github.com/goccy/go-json v0.10.2/go.mod h1:6MelG93GURQebXPDq3khkgXZkazVtN9CRI+MGFi0w8I=
+github.com/goccy/go-yaml v1.19.0 h1:EmkZ9RIsX+Uq4DYFowegAuJo8+xdX3T/2dwNPXbxEYE=
+github.com/goccy/go-yaml v1.19.0/go.mod h1:XBurs7gK8ATbW4ZPGKgcbrY1Br56PdM69F7LkFRi1kA=
 github.com/google/go-cmp v0.7.0 h1:wk8382ETsv4JYUZwIsn6YpYiWiBsYLSJiTsyBybVuN8=
 github.com/google/go-cmp v0.7.0/go.mod h1:pXiqmnSA92OHEEa9HXL2W4E7lf9JzCmGVUdgjX3N/iU=
 github.com/google/gofuzz v1.0.0/go.mod h1:dBl0BpW6vV/+mYPU4Po3pmUjxk6FQPldtuIdl/M65Eg=
@@ -41,9 +41,8 @@ github.com/leodido/go-urn v1.4.0 h1:WT9HwE9SGECu3lg4d/dIA+jxlljEa1/ffXKmRjqdmIQ=
 github.com/leodido/go-urn v1.4.0/go.mod h1:bvxc+MVxLKB4z00jd1z+Dvzr47oO32F/QSNjSBOlFxI=
 github.com/mattn/go-isatty v0.0.20 h1:xfD0iDuEKnDkl03q4limB+vH+GxLEtL/jb4xVJSWWEY=
 github.com/mattn/go-isatty v0.0.20/go.mod h1:W+V8PltTTMOvKvAeJH7IuucS94S2C6jfK/D7dTCTo3Y=
+github.com/modern-go/concurrent v0.0.0-20180228061459-e0a39a4cb421 h1:ZqeYNhU3OHLH3mGKHDcjJRFFRrJa6eAM5H+CtDdOsPc=
 github.com/modern-go/concurrent v0.0.0-20180228061459-e0a39a4cb421/go.mod h1:6dJC0mAP4ikYIbvyc7fijjWJddQyLn8Ig3JB5CqoB9Q=
-github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd h1:TRLaZ9cD/w8PVh93nsPXa1VrQ6jlwL5oN8l14QlcNfg=
-github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd/go.mod h1:6dJC0mAP4ikYIbvyc7fijjWJddQyLn8Ig3JB5CqoB9Q=
 github.com/modern-go/reflect2 v1.0.2 h1:xBagoLtFs94CBntxluKeaWgTMpvLxC4ur3nMaC9Gz0M=
 github.com/modern-go/reflect2 v1.0.2/go.mod h1:yWuevngMOJpCy52FWWMvUC8ws7m/LJsjYzDa0/r8luk=
 github.com/pelletier/go-toml/v2 v2.2.4 h1:mye9XuhQ6gvn5h28+VilKrrPoQVanw5PMw/TB0t5Ec4=
@@ -52,8 +51,8 @@ github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZb
 github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
 github.com/quic-go/qpack v0.6.0 h1:g7W+BMYynC1LbYLSqRt8PBg5Tgwxn214ZZR34VIOjz8=
 github.com/quic-go/qpack v0.6.0/go.mod h1:lUpLKChi8njB4ty2bFLX2x4gzDqXwUpaO1DP9qMDZII=
-github.com/quic-go/quic-go v0.59.0 h1:OLJkp1Mlm/aS7dpKgTc6cnpynnD2Xg7C1pwL6vy/SAw=
-github.com/quic-go/quic-go v0.59.0/go.mod h1:upnsH4Ju1YkqpLXC305eW3yDZ4NfnNbmQRCMWS58IKU=
+github.com/quic-go/quic-go v0.57.1 h1:25KAAR9QR8KZrCZRThWMKVAwGoiHIrNbT72ULHTuI10=
+github.com/quic-go/quic-go v0.57.1/go.mod h1:ly4QBAjHA2VhdnxhojRsCUOeJwKYg+taDlos92xb1+s=
 github.com/rogpeppe/go-internal v1.10.0 h1:TMyTOH3F/DB16zRVcYyreMH6GnZZrwQVAoYjRBZyWFQ=
 github.com/rogpeppe/go-internal v1.10.0/go.mod h1:UQnix2H7Ngw/k4C5ijL5+65zddjncjaFoBhdsK/akog=
 github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME=
@@ -71,21 +70,21 @@ github.com/twitchyliquid64/golang-asm v0.15.1 h1:SU5vSMR7hnwNxj24w34ZyCi/FmDZTkS
 github.com/twitchyliquid64/golang-asm v0.15.1/go.mod h1:a1lVb/DtPvCB8fslRZhAngC2+aY1QWCk3Cedj/Gdt08=
 github.com/ugorji/go/codec v1.3.1 h1:waO7eEiFDwidsBN6agj1vJQ4AG7lh2yqXyOXqhgQuyY=
 github.com/ugorji/go/codec v1.3.1/go.mod h1:pRBVtBSKl77K30Bv8R2P+cLSGaTtex6fsA2Wjqmfxj4=
-go.mongodb.org/mongo-driver/v2 v2.5.0 h1:yXUhImUjjAInNcpTcAlPHiT7bIXhshCTL3jVBkF3xaE=
-go.mongodb.org/mongo-driver/v2 v2.5.0/go.mod h1:yOI9kBsufol30iFsl1slpdq1I0eHPzybRWdyYUs8K/0=
-go.uber.org/mock v0.6.0 h1:hyF9dfmbgIX5EfOdasqLsWD6xqpNZlXblLB/Dbnwv3Y=
-go.uber.org/mock v0.6.0/go.mod h1:KiVJ4BqZJaMj4svdfmHM0AUx4NJYO8ZNpPnZn1Z+BBU=
-golang.org/x/arch v0.22.0 h1:c/Zle32i5ttqRXjdLyyHZESLD/bB90DCU1g9l/0YBDI=
-golang.org/x/arch v0.22.0/go.mod h1:dNHoOeKiyja7GTvF9NJS1l3Z2yntpQNzgrjh1cU103A=
-golang.org/x/crypto v0.48.0 h1:/VRzVqiRSggnhY7gNRxPauEQ5Drw9haKdM0jqfcCFts=
-golang.org/x/crypto v0.48.0/go.mod h1:r0kV5h3qnFPlQnBSrULhlsRfryS2pmewsg+XfMgkVos=
-golang.org/x/net v0.50.0 h1:ucWh9eiCGyDR3vtzso0WMQinm2Dnt8cFMuQa9K33J60=
-golang.org/x/net v0.50.0/go.mod h1:UgoSli3F/pBgdJBHCTc+tp3gmrU4XswgGRgtnwWTfyM=
+go.uber.org/mock v0.5.2 h1:LbtPTcP8A5k9WPXj54PPPbjcI4Y6lhyOZXn+VS7wNko=
+go.uber.org/mock v0.5.2/go.mod h1:wLlUxC2vVTPTaE3UD51E0BGOAElKrILxhVSDYQLld5o=
+golang.org/x/arch v0.20.0 h1:dx1zTU0MAE98U+TQ8BLl7XsJbgze2WnNKF/8tGp/Q6c=
+golang.org/x/arch v0.20.0/go.mod h1:bdwinDaKcfZUGpH09BB7ZmOfhalA8lQdzl62l8gGWsk=
+golang.org/x/crypto v0.45.0 h1:jMBrvKuj23MTlT0bQEOBcAE0mjg8mK9RXFhRH6nyF3Q=
+golang.org/x/crypto v0.45.0/go.mod h1:XTGrrkGJve7CYK7J8PEww4aY7gM3qMCElcJQ8n8JdX4=
+golang.org/x/net v0.47.0 h1:Mx+4dIFzqraBXUugkia1OOvlD6LemFo1ALMHjrXDOhY=
+golang.org/x/net v0.47.0/go.mod h1:/jNxtkgq5yWUGYkaZGqo27cfGZ1c5Nen03aYrrKpVRU=
 golang.org/x/sys v0.6.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
-golang.org/x/sys v0.41.0 h1:Ivj+2Cp/ylzLiEU89QhWblYnOE9zerudt9Ftecq2C6k=
-golang.org/x/sys v0.41.0/go.mod h1:OgkHotnGiDImocRcuBABYBEXf8A9a87e/uXjp9XT3ks=
-golang.org/x/text v0.34.0 h1:oL/Qq0Kdaqxa1KbNeMKwQq0reLCCaFtqu2eNuSeNHbk=
-golang.org/x/text v0.34.0/go.mod h1:homfLqTYRFyVYemLBFl5GgL/DWEiH5wcsQ5gSh1yziA=
+golang.org/x/sys v0.38.0 h1:3yZWxaJjBmCWXqhN1qh02AkOnCQ1poK6oF+a7xWL6Gc=
+golang.org/x/sys v0.38.0/go.mod h1:OgkHotnGiDImocRcuBABYBEXf8A9a87e/uXjp9XT3ks=
+golang.org/x/text v0.31.0 h1:aC8ghyu4JhP8VojJ2lEHBnochRno1sgL6nEi9WGFGMM=
+golang.org/x/text v0.31.0/go.mod h1:tKRAlv61yKIjGGHX/4tP1LTbc13YSec1pxVEWXzfoeM=
+golang.org/x/time v0.12.0 h1:ScB/8o8olJvc+CQPWrK3fPZNfh7qgwCrY0zJmoEQLSE=
+golang.org/x/time v0.12.0/go.mod h1:CDIdPxbZBQxdj6cxyCIdrNogrJKMJ7pr37NYpMcMDSg=
 google.golang.org/protobuf v1.36.10 h1:AYd7cD/uASjIL6Q9LiTjz8JLcrh/88q5UObnmY3aOOE=
 google.golang.org/protobuf v1.36.10/go.mod h1:HTf+CrKn2C3g5S8VImy6tdcUvCska2kB7j23XfzDpco=
 gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=

internal/bytesconv/bytesconv_test.go

@@ -30,7 +30,7 @@ func rawStrToBytes(s string) []byte {
 
 func TestBytesToString(t *testing.T) {
 	data := make([]byte, 1024)
-	for range 100 {
+	for i := 0; i < 100; i++ {
 		_, err := cRand.Read(data)
 		if err != nil {
 			t.Fatal(err)
@@ -79,7 +79,7 @@ func RandStringBytesMaskImprSrcSB(n int) string {
 }
 
 func TestStringToBytes(t *testing.T) {
-	for range 100 {
+	for i := 0; i < 100; i++ {
 		s := RandStringBytesMaskImprSrcSB(64)
 		if !bytes.Equal(rawStrToBytes(s), StringToBytes(s)) {
 			t.Fatal("don't match")

logger.go

@@ -48,11 +48,6 @@ type LoggerConfig struct {
 	// Optional.
 	SkipPaths []string
 
-	// SkipQueryString indicates that query strings should not be written
-	// for cases such as when API keys are passed via query strings.
-	// Optional. Default value is false.
-	SkipQueryString bool
-
 	// Skip is a Skipper that indicates which logs should not be written.
 	// Optional.
 	Skip Skipper
@@ -303,7 +298,7 @@ func LoggerWithConfig(conf LoggerConfig) HandlerFunc {
 
 		param.BodySize = c.Writer.Size()
 
-		if raw != "" && !conf.SkipQueryString {
+		if raw != "" {
 			path = path + "?" + raw
 		}
 

logger_test.go

@@ -318,21 +318,20 @@ func TestColorForStatus(t *testing.T) {
 }
 
 func TestColorForLatency(t *testing.T) {
-	colorForLatency := func(latency time.Duration) string {
+	colorForLantency := func(latency time.Duration) string {
 		p := LogFormatterParams{
 			Latency: latency,
 		}
 		return p.LatencyColor()
 	}
 
-	assert.Equal(t, white, colorForLatency(time.Duration(0)), "0 should be white")
-	assert.Equal(t, white, colorForLatency(time.Millisecond*20), "20ms should be white")
-	assert.Equal(t, green, colorForLatency(time.Millisecond*150), "150ms should be green")
-	assert.Equal(t, cyan, colorForLatency(time.Millisecond*250), "250ms should be cyan")
-	assert.Equal(t, blue, colorForLatency(time.Millisecond*400), "400ms should be blue")
-	assert.Equal(t, yellow, colorForLatency(time.Millisecond*600), "600ms should be yellow")
-	assert.Equal(t, magenta, colorForLatency(time.Millisecond*1500), "1.5s should be magenta")
-	assert.Equal(t, red, colorForLatency(time.Second*3), "other things should be red")
+	assert.Equal(t, white, colorForLantency(time.Duration(0)), "0 should be white")
+	assert.Equal(t, white, colorForLantency(time.Millisecond*20), "20ms should be white")
+	assert.Equal(t, green, colorForLantency(time.Millisecond*150), "150ms should be green")
+	assert.Equal(t, cyan, colorForLantency(time.Millisecond*250), "250ms should be cyan")
+	assert.Equal(t, yellow, colorForLantency(time.Millisecond*600), "600ms should be yellow")
+	assert.Equal(t, magenta, colorForLantency(time.Millisecond*1500), "1.5s should be magenta")
+	assert.Equal(t, red, colorForLantency(time.Second*3), "other things should be red")
 }
 
 func TestResetColor(t *testing.T) {
@@ -472,17 +471,3 @@ func TestForceConsoleColor(t *testing.T) {
 	// reset console color mode.
 	consoleColorMode = autoColor
 }
-
-func TestLoggerWithConfigSkipQueryString(t *testing.T) {
-	buffer := new(strings.Builder)
-	router := New()
-	router.Use(LoggerWithConfig(LoggerConfig{
-		Output:          buffer,
-		SkipQueryString: true,
-	}))
-	router.GET("/logged", func(c *Context) { c.Status(http.StatusOK) })
-
-	PerformRequest(router, "GET", "/logged?a=21")
-	assert.Contains(t, buffer.String(), "200")
-	assert.NotContains(t, buffer.String(), "a=21")
-}

recovery_test.go

@@ -22,7 +22,7 @@ func TestPanicClean(t *testing.T) {
 	router.Use(RecoveryWithWriter(buffer))
 	router.GET("/recovery", func(c *Context) {
 		c.AbortWithStatus(http.StatusBadRequest)
-		panic("Oops, Houston, we have a problem")
+		panic("Oupps, Houston, we have a problem")
 	})
 	// RUN
 	w := PerformRequest(router, http.MethodGet, "/recovery",
@@ -52,14 +52,14 @@ func TestPanicInHandler(t *testing.T) {
 	router := New()
 	router.Use(RecoveryWithWriter(buffer))
 	router.GET("/recovery", func(_ *Context) {
-		panic("Oops, Houston, we have a problem")
+		panic("Oupps, Houston, we have a problem")
 	})
 	// RUN
 	w := PerformRequest(router, http.MethodGet, "/recovery")
 	// TEST
 	assert.Equal(t, http.StatusInternalServerError, w.Code)
 	assert.Contains(t, buffer.String(), "panic recovered")
-	assert.Contains(t, buffer.String(), "Oops, Houston, we have a problem")
+	assert.Contains(t, buffer.String(), "Oupps, Houston, we have a problem")
 	assert.Contains(t, buffer.String(), t.Name())
 	assert.NotContains(t, buffer.String(), "GET /recovery")
 
@@ -80,7 +80,7 @@ func TestPanicWithAbort(t *testing.T) {
 	router.Use(RecoveryWithWriter(nil))
 	router.GET("/recovery", func(c *Context) {
 		c.AbortWithStatus(http.StatusBadRequest)
-		panic("Oops, Houston, we have a problem")
+		panic("Oupps, Houston, we have a problem")
 	})
 	// RUN
 	w := PerformRequest(router, http.MethodGet, "/recovery")
@@ -162,14 +162,14 @@ func TestCustomRecoveryWithWriter(t *testing.T) {
 	}
 	router.Use(CustomRecoveryWithWriter(buffer, handleRecovery))
 	router.GET("/recovery", func(_ *Context) {
-		panic("Oops, Houston, we have a problem")
+		panic("Oupps, Houston, we have a problem")
 	})
 	// RUN
 	w := PerformRequest(router, http.MethodGet, "/recovery")
 	// TEST
 	assert.Equal(t, http.StatusBadRequest, w.Code)
 	assert.Contains(t, buffer.String(), "panic recovered")
-	assert.Contains(t, buffer.String(), "Oops, Houston, we have a problem")
+	assert.Contains(t, buffer.String(), "Oupps, Houston, we have a problem")
 	assert.Contains(t, buffer.String(), t.Name())
 	assert.NotContains(t, buffer.String(), "GET /recovery")
 
@@ -181,7 +181,7 @@ func TestCustomRecoveryWithWriter(t *testing.T) {
 	assert.Equal(t, http.StatusBadRequest, w.Code)
 	assert.Contains(t, buffer.String(), "GET /recovery")
 
-	assert.Equal(t, strings.Repeat("Oops, Houston, we have a problem", 2), errBuffer.String())
+	assert.Equal(t, strings.Repeat("Oupps, Houston, we have a problem", 2), errBuffer.String())
 
 	SetMode(TestMode)
 }
@@ -197,14 +197,14 @@ func TestCustomRecovery(t *testing.T) {
 	}
 	router.Use(CustomRecovery(handleRecovery))
 	router.GET("/recovery", func(_ *Context) {
-		panic("Oops, Houston, we have a problem")
+		panic("Oupps, Houston, we have a problem")
 	})
 	// RUN
 	w := PerformRequest(router, http.MethodGet, "/recovery")
 	// TEST
 	assert.Equal(t, http.StatusBadRequest, w.Code)
 	assert.Contains(t, buffer.String(), "panic recovered")
-	assert.Contains(t, buffer.String(), "Oops, Houston, we have a problem")
+	assert.Contains(t, buffer.String(), "Oupps, Houston, we have a problem")
 	assert.Contains(t, buffer.String(), t.Name())
 	assert.NotContains(t, buffer.String(), "GET /recovery")
 
@@ -216,7 +216,7 @@ func TestCustomRecovery(t *testing.T) {
 	assert.Equal(t, http.StatusBadRequest, w.Code)
 	assert.Contains(t, buffer.String(), "GET /recovery")
 
-	assert.Equal(t, strings.Repeat("Oops, Houston, we have a problem", 2), errBuffer.String())
+	assert.Equal(t, strings.Repeat("Oupps, Houston, we have a problem", 2), errBuffer.String())
 
 	SetMode(TestMode)
 }
@@ -232,14 +232,14 @@ func TestRecoveryWithWriterWithCustomRecovery(t *testing.T) {
 	}
 	router.Use(RecoveryWithWriter(DefaultErrorWriter, handleRecovery))
 	router.GET("/recovery", func(_ *Context) {
-		panic("Oops, Houston, we have a problem")
+		panic("Oupps, Houston, we have a problem")
 	})
 	// RUN
 	w := PerformRequest(router, http.MethodGet, "/recovery")
 	// TEST
 	assert.Equal(t, http.StatusBadRequest, w.Code)
 	assert.Contains(t, buffer.String(), "panic recovered")
-	assert.Contains(t, buffer.String(), "Oops, Houston, we have a problem")
+	assert.Contains(t, buffer.String(), "Oupps, Houston, we have a problem")
 	assert.Contains(t, buffer.String(), t.Name())
 	assert.NotContains(t, buffer.String(), "GET /recovery")
 
@@ -251,7 +251,7 @@ func TestRecoveryWithWriterWithCustomRecovery(t *testing.T) {
 	assert.Equal(t, http.StatusBadRequest, w.Code)
 	assert.Contains(t, buffer.String(), "GET /recovery")
 
-	assert.Equal(t, strings.Repeat("Oops, Houston, we have a problem", 2), errBuffer.String())
+	assert.Equal(t, strings.Repeat("Oupps, Houston, we have a problem", 2), errBuffer.String())
 
 	SetMode(TestMode)
 }

render/bson.go

@@ -1,34 +0,0 @@
-// Copyright 2025 Gin Core Team. All rights reserved.
-// Use of this source code is governed by a MIT style
-// license that can be found in the LICENSE file.
-
-package render
-
-import (
-	"net/http"
-
-	"go.mongodb.org/mongo-driver/v2/bson"
-)
-
-// BSON contains the given interface object.
-type BSON struct {
-	Data any
-}
-
-var bsonContentType = []string{"application/bson"}
-
-// Render (BSON) marshals the given interface object and writes data with custom ContentType.
-func (r BSON) Render(w http.ResponseWriter) error {
-	r.WriteContentType(w)
-
-	bytes, err := bson.Marshal(&r.Data)
-	if err == nil {
-		_, err = w.Write(bytes)
-	}
-	return err
-}
-
-// WriteContentType (BSONBuf) writes BSONBuf ContentType.
-func (r BSON) WriteContentType(w http.ResponseWriter) {
-	writeContentType(w, bsonContentType)
-}

render/data.go

@@ -4,10 +4,7 @@
 
 package render
 
-import (
-	"net/http"
-	"strconv"
-)
+import "net/http"
 
 // Data contains ContentType and bytes data.
 type Data struct {
@@ -18,9 +15,6 @@ type Data struct {
 // Render (Data) writes data with custom ContentType.
 func (r Data) Render(w http.ResponseWriter) (err error) {
 	r.WriteContentType(w)
-	if len(r.Data) > 0 {
-		w.Header().Set("Content-Length", strconv.Itoa(len(r.Data)))
-	}
 	_, err = w.Write(r.Data)
 	return
 }

render/render_msgpack_test.go

@@ -7,7 +7,7 @@
 package render
 
 import (
-	"errors"
+	"bytes"
 	"net/http/httptest"
 	"testing"
 
@@ -16,6 +16,9 @@ import (
 	"github.com/ugorji/go/codec"
 )
 
+// TODO unit tests
+// test errors
+
 func TestRenderMsgPack(t *testing.T) {
 	w := httptest.NewRecorder()
 	data := map[string]any{
@@ -29,52 +32,13 @@ func TestRenderMsgPack(t *testing.T) {
 
 	require.NoError(t, err)
 
-	var decoded map[string]any
-	var mh codec.MsgpackHandle
-	mh.RawToString = true
-	err = codec.NewDecoderBytes(w.Body.Bytes(), &mh).Decode(&decoded)
+	h := new(codec.MsgpackHandle)
+	assert.NotNil(t, h)
+	buf := bytes.NewBuffer([]byte{})
+	assert.NotNil(t, buf)
+	err = codec.NewEncoder(buf, h).Encode(data)
+
 	require.NoError(t, err)
-	assert.Equal(t, data, decoded)
+	assert.Equal(t, w.Body.String(), buf.String())
 	assert.Equal(t, "application/msgpack; charset=utf-8", w.Header().Get("Content-Type"))
 }
-
-func TestWriteMsgPack(t *testing.T) {
-	w := httptest.NewRecorder()
-	data := map[string]any{
-		"foo": "bar",
-		"num": 42,
-	}
-
-	err := WriteMsgPack(w, data)
-	require.NoError(t, err)
-
-	assert.Equal(t, "application/msgpack; charset=utf-8", w.Header().Get("Content-Type"))
-
-	var decoded map[string]any
-	var mh codec.MsgpackHandle
-	mh.RawToString = true
-	err = codec.NewDecoderBytes(w.Body.Bytes(), &mh).Decode(&decoded)
-	require.NoError(t, err)
-	assert.Len(t, decoded, 2)
-	assert.Equal(t, "bar", decoded["foo"])
-	assert.EqualValues(t, 42, decoded["num"])
-}
-
-type failWriter struct {
-	*httptest.ResponseRecorder
-}
-
-func (w *failWriter) Write(data []byte) (int, error) {
-	return 0, errors.New("write error")
-}
-
-func TestRenderMsgPackError(t *testing.T) {
-	w := httptest.NewRecorder()
-	data := map[string]any{
-		"foo": "bar",
-	}
-
-	err := (MsgPack{data}).Render(&failWriter{w})
-	require.Error(t, err)
-	assert.Contains(t, err.Error(), "write error")
-}

render/render_test.go

@@ -8,7 +8,6 @@ import (
 	"encoding/xml"
 	"errors"
 	"html/template"
-	"io"
 	"net"
 	"net/http"
 	"net/http/httptest"
@@ -16,13 +15,16 @@ import (
 	"strings"
 	"testing"
 
+	"github.com/gin-gonic/gin/codec/json"
 	testdata "github.com/gin-gonic/gin/testdata/protoexample"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
-	"go.mongodb.org/mongo-driver/v2/bson"
 	"google.golang.org/protobuf/proto"
 )
 
+// TODO unit tests
+// test errors
+
 func TestRenderJSON(t *testing.T) {
 	w := httptest.NewRecorder()
 	data := map[string]any{
@@ -137,44 +139,19 @@ func TestRenderJsonpJSON(t *testing.T) {
 }
 
 type errorWriter struct {
-	bufString    string
-	ErrThreshold int // 1-based threshold. If 1, errors on the 1st Write call.
-	writeCount   int
+	bufString string
 	*httptest.ResponseRecorder
 }
 
 var _ http.ResponseWriter = (*errorWriter)(nil)
 
-func (w *errorWriter) Header() http.Header {
-	if w.ResponseRecorder == nil {
-		w.ResponseRecorder = httptest.NewRecorder()
-	}
-	return w.ResponseRecorder.Header()
-}
-
-func (w *errorWriter) WriteHeader(statusCode int) {
-	if w.ResponseRecorder == nil {
-		w.ResponseRecorder = httptest.NewRecorder()
-	}
-	w.ResponseRecorder.WriteHeader(statusCode)
-}
-
 func (w *errorWriter) Write(buf []byte) (int, error) {
-	w.writeCount++
-	if (w.bufString != "" && string(buf) == w.bufString) || (w.ErrThreshold > 0 && w.writeCount >= w.ErrThreshold) {
-		return 0, errors.New(`write error`)
-	}
-	if w.ResponseRecorder == nil {
-		w.ResponseRecorder = httptest.NewRecorder()
+	if string(buf) == w.bufString {
+		return 0, errors.New(`write "` + w.bufString + `" error`)
 	}
 	return w.ResponseRecorder.Write(buf)
 }
 
-func (w *errorWriter) reset() {
-	w.writeCount = 0
-	w.ResponseRecorder = httptest.NewRecorder()
-}
-
 func TestRenderJsonpJSONError(t *testing.T) {
 	ew := &errorWriter{
 		ResponseRecorder: httptest.NewRecorder(),
@@ -187,33 +164,23 @@ func TestRenderJsonpJSONError(t *testing.T) {
 		},
 	}
 
-	// error was returned while writing callback
-	ew.reset()
-	ew.ErrThreshold = 1
-	err := jsonpJSON.Render(ew)
-	require.Error(t, err)
-	assert.Equal(t, "write error", err.Error())
+	cb := template.JSEscapeString(jsonpJSON.Callback)
+	ew.bufString = cb
+	err := jsonpJSON.Render(ew) // error was returned while writing callback
+	assert.Equal(t, `write "`+cb+`" error`, err.Error())
 
-	// error was returned while writing "("
-	ew.reset()
-	ew.ErrThreshold = 2
+	ew.bufString = `(`
 	err = jsonpJSON.Render(ew)
-	require.Error(t, err)
-	assert.Equal(t, "write error", err.Error())
+	assert.Equal(t, `write "`+`(`+`" error`, err.Error())
 
-	// error was returned while writing data
-	ew.reset()
-	ew.ErrThreshold = 3
+	data, _ := json.API.Marshal(jsonpJSON.Data) // error was returned while writing data
+	ew.bufString = string(data)
 	err = jsonpJSON.Render(ew)
-	require.Error(t, err)
-	assert.Equal(t, "write error", err.Error())
+	assert.Equal(t, `write "`+string(data)+`" error`, err.Error())
 
-	// error was returned while writing ");"
-	ew.reset()
-	ew.ErrThreshold = 4
+	ew.bufString = `);`
 	err = jsonpJSON.Render(ew)
-	require.Error(t, err)
-	assert.Equal(t, "write error", err.Error())
+	assert.Equal(t, `write "`+`);`+`" error`, err.Error())
 }
 
 func TestRenderJsonpJSONError2(t *testing.T) {
@@ -392,55 +359,6 @@ func TestRenderProtoBufFail(t *testing.T) {
 	require.Error(t, err)
 }
 
-func TestRenderBSON(t *testing.T) {
-	w := httptest.NewRecorder()
-	reps := []int64{int64(1), int64(2)}
-	type mystruct struct {
-		Label string
-		Reps  []int64
-	}
-
-	data := &mystruct{
-		Label: "test",
-		Reps:  reps,
-	}
-
-	(BSON{data}).WriteContentType(w)
-	bsonData, err := bson.Marshal(data)
-	require.NoError(t, err)
-	assert.Equal(t, "application/bson", w.Header().Get("Content-Type"))
-
-	err = (BSON{data}).Render(w)
-
-	require.NoError(t, err)
-	assert.Equal(t, bsonData, w.Body.Bytes())
-	assert.Equal(t, "application/bson", w.Header().Get("Content-Type"))
-}
-
-func TestRenderBSONError(t *testing.T) {
-	w := httptest.NewRecorder()
-	data := make(chan int)
-
-	err := (BSON{data}).Render(w)
-	require.Error(t, err)
-}
-
-func TestRenderBSONWriteError(t *testing.T) {
-	type testStruct struct {
-		Value string
-	}
-	data := &testStruct{Value: "test"}
-
-	ew := &errorWriter{
-		ErrThreshold:     1,
-		ResponseRecorder: httptest.NewRecorder(),
-	}
-
-	err := (BSON{data}).Render(ew)
-	require.Error(t, err)
-	assert.Equal(t, "write error", err.Error())
-}
-
 func TestRenderXML(t *testing.T) {
 	w := httptest.NewRecorder()
 	data := xmlmap{
@@ -457,15 +375,6 @@ func TestRenderXML(t *testing.T) {
 	assert.Equal(t, "application/xml; charset=utf-8", w.Header().Get("Content-Type"))
 }
 
-func TestRenderXMLError(t *testing.T) {
-	w := httptest.NewRecorder()
-	data := make(chan int)
-
-	err := (XML{data}).Render(w)
-	require.Error(t, err)
-	assert.Contains(t, err.Error(), "xml: unsupported type: chan int")
-}
-
 func TestRenderPDF(t *testing.T) {
 	w := httptest.NewRecorder()
 	data := []byte("%Test pdf content")
@@ -534,52 +443,6 @@ func TestRenderData(t *testing.T) {
 	require.NoError(t, err)
 	assert.Equal(t, "#!PNG some raw data", w.Body.String())
 	assert.Equal(t, "image/png", w.Header().Get("Content-Type"))
-	assert.Equal(t, "19", w.Header().Get("Content-Length"))
-}
-
-func TestRenderDataContentLength(t *testing.T) {
-	srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
-		size, err := strconv.Atoi(r.URL.Query().Get("size"))
-		assert.NoError(t, err)
-
-		data := Data{
-			ContentType: "application/octet-stream",
-			Data:        make([]byte, size),
-		}
-		assert.NoError(t, data.Render(w))
-	}))
-	t.Cleanup(srv.Close)
-
-	for _, size := range []int{0, 1, 100, 100_000} {
-		t.Run(strconv.Itoa(size), func(t *testing.T) {
-			resp, err := http.Get(srv.URL + "?size=" + strconv.Itoa(size))
-			require.NoError(t, err)
-			defer resp.Body.Close()
-
-			assert.Equal(t, "application/octet-stream", resp.Header.Get("Content-Type"))
-			assert.Equal(t, strconv.Itoa(size), resp.Header.Get("Content-Length"))
-
-			actual, err := io.Copy(io.Discard, resp.Body)
-			require.NoError(t, err)
-			assert.EqualValues(t, size, actual)
-		})
-	}
-}
-
-func TestRenderDataError(t *testing.T) {
-	ew := &errorWriter{
-		ErrThreshold:     1,
-		ResponseRecorder: httptest.NewRecorder(),
-	}
-	data := []byte("#!PNG some raw data")
-
-	err := (Data{
-		ContentType: "image/png",
-		Data:        data,
-	}).Render(ew)
-
-	require.Error(t, err)
-	assert.Equal(t, "write error", err.Error())
 }
 
 func TestRenderString(t *testing.T) {
@@ -721,32 +584,6 @@ func TestRenderHTMLDebugPanics(t *testing.T) {
 	assert.Panics(t, func() { htmlRender.Instance("", nil) })
 }
 
-func TestRenderHTMLTemplateError(t *testing.T) {
-	w := httptest.NewRecorder()
-	templ := template.Must(template.New("t").Parse(`Hello {{if .name}}{{.name.DoesNotExist}}{{end}}`))
-
-	htmlRender := HTMLProduction{Template: templ}
-	instance := htmlRender.Instance("t", map[string]any{
-		"name": "alexandernyquist",
-	})
-
-	err := instance.Render(w)
-	require.Error(t, err)
-}
-
-func TestRenderHTMLTemplateExecuteError(t *testing.T) {
-	w := httptest.NewRecorder()
-	templ := template.Must(template.New("t").Parse(`Hello {{.name.invalid}}`))
-
-	htmlRender := HTMLProduction{Template: templ}
-	instance := htmlRender.Instance("t", map[string]any{
-		"name": "alexandernyquist",
-	})
-
-	err := instance.Render(w)
-	require.Error(t, err)
-}
-
 func TestRenderReader(t *testing.T) {
 	w := httptest.NewRecorder()
 
@@ -798,10 +635,10 @@ func TestRenderWriteError(t *testing.T) {
 	prefix := "my-prefix:"
 	r := SecureJSON{Data: data, Prefix: prefix}
 	ew := &errorWriter{
-		ErrThreshold:     1,
+		bufString:        prefix,
 		ResponseRecorder: httptest.NewRecorder(),
 	}
 	err := r.Render(ew)
 	require.Error(t, err)
-	assert.Equal(t, "write error", err.Error())
+	assert.Equal(t, `write "my-prefix:" error`, err.Error())
 }

routergroup.go

@@ -169,7 +169,7 @@ func (group *RouterGroup) StaticFile(relativePath, filepath string) IRoutes {
 	})
 }
 
-// StaticFileFS works just like `StaticFile` but a custom `http.FileSystem` can be used instead.
+// StaticFileFS works just like `StaticFile` but a custom `http.FileSystem` can be used instead..
 // router.StaticFileFS("favicon.ico", "./resources/favicon.ico", Dir{".", false})
 // Gin by default uses: gin.Dir()
 func (group *RouterGroup) StaticFileFS(relativePath, filepath string, fs http.FileSystem) IRoutes {

tree.go

@@ -671,7 +671,12 @@ walk: // Outer loop for walking the tree
 func (n *node) findCaseInsensitivePath(path string, fixTrailingSlash bool) ([]byte, bool) {
 	const stackBufSize = 128
 
-	buf := make([]byte, 0, max(stackBufSize, len(path)+1))
+	// Use a static sized buffer on the stack in the common case.
+	// If the path is too long, allocate a buffer on the heap instead.
+	buf := make([]byte, 0, stackBufSize)
+	if length := len(path) + 1; length > stackBufSize {
+		buf = make([]byte, 0, length)
+	}
 
 	ciPath := n.findCaseInsensitivePathRec(
 		path,
@@ -818,72 +823,7 @@ walk: // Outer loop for walking the tree
 			return nil
 		}
 
-		// When wildChild is true, try static children first (via indices)
-		// before falling back to the wildcard child. This ensures that
-		// case-insensitive lookups prefer static routes over param routes
-		// (e.g., /PREFIX/XXX should resolve to /prefix/xxx, not match :id).
-		if len(n.indices) > 0 {
-			rb = shiftNRuneBytes(rb, npLen)
-
-			if rb[0] != 0 {
-				idxc := rb[0]
-				for i, c := range []byte(n.indices) {
-					if c == idxc {
-						if out := n.children[i].findCaseInsensitivePathRec(
-							path, ciPath, rb, fixTrailingSlash,
-						); out != nil {
-							return out
-						}
-						break
-					}
-				}
-			} else {
-				var rv rune
-				var off int
-				for max_ := min(npLen, 3); off < max_; off++ {
-					if i := npLen - off; utf8.RuneStart(oldPath[i]) {
-						rv, _ = utf8.DecodeRuneInString(oldPath[i:])
-						break
-					}
-				}
-
-				lo := unicode.ToLower(rv)
-				utf8.EncodeRune(rb[:], lo)
-				rb = shiftNRuneBytes(rb, off)
-
-				idxc := rb[0]
-				for i, c := range []byte(n.indices) {
-					if c == idxc {
-						if out := n.children[i].findCaseInsensitivePathRec(
-							path, ciPath, rb, fixTrailingSlash,
-						); out != nil {
-							return out
-						}
-						break
-					}
-				}
-
-				if up := unicode.ToUpper(rv); up != lo {
-					utf8.EncodeRune(rb[:], up)
-					rb = shiftNRuneBytes(rb, off)
-
-					idxc := rb[0]
-					for i, c := range []byte(n.indices) {
-						if c == idxc {
-							if out := n.children[i].findCaseInsensitivePathRec(
-								path, ciPath, rb, fixTrailingSlash,
-							); out != nil {
-								return out
-							}
-							break
-						}
-					}
-				}
-			}
-		}
-
-		// Fall back to wildcard child, which is always at the end of the array
-		n = n.children[len(n.children)-1]
+		n = n.children[0]
 		switch n.nType {
 		case param:
 			// Find param end (either '/' or path end)

tree_test.go

@@ -1018,96 +1018,3 @@ func TestWildcardInvalidSlash(t *testing.T) {
 		}
 	}
 }
-
-func TestTreeFindCaseInsensitivePathWithMultipleChildrenAndWildcard(t *testing.T) {
-	tree := &node{}
-
-	// Setup routes that create a node with both static children and a wildcard child.
-	// This configuration previously caused a panic ("invalid node type") in
-	// findCaseInsensitivePathRec because it accessed children[0] instead of the
-	// wildcard child (which is always at the end of the children array).
-	// See: https://github.com/gin-gonic/gin/issues/2959
-	routes := [...]string{
-		"/aa/aa",
-		"/:bb/aa",
-	}
-
-	for _, route := range routes {
-		recv := catchPanic(func() {
-			tree.addRoute(route, fakeHandler(route))
-		})
-		if recv != nil {
-			t.Fatalf("panic inserting route '%s': %v", route, recv)
-		}
-	}
-
-	// These lookups previously panicked with "invalid node type" because
-	// findCaseInsensitivePathRec picked children[0] (a static node) instead
-	// of the wildcard child at the end of the array.
-	out, found := tree.findCaseInsensitivePath("/aa", true)
-	if found {
-		t.Errorf("Expected no match for '/aa', but got: %s", string(out))
-	}
-
-	out, found = tree.findCaseInsensitivePath("/aa/aa/aa/aa", true)
-	if found {
-		t.Errorf("Expected no match for '/aa/aa/aa/aa', but got: %s", string(out))
-	}
-
-	// Case-insensitive lookup should match the static route /aa/aa
-	out, found = tree.findCaseInsensitivePath("/AA/AA", true)
-	if !found {
-		t.Error("Route '/AA/AA' not found via case-insensitive lookup")
-	} else if string(out) != "/aa/aa" {
-		t.Errorf("Wrong result for '/AA/AA': expected '/aa/aa', got: %s", string(out))
-	}
-}
-
-func TestTreeFindCaseInsensitivePathWildcardParamAndStaticChild(t *testing.T) {
-	tree := &node{}
-
-	// Another variant: param route + static route under same prefix
-	routes := [...]string{
-		"/prefix/:id",
-		"/prefix/xxx",
-	}
-
-	for _, route := range routes {
-		recv := catchPanic(func() {
-			tree.addRoute(route, fakeHandler(route))
-		})
-		if recv != nil {
-			t.Fatalf("panic inserting route '%s': %v", route, recv)
-		}
-	}
-
-	// Should NOT panic even for paths that don't match any route
-	out, found := tree.findCaseInsensitivePath("/prefix/a/b/c", true)
-	if found {
-		t.Errorf("Expected no match for '/prefix/a/b/c', but got: %s", string(out))
-	}
-
-	// Exact match should still work
-	out, found = tree.findCaseInsensitivePath("/prefix/xxx", true)
-	if !found {
-		t.Error("Route '/prefix/xxx' not found")
-	} else if string(out) != "/prefix/xxx" {
-		t.Errorf("Wrong result for '/prefix/xxx': %s", string(out))
-	}
-
-	// Case-insensitive match should work
-	out, found = tree.findCaseInsensitivePath("/PREFIX/XXX", true)
-	if !found {
-		t.Error("Route '/PREFIX/XXX' not found via case-insensitive lookup")
-	} else if string(out) != "/prefix/xxx" {
-		t.Errorf("Wrong result for '/PREFIX/XXX': expected '/prefix/xxx', got: %s", string(out))
-	}
-
-	// Param route should still match
-	out, found = tree.findCaseInsensitivePath("/prefix/something", true)
-	if !found {
-		t.Error("Route '/prefix/something' not found via param match")
-	} else if string(out) != "/prefix/something" {
-		t.Errorf("Wrong result for '/prefix/something': %s", string(out))
-	}
-}

utils.go

@@ -162,7 +162,7 @@ func resolveAddress(addr []string) string {
 
 // https://stackoverflow.com/questions/53069040/checking-a-string-contains-only-ascii-characters
 func isASCII(s string) bool {
-	for i := range len(s) {
+	for i := 0; i < len(s); i++ {
 		if s[i] > unicode.MaxASCII {
 			return false
 		}

utils_test.go

@@ -13,7 +13,6 @@ import (
 	"testing"
 
 	"github.com/stretchr/testify/assert"
-	"github.com/stretchr/testify/require"
 )
 
 func init() {
@@ -146,17 +145,6 @@ func TestMarshalXMLforH(t *testing.T) {
 	assert.Error(t, e)
 }
 
-func TestMarshalXMLforHSuccess(t *testing.T) {
-	h := H{
-		"key1": "value1",
-		"key2": 123,
-	}
-	data, err := xml.Marshal(h)
-	require.NoError(t, err)
-	assert.Contains(t, string(data), "<key1>value1</key1>")
-	assert.Contains(t, string(data), "<key2>123</key2>")
-}
-
 func TestIsASCII(t *testing.T) {
 	assert.True(t, isASCII("test"))
 	assert.False(t, isASCII("🧡💛💚💙💜"))