Merge 929794596f18ada3ca5edfeae193c3b1a1c33823 into 2a794cd0b0faa7d829291375b27a3467ea972b0d

fix(debug): version mismatch (#4403 )
Co-authored-by: Bo-Yi Wu <appleboy.tw@gmail.com>
2026-07-06 10:21:17 +08:00 · 2025-12-04 14:16:12 +07:00 · 2025-12-04 10:49:37 +08:00 · 2023-08-02 00:13:28 +02:00
3 changed files with 9 additions and 2 deletions
--- a/context.go
+++ b/context.go
@ -1094,7 +1094,7 @@ func (c *Context) SetCookie(name, value string, maxAge int, path, domain string,
 	}
 	http.SetCookie(c.Writer, &http.Cookie{
 		Name:     name,
-		Value:    url.QueryEscape(value),
+		Value:    value,
 		MaxAge:   maxAge,
 		Path:     path,
 		Domain:   domain,
--- a/context_test.go
+++ b/context_test.go
@ -1002,6 +1002,13 @@ func TestContextSetCookiePathEmpty(t *testing.T) {
 	assert.Equal(t, "user=gin; Path=/; Domain=localhost; Max-Age=1; HttpOnly; Secure; SameSite=Lax", c.Writer.Header().Get("Set-Cookie"))
 }

+func TestContextSetCookieWithSpace(t *testing.T) {
+	c, _ := CreateTestContext(httptest.NewRecorder())
+	c.SetSameSite(http.SameSiteLaxMode)
+	c.SetCookie("user", "gin test", 1, "/", "localhost", true, true)
+	assert.Equal(t, "user=\"gin test\"; Path=/; Domain=localhost; Max-Age=1; HttpOnly; Secure; SameSite=Lax", c.Writer.Header().Get("Set-Cookie"))
+}
+
 func TestContextGetCookie(t *testing.T) {
 	c, _ := CreateTestContext(httptest.NewRecorder())
 	c.Request, _ = http.NewRequest(http.MethodGet, "/get", nil)
--- a/debug.go
+++ b/debug.go
@ -13,7 +13,7 @@ import (
 	"sync/atomic"
 )

-const ginSupportMinGoVer = 23
+const ginSupportMinGoVer = 24

 // IsDebugging returns true if the framework is running in debug mode.
 // Use SetMode(gin.ReleaseMode) to disable debug mode.
Author	SHA1	Message	Date
Ludovico Cavedon	eadee8f52f	Merge 929794596f18ada3ca5edfeae193c3b1a1c33823 into 2a794cd0b0faa7d829291375b27a3467ea972b0d	2025-12-04 14:16:12 +07:00
OHZEKI Naoki	2a794cd0b0	fix(debug): version mismatch (#4403 ) Co-authored-by: Bo-Yi Wu <appleboy.tw@gmail.com>	2025-12-04 10:49:37 +08:00
Ludovico Cavedon	929794596f	Do not QueryEscape cookies (#1717 ) Cookies values are already sanitized by the Go http library, so there is no need to invoke QueryEscape() on them. Furthermore, QueryEscape() has the undesirable effect of replacing spaces wiith "+" characters.	2023-08-02 00:13:28 +02:00