blackteay/gin
3
0
Fork 0
mirror of https://github.com/gin-gonic/gin.git synced 2026-09-13 05:15:45 +08:00
Code Issues Projects Releases Wiki Activity
2,001 Commits 20 Branches 38 Tags
Commit Graph

65 Commits

Author SHA1 Message Date
cloud
372204cb83 change if/else if to 
switch
 2026-06-03 13:31:06 +08:00
cloud
95fc7031a7 1：tagValue only needs to be assigned once, which removes an unnecessary step. 
2：This reduces a redundant check. When tagValue is empty, we can first check whether field.Name is empty before assigning it.With this approach, the comment in the second block can also be removed.

3：The second invocation of k, v := head(opt, "=") in the original code appears to be unnecessary and can be removed.

Some of these changes may be too minor to provide any meaningful benefit, and the actual optimization is very limited. Please feel free to ignore any suggestions that do not seem worthwhile.
 2026-06-03 13:10:51 +08:00
cloud
9654077b1b delete one row 2026-06-02 23:00:27 +08:00
wanghaolong613
e3118cc378
refactor: for loop can be modernized using range over int (#4392) 
Co-authored-by: Bo-Yi Wu <appleboy.tw@gmail.com>
 2026-01-25 00:51:11 +08:00
takanuva15
192ac89eef
feat(binding): add support for encoding.UnmarshalText in uri/query binding (#4203) 2026-01-24 15:20:24 +08:00
guonaihong
b917b14ff9
fix(binding): empty value error (#2169) 
* fix empty value error

Here is the code that can report an error
```go
package main

import (
	"fmt"
	"github.com/gin-gonic/gin"
	"io"
	"net/http"
	"os"
	"time"
)

type header struct {
	Duration   time.Duration `header:"duration"`
	CreateTime time.Time     `header:"createTime" time_format:"unix"`
}

func needFix1() {
	g := gin.Default()
	g.GET("/", func(c *gin.Context) {
		h := header{}
		err := c.ShouldBindHeader(&h)
		if err != nil {
			c.JSON(500, fmt.Sprintf("fail:%s\n", err))
			return
		}

		c.JSON(200, h)
	})

	g.Run(":8081")
}

func needFix2() {
	g := gin.Default()
	g.GET("/", func(c *gin.Context) {
		h := header{}
		err := c.ShouldBindHeader(&h)
		if err != nil {
			c.JSON(500, fmt.Sprintf("fail:%s\n", err))
			return
		}

		c.JSON(200, h)
	})

	g.Run(":8082")
}

func sendNeedFix1() {
	// send to needFix1
	sendBadData("http://127.0.0.1:8081", "duration")
}

func sendNeedFix2() {
	// send to needFix2
	sendBadData("http://127.0.0.1:8082", "createTime")
}

func sendBadData(url, key string) {
	req, err := http.NewRequest("GET", "http://127.0.0.1:8081", nil)
	if err != nil {
		fmt.Printf("err:%s\n", err)
		return
	}

	// Only the key and no value can cause an error
	req.Header.Add(key, "")
	rsp, err := http.DefaultClient.Do(req)
	if err != nil {
		return
	}
	io.Copy(os.Stdout, rsp.Body)
	rsp.Body.Close()
}

func main() {
	go needFix1()
	go needFix2()

	time.Sleep(time.Second / 1000 * 200) // 200ms
	sendNeedFix1()
	sendNeedFix2()
}

```

* modify code

* add comment

* test(binding): use 'any' alias and require.NoError in form mapping tests

- Replace 'interface{}' with 'any' alias in bindTestData struct
- Change assert.NoError to require.NoError in TestMappingTimeUnixNano and TestMappingTimeDuration to fail fast on mapping errors

---------

Co-authored-by: Bo-Yi Wu <appleboy.tw@gmail.com>
 2025-12-03 19:18:10 +08:00
Name
c3d1092b3b
fix(binding): improve empty slice/array handling in form binding (#4380) 
Co-authored-by: huangzw <huangzw@2345.com>
 2025-10-11 19:20:41 +08:00
russcoss
39858a0859
refactor(binding): use maps.Copy for cleaner map handling (#4352) 
Signed-off-by: russcoss <russcoss@outlook.com>
 2025-09-27 11:03:59 +08:00
Leon cap
ad4f436ae9
docs: correct article usage in comments (#4301) 
- Fix 'an url' to 'a URL' in logger.go comment
- Fix 'an form' to 'a form' in binding/form_mapping.go comment
- Improve grammar consistency in code documentation
 2025-07-19 14:58:12 +08:00
Tim
688a429d19
feat: support custom json codec at runtime (#3391) 
* refactor(json): export json codec

* feat(json): support custom json codec at runtime

* chore(copyright): update copyright to 2025 gin core team

* docs(gin): add custom json codec examples in doc file
 2025-06-16 23:16:36 +08:00
Bo-Yi Wu
8fb3136664
Revert "fix(time): binding time with empty value (#4103)" (#4245) 
This reverts commit 674522db91d637d179c16c372d87756ea26fa089.
 2025-05-22 19:20:04 +08:00
Kashiwa
674522db91
fix(time): binding time with empty value (#4103) 
* fix: binding time with empty value (#4098)

* refact: simplify null-to-zero filling logic

* test: add test for zeroUnixNanoTime
 2025-05-21 19:21:46 +08:00
takanuva15
4ccfa7c275
feat(binding): add support for unixMilli and unixMicro (#4190) 2025-03-20 23:33:10 +08:00
takanuva15
f05f966a08
feat(form): Support default values for collections in form binding (#4048) 2024-09-21 23:24:18 +08:00
Ahmad Saeed Goda
28e57f58b1
fix(form): Set default value for form fields (#4047) 
- Use specified default value in struct tags when binding a request input to struct for validation, even if sent empty, not only when not sent at all.
- Add string field to `TestMappingDefault` test case.
- Add test case for not sent form field to default to the value specified via code.
- Add test case for form field sent empty to default to the value specified via code.

Fixes: How to apply default value if empty value provided by client during model binding? #4042, #13042df, #a41721a
 2024-09-06 13:21:19 +08:00
Jo YoHan
3cb30679b5
feat(form): add array collection format in form binding (#3986) 
* feat(form): add array collection format in form binding

* feat(form): add array collection format in form binding

* test(form): fix test code for array collection format in form binding
 2024-08-24 14:16:30 +08:00
bruceNu1l
24d67647cb
feat(form): add custom string slice for form tag unmarshal (#3970) (#3971) 
Co-authored-by: Bruce Lee <admin@ifocusad.com>
 2024-05-23 10:16:11 +08:00
lgbgbl
8dd088927a
refactor(binding): use strings.Cut to replace strings.Index (#3522) 2024-05-08 06:28:15 +08:00
dkkb
a18219566c
feat(binding): Support custom BindUnmarshaler for binding. (#3933) 2024-05-07 09:43:15 +08:00
clearcode
3dc1cd6572
fix(binding): binding error while not upload file (#3819) (#3820) 
Co-authored-by: zhangmj <zhangmj1@dustess.com>
 2024-02-05 10:46:35 +08:00
Omkar P
44d0dd7092
fix: Add pointer support for url query params (#3659) (#3666) 
The pointer support in url query params (using []*Struct for binding query params) was previously available in Gin, but was removed in commit 0d50ce8 since there wasn't a test case for such a scenario, and so the case block was removed as a redundant one.
 2023-11-16 23:46:43 +08:00
John Bampton
24a1d2adb9
fix(typo): spelling covert -> convert (#3325) 2022-10-16 09:41:14 +08:00
thinkerou
4b68a5f12a
chore: update go.mod and remove space from copyright (#3158) 
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2022-05-28 10:42:28 +08:00
thinkerou
2bde107686
test support go1.18 (#2990) 2022-03-21 09:43:17 +08:00
axiaoxin
1a2bc0e7cb
setted typo fix: There’s no such word as setted, set is set, set, setting (#2886) 2021-09-30 10:04:28 +08:00
Alexander Melentyev
527d950252
Delete unused arg (#2834) 2021-08-21 14:59:17 +08:00
Matthieu MOREL
435a76b735
chore(ci): update dependencies (#2827) 
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Matthieu MOREL <mmorel-35@users.noreply.github.com>
 2021-08-19 15:46:31 +08:00
voidman
690aa2b1b9
feat(binding): support custom struct tag (#2720) 
* feat(binding): support custom struct tag

Add function `binding.MapFormWithTag` (#2719)

* doc: add 'bind form-data with custom struct tag'

Add 'Bind form-data request with custom struct and custom tag' section (#2719)

* test(binding): add test for MapFromWithTag
 2021-06-30 00:53:56 +08:00
heige
97a32b1de3
Optimize code adjust (#2700) 
* setFormMap error of result

* adjust code for TrySet

* error export for type multipart.FileHeader

* code style adjust

* reflect code maping optimize

* Update form_mapping.go

Co-authored-by: Bo-Yi Wu <appleboy.tw@gmail.com>
Co-authored-by: thinkerou <thinkerou@gmail.com>
 2021-06-02 07:35:30 +08:00
Alessandro (Ale) Segala
65ed60ed13
Allow bind with a map[string]string (#2484) 
Co-authored-by: thinkerou <thinkerou@gmail.com>
 2020-10-31 07:20:47 +08:00
lantw44
30b5f7e2d7
binding: avoid 2038 problem on 32-bit architectures (#2450) 
Function setTimeField calls strconv.ParseInt with bit size 0 when
parsing Unix time, which means it is equivalent to specifying 32 on
32-bit architectures. This causes the function to suffer from the year
2038 problem. To fix it and keep the behavior the same on both 32-bit
and 64-bit architectures, explicitly specify bit size 64.

Co-authored-by: thinkerou <thinkerou@gmail.com>
 2020-08-08 17:31:08 +08:00
Andy Pan
982daeb1ec Use zero-copy approach to convert types between string and byte… (#2206) 
* Use zero-copy approach to convert types between string and byte slice

* Rename argument to a eligible one

Benchmark:

BenchmarkBytesConvBytesToStrRaw-4   	21003800	        70.9 ns/op	      96 B/op	       1 allocs/op
BenchmarkBytesConvBytesToStr-4      	1000000000	         0.333 ns/op	       0 B/op	       0 allocs/op
BenchmarkBytesConvStrToBytesRaw-4   	18478059	        59.3 ns/op	      96 B/op	       1 allocs/op
BenchmarkBytesConvStrToBytes-4      	1000000000	         0.373 ns/op	       0 B/op	       0 allocs/op


Co-authored-by: Bo-Yi Wu <appleboy.tw@gmail.com>
 2020-01-18 00:32:50 +08:00
Dmitry Kutakov
db9174ae0c fix ignore walking on form mapping (#1942) (#1943) 2019-11-01 10:47:40 +08:00
ZhangYunHao
8a1bfcfd3b format errUnknownType (#2103) 2019-10-26 14:20:35 +08:00
guonaihong
502c898d75 binding: support unix time (#1980) 
* binding: support unix time

ref:#1979

* binding: support unix time

add test file
modify readme

```golang
package main

import (
        "fmt"
        "github.com/gin-gonic/gin"
        "time"
)

type shareTime struct {
        CreateTime time.Time `form:"createTime" time_format:"unixNano"`
        UnixTime   time.Time `form:"unixTime" time_format:"unix"`
}

func main() {
        r := gin.Default()
        unix := r.Group("/unix")

        testCT := time.Date(2019, 7, 6, 16, 0, 33, 123, time.Local)
        fmt.Printf("%d\n", testCT.UnixNano())

        testUT := time.Date(2019, 7, 6, 16, 0, 33, 0, time.Local)
        fmt.Printf("%d\n", testUT.Unix())

        unix.GET("/nano", func(c *gin.Context) {
                s := shareTime{}

                c.ShouldBindQuery(&s)

                if !testCT.Equal(s.CreateTime) {
                        c.String(500, "want %d got %d", testCT.UnixNano(), s.CreateTime)
                        return
                }

                c.JSON(200, s)
        })

        unix.GET("/sec", func(c *gin.Context) {
                s := shareTime{}

                c.ShouldBindQuery(&s)

                if !testUT.Equal(s.UnixTime) {
                        c.String(500, "want %d got %d", testCT.Unix(), s.UnixTime)
                        return
                }

                c.JSON(200, s)

        })

        r.Run()
}

```

* Contraction variable scope
 2019-07-10 13:02:40 +08:00
Kirill Motkov
b1d607a899 Some code improvements (#1909) 
* strings.ToLower comparison changed to strings.EqualFold.
* Rewrite switch statement with only one case as if.
 2019-05-21 23:08:52 +08:00
guonaihong
8ee9d959a0 Now you can parse the inline lowercase start structure (#1893) 
* Now you can parse the inline lowercase start structure

package main

import (
	"encoding/json"
	"fmt"
	"github.com/gin-gonic/gin"
)

type appkey struct {
	Appkey string `json:"appkey" form:"appkey"`
}

type Query struct {
	Page int `json:"page" form:"page"`
	Size int `json:"size" form:"size"`
	appkey
}

func main() {

	router := gin.Default()
	router.POST("/login", func(c *gin.Context) {

		var q2 Query

		if c.ShouldBindQuery(&q2) == nil {
			c.JSON(200, &q2)
		}
	})
	router.Run(":8088")
}

http client:

old:
curl -X POST "127.0.0.1:8088/login?appkey=china&page=1&size=10"
{"page":1,"size":10,"appkey":""}

now:
curl -X POST "127.0.0.1:8088/login?appkey=china&page=1&size=10"
{"page":1,"size":10,"appkey":"china"}

* Modify judgment conditions
 2019-05-13 10:17:31 +08:00
Dmitry Kutakov
2e915f4e50 refactor(form_mapping.go): mapping multipart request (#1829) 
* refactor(form_mapping.go): mapping multipart request

* add checkers for a types to match with the setter interface

* form_mapping.go: rename method name on setter interface, add comments

* fix style of comments
 2019-04-02 09:01:34 +08:00
Boyi Wu
c16bfa7949 update for supporting file binding (#1264) 
update for supporting multipart form and file binding 

example:
```
type PhoptUploadForm struct {
	imgData    *multipart.FileHeader `form:"img_data" binding:"required"`
	ProjectID   string `form:"project_id" binding:"required"`
	Description string `form:"description binding:"required"`
}
```


ref: https://github.com/gin-gonic/gin/issues/1263
 2019-03-18 10:16:34 +08:00
Dmitry Kutakov
483f828bce add support arrays on mapping (#1797) 
* add support arrays on mapping

* not allow default value on array mapping
 2019-03-14 13:34:56 +08:00
田欧
a5dda62cdc
chore: use internal/json (#1791) 2019-03-05 06:46:18 +08:00
Dmitry Kutakov
805b2d4904 add support time.Duration on mapping (#1794) 2019-03-04 11:37:46 +08:00
Dmitry Kutakov
0d50ce8597 refactor(form_mapping.go): mapping ptr, struct and map (#1749) 
* refactor(form_mapping.go): mapping ptr, struct and map

* fix #1672 correct work with ptr - not create value if field is not set
* avoid allocations on strings.Split() - change to strings.Index()
* fix #610 tag value "-" is mean ignoring field
* struct fields mapped like json.Unmarshal
* map fields mapped like json.Unmarshal

* fix after @thinkerou review
 2019-03-03 14:39:43 +08:00
André Bazaglia
48f6c6137c allow ignoring field on form mapping (#1733) 2019-02-22 12:23:52 +08:00
Dmitry Kutakov
49e4b0c60c fix mapping inner structs with correct tag (#1718) 2018-12-28 09:57:09 +08:00
thinkerou
521d06c81d support bind uri param (#1612) 
* support bind uri (1)

* uri binding successful run

* fix vet warning: github.com/gin-gonic/gin/internal.Param composite literal uses unkeyed fields

* fix code style

* update function name

* fix test function signature

* add test for CanSet

* update readme and add test case

* remove internal.Params

* add coverage

* fix warning
 2018-11-22 09:29:48 +08:00
田欧
85f3e78abc chore: remove else instead of return/continue (#1502) 
As[ Effective Go](https://golang.org/doc/effective_go.html?#if) about `if` said, remove else statement instead of return/continue statement.
 2018-08-20 21:49:24 +08:00
Alexander Lokhman
7eb0f74b89 Set default time format in form binding (#1487) 2018-08-17 09:41:56 +08:00
chainhelen
5636afe02d fix bug, return err when failed binding bool (#1350) 
* fix bug, return err when failed binding bool

* add test, return err when failed binding bool
 2018-05-11 22:40:33 +08:00
田欧
bd4f73af67 support struct pointer (#1342) 
* support struct pointer

* add readme
 2018-05-01 14:24:18 +08:00