From fc07a2296babda3b2942b478953ffb6d72acae0f Mon Sep 17 00:00:00 2001 From: adityajai119 Date: Thu, 12 Nov 2026 17:45:14 +0530 Subject: [PATCH] fix(binding): leave file fields unset for an empty multipart file part Browsers send a file input with no file selected as a part with filename="" and an empty body. mime/multipart stores that part as a form value, so multipartRequest.TrySet found no files and fell back to setByForm, which bound a non-nil empty multipart.FileHeader to pointer fields and one empty entry to slices and arrays. binding:"required" then passed although no file was uploaded. Leave file-typed fields unset when the request has no files for the key, so an empty file part binds like a missing one. Fixes #2376 --- binding/multipart_form_mapping.go | 15 +++++++++++++++ binding/multipart_form_mapping_test.go | 25 +++++++++++++++++++++++++ 2 files changed, 40 insertions(+) diff --git a/binding/multipart_form_mapping.go b/binding/multipart_form_mapping.go index 4ebe8326..6c7dda4f 100644 --- a/binding/multipart_form_mapping.go +++ b/binding/multipart_form_mapping.go @@ -28,6 +28,9 @@ func (r *multipartRequest) TrySet(value reflect.Value, field reflect.StructField if files := r.MultipartForm.File[key]; len(files) != 0 { return setByMultipartFormFile(value, field, files) } + if isFileHeaderType(value.Type()) { + return false, nil + } return setByForm(value, field, r.MultipartForm.Value, key, opt) } @@ -72,3 +75,15 @@ func setArrayOfMultipartFormFiles(value reflect.Value, field reflect.StructField } return true, nil } + +var fileHeaderType = reflect.TypeOf(multipart.FileHeader{}) + +func isFileHeaderType(t reflect.Type) bool { + if t.Kind() == reflect.Slice || t.Kind() == reflect.Array { + t = t.Elem() + } + if t.Kind() == reflect.Ptr { + t = t.Elem() + } + return t == fileHeaderType +} diff --git a/binding/multipart_form_mapping_test.go b/binding/multipart_form_mapping_test.go index c93f2141..452c9769 100644 --- a/binding/multipart_form_mapping_test.go +++ b/binding/multipart_form_mapping_test.go @@ -69,6 +69,31 @@ func TestFormMultipartBindingBindTwoFiles(t *testing.T) { } } +func TestFormMultipartBindingBindEmptyFile(t *testing.T) { + var s struct { + FilePtr *multipart.FileHeader `form:"file"` + SliceValues []multipart.FileHeader `form:"file"` + SlicePtrs []*multipart.FileHeader `form:"file"` + ArrayPtrs [1]*multipart.FileHeader `form:"file"` + } + req := createRequestMultipartFiles(t, testFile{"file", "", nil}) + err := FormMultipart.Bind(req, &s) + require.NoError(t, err) + + assert.Nil(t, s.FilePtr) + assert.Nil(t, s.SliceValues) + assert.Nil(t, s.SlicePtrs) + assert.Nil(t, s.ArrayPtrs[0]) + + var required struct { + File *multipart.FileHeader `form:"file" binding:"required"` + } + req = createRequestMultipartFiles(t, testFile{"file", "", nil}) + err = FormMultipart.Bind(req, &required) + require.Error(t, err) + assert.Nil(t, required.File) +} + func TestFormMultipartBindingBindError(t *testing.T) { files := []testFile{ {"file", "file1", []byte("hello")},