From ec8d4ee42e28b3fa8d3ef4b35b104262f6b6fd53 Mon Sep 17 00:00:00 2001
From: "wu.sphinx" <wu.sphinx@gmail.com>
Date: Thu, 21 Dec 2017 22:25:17 +0800
Subject: [PATCH] check parameter in path

---
 gin.go                  |  8 ++++++++
 gin_integration_test.go | 19 +++++++++++++++++++
 2 files changed, 27 insertions(+)

diff --git a/gin.go b/gin.go
index edcb9193..5dea60fe 100644
--- a/gin.go
+++ b/gin.go
@@ -21,6 +21,7 @@ const (
 )
 
 var (
+	default400Body   = []byte("400 parameter invalid")
 	default404Body   = []byte("404 page not found")
 	default405Body   = []byte("405 method not allowed")
 	defaultAppEngine bool
@@ -346,6 +347,13 @@ func (engine *Engine) handleHTTPRequest(c *Context) {
 			root := t[i].root
 			// Find route in tree
 			handlers, params, tsr := root.getValue(path, c.Params, unescape)
+			// Check parameter in path
+			for _, item := range params {
+				if ":"+item.Key == item.Value {
+					serveError(c, http.StatusBadRequest, default400Body)
+					return
+				}
+			}
 			if handlers != nil {
 				c.handlers = handlers
 				c.Params = params
diff --git a/gin_integration_test.go b/gin_integration_test.go
index 52f78842..11a9ca62 100644
--- a/gin_integration_test.go
+++ b/gin_integration_test.go
@@ -133,3 +133,22 @@ func TestWithHttptestWithAutoSelectedPort(t *testing.T) {
 
 // 	testRequest(t, "http://localhost:8033/example")
 // }
+
+func TestParameterInPath(t *testing.T) {
+	router := New()
+
+	go func() {
+		router.GET("/user/:name", func(c *Context) { c.String(http.StatusOK, "it worked") })
+		assert.NoError(t, router.Run(":4123"))
+	}()
+	// have to wait for the goroutine to start and run the server
+	// otherwise the main thread will complete
+	time.Sleep(5 * time.Millisecond)
+
+	resp, err := http.Get("http://localhost:4123/user/:name")
+	assert.NoError(t, err)
+	defer resp.Body.Close()
+
+	assert.Equal(t, "400 Bad Request", resp.Status, "should get a 400")
+	testRequest(t, "http://localhost:4123/user/gin")
+}