feat: improve context.go test coverage

- Add TestContextGetRawDataNilBody to cover Request.Body nil case
- Add TestContextSetCookieData SameSiteDefaultMode test case
- Add TestContextInitFormCacheError to cover multipart form parse error
- Add TestContextShouldBindBodyWithReadError to cover body read error
- Add TestContextFormFileParseMultipartFormFailed to cover ParseMultipartForm error
- Add TestSaveUploadedFileChmodFailed to cover chmod error case

These additions improve overall test coverage for context.go functions.
This commit is contained in:
caplost 2025-07-22 15:23:26 +08:00
parent 93f51e4c68
commit e7943c03dc

View File

@ -20,6 +20,7 @@ import (
"os" "os"
"path/filepath" "path/filepath"
"reflect" "reflect"
"runtime"
"strconv" "strconv"
"strings" "strings"
"sync" "sync"
@ -106,6 +107,20 @@ func TestContextFormFileFailed(t *testing.T) {
assert.Nil(t, f) assert.Nil(t, f)
} }
func TestContextFormFileParseMultipartFormFailed(t *testing.T) {
c, _ := CreateTestContext(httptest.NewRecorder())
// Create a request with invalid multipart form data
body := strings.NewReader("invalid multipart data")
c.Request, _ = http.NewRequest(http.MethodPost, "/", body)
c.Request.Header.Set("Content-Type", "multipart/form-data; boundary=invalid")
c.engine.MaxMultipartMemory = 8 << 20
// This should trigger the error handling in FormFile when ParseMultipartForm fails
f, err := c.FormFile("file")
require.Error(t, err)
assert.Nil(t, f)
}
func TestContextMultipartForm(t *testing.T) { func TestContextMultipartForm(t *testing.T) {
buf := new(bytes.Buffer) buf := new(bytes.Buffer)
mw := multipart.NewWriter(buf) mw := multipart.NewWriter(buf)
@ -200,6 +215,43 @@ func TestSaveUploadedFileWithPermissionFailed(t *testing.T) {
require.Error(t, c.SaveUploadedFile(f, "test/permission_test", mode)) require.Error(t, c.SaveUploadedFile(f, "test/permission_test", mode))
} }
func TestSaveUploadedFileChmodFailed(t *testing.T) {
if runtime.GOOS == "windows" {
t.Skip("chmod test not applicable on Windows")
}
buf := new(bytes.Buffer)
mw := multipart.NewWriter(buf)
w, err := mw.CreateFormFile("file", "chmod_test")
require.NoError(t, err)
_, err = w.Write([]byte("chmod_test"))
require.NoError(t, err)
mw.Close()
c, _ := CreateTestContext(httptest.NewRecorder())
c.Request, _ = http.NewRequest(http.MethodPost, "/", buf)
c.Request.Header.Set("Content-Type", mw.FormDataContentType())
f, err := c.FormFile("file")
require.NoError(t, err)
assert.Equal(t, "chmod_test", f.Filename)
// Create a temporary directory with restricted permissions
tmpDir := t.TempDir()
restrictedDir := filepath.Join(tmpDir, "restricted")
require.NoError(t, os.MkdirAll(restrictedDir, 0o755))
// Make the directory read-only to trigger chmod failure
require.NoError(t, os.Chmod(restrictedDir, 0o444))
t.Cleanup(func() {
// Restore permissions for cleanup
os.Chmod(restrictedDir, 0o755)
})
// Try to save file with different permissions - this should fail on chmod
var mode fs.FileMode = 0o755
err = c.SaveUploadedFile(f, filepath.Join(restrictedDir, "subdir", "chmod_test"), mode)
// This might fail on MkdirAll or Chmod depending on the system
assert.Error(t, err)
}
func TestContextReset(t *testing.T) { func TestContextReset(t *testing.T) {
router := New() router := New()
c := router.allocateContext(0) c := router.allocateContext(0)
@ -810,6 +862,20 @@ func TestContextQueryAndPostForm(t *testing.T) {
assert.Empty(t, dicts) assert.Empty(t, dicts)
} }
func TestContextInitFormCacheError(t *testing.T) {
c, _ := CreateTestContext(httptest.NewRecorder())
// Create a request with invalid multipart form data
body := strings.NewReader("invalid multipart data")
c.Request, _ = http.NewRequest(http.MethodPost, "/", body)
c.Request.Header.Set("Content-Type", "multipart/form-data; boundary=invalid")
c.engine.MaxMultipartMemory = 8 << 20
// This should trigger the error handling in initFormCache
values, ok := c.GetPostFormArray("foo")
assert.False(t, ok)
assert.Empty(t, values)
}
func TestContextPostFormMultipart(t *testing.T) { func TestContextPostFormMultipart(t *testing.T) {
c, _ := CreateTestContext(httptest.NewRecorder()) c, _ := CreateTestContext(httptest.NewRecorder())
c.Request = createMultipartRequest() c.Request = createMultipartRequest()
@ -2291,6 +2357,31 @@ func TestContextBadAutoShouldBind(t *testing.T) {
assert.False(t, c.IsAborted()) assert.False(t, c.IsAborted())
} }
func TestContextShouldBindBodyWithReadError(t *testing.T) {
w := httptest.NewRecorder()
c, _ := CreateTestContext(w)
// Create a request with a body that will cause read error
c.Request, _ = http.NewRequest(http.MethodPost, "/", &errorReader{})
type testStruct struct {
Foo string `json:"foo"`
}
obj := testStruct{}
// This should trigger the error handling in ShouldBindBodyWith
err := c.ShouldBindBodyWith(&obj, binding.JSON)
assert.Error(t, err)
assert.Contains(t, err.Error(), "read error")
}
// errorReader is a helper struct that always returns an error when Read is called
type errorReader struct{}
func (e *errorReader) Read(p []byte) (n int, err error) {
return 0, errors.New("read error")
}
func TestContextShouldBindBodyWith(t *testing.T) { func TestContextShouldBindBodyWith(t *testing.T) {
type typeA struct { type typeA struct {
Foo string `json:"foo" xml:"foo" binding:"required"` Foo string `json:"foo" xml:"foo" binding:"required"`
@ -2761,6 +2852,17 @@ func TestContextGetRawData(t *testing.T) {
assert.Equal(t, "Fetch binary post data", string(data)) assert.Equal(t, "Fetch binary post data", string(data))
} }
func TestContextGetRawDataNilBody(t *testing.T) {
c, _ := CreateTestContext(httptest.NewRecorder())
c.Request, _ = http.NewRequest(http.MethodPost, "/", nil)
c.Request.Body = nil
data, err := c.GetRawData()
assert.Error(t, err)
assert.Nil(t, data)
assert.Contains(t, err.Error(), "cannot read nil body")
}
func TestContextRenderDataFromReader(t *testing.T) { func TestContextRenderDataFromReader(t *testing.T) {
w := httptest.NewRecorder() w := httptest.NewRecorder()
c, _ := CreateTestContext(w) c, _ := CreateTestContext(w)
@ -3349,4 +3451,22 @@ func TestContextSetCookieData(t *testing.T) {
setCookie := c.Writer.Header().Get("Set-Cookie") setCookie := c.Writer.Header().Get("Set-Cookie")
assert.Contains(t, setCookie, "SameSite=None") assert.Contains(t, setCookie, "SameSite=None")
}) })
// Test that SameSiteDefaultMode uses context's sameSite setting
t.Run("SameSite=Default uses context setting", func(t *testing.T) {
c, _ := CreateTestContext(httptest.NewRecorder())
c.SetSameSite(http.SameSiteStrictMode)
cookie := &http.Cookie{
Name: "user",
Value: "gin",
Path: "/",
Domain: "localhost",
Secure: true,
HttpOnly: true,
SameSite: http.SameSiteDefaultMode,
}
c.SetCookieData(cookie)
setCookie := c.Writer.Header().Get("Set-Cookie")
assert.Contains(t, setCookie, "SameSite=Strict")
})
} }