blackteay/gin
3
0
Fork 0
mirror of https://github.com/gin-gonic/gin.git synced 2026-07-12 05:51:12 +08:00
Code Issues Projects Releases Wiki Activity

test(context): use t.TempDir() for SaveUploadedFile permission test on WSL (#4709)

Browse Source 
* fix: change file creation to use c.Temp instead to work on wsl

* test(context): use t.TempDir() in SaveUploadedFile failure test for WSL

Mirror the WSL-portability fix applied to TestSaveUploadedFileWithPermission:
write under t.TempDir() instead of a relative path so the test does not depend
on the working directory's filesystem (drvfs reports 0o777 on WSL) and is
cleaned up automatically.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Bo-Yi Wu <appleboy.tw@gmail.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Pierre F. 2026-06-22 16:43:44 +02:00 committed by GitHub
parent 074b669a95
commit da1e108614
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
context_test.go
View File

@ -248,13 +248,11 @@ func TestSaveUploadedFileWithPermission(t *testing.T) {
require.NoError(t, err) require.NoError(t, err)
assert.Equal(t, "permission_test", f.Filename) assert.Equal(t, "permission_test", f.Filename)
var mode fs.FileMode = 0o755 var mode fs.FileMode = 0o755
require.NoError(t, c.SaveUploadedFile(f, "permission_test", mode)) dst := filepath.Join(t.TempDir(), "subdir", "permission_test")
t.Cleanup(func() { require.NoError(t, c.SaveUploadedFile(f, dst, mode))
assert.NoError(t, os.Remove("permission_test")) info, err := os.Stat(filepath.Dir(dst))
})
info, err := os.Stat(filepath.Dir("permission_test"))
require.NoError(t, err) require.NoError(t, err)
assert.Equal(t, info.Mode().Perm(), mode) assert.Equal(t, mode, info.Mode().Perm())
} }
func TestSaveUploadedFileWithPermissionFailed(t *testing.T) { func TestSaveUploadedFileWithPermissionFailed(t *testing.T) {
@ -272,7 +270,8 @@ func TestSaveUploadedFileWithPermissionFailed(t *testing.T) {
require.NoError(t, err) require.NoError(t, err)
assert.Equal(t, "permission_test", f.Filename) assert.Equal(t, "permission_test", f.Filename)
var mode fs.FileMode = 0o644 var mode fs.FileMode = 0o644
require.Error(t, c.SaveUploadedFile(f, "test/permission_test", mode)) dst := filepath.Join(t.TempDir(), "test", "permission_test")
require.Error(t, c.SaveUploadedFile(f, dst, mode))
} }
func TestContextReset(t *testing.T) { func TestContextReset(t *testing.T) {