From cdaceb18a5c6ea43e88438de8f1bfad034b84408 Mon Sep 17 00:00:00 2001 From: Saksham Arya Date: Thu, 26 Jun 2025 17:04:14 +0530 Subject: [PATCH] comment --- context.go | 4 ++-- context_test.go | 9 ++++++--- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/context.go b/context.go index 3fbf4af2..d5b1cd27 100644 --- a/context.go +++ b/context.go @@ -979,8 +979,8 @@ func (c *Context) IsWebsocket() bool { } func (c *Context) requestHeader(key string) string { - c.hmu.Lock() - defer c.hmu.Unlock() + c.hmu.RLock() + defer c.hmu.RUnlock() return c.Request.Header.Get(key) } diff --git a/context_test.go b/context_test.go index 5cf56718..069ec195 100644 --- a/context_test.go +++ b/context_test.go @@ -27,12 +27,13 @@ import ( "time" "github.com/gin-contrib/sse" - "github.com/gin-gonic/gin/binding" - "github.com/gin-gonic/gin/codec/json" - testdata "github.com/gin-gonic/gin/testdata/protoexample" "github.com/stretchr/testify/assert" "github.com/stretchr/testify/require" "google.golang.org/protobuf/proto" + + "github.com/gin-gonic/gin/binding" + "github.com/gin-gonic/gin/codec/json" + testdata "github.com/gin-gonic/gin/testdata/protoexample" ) var _ context.Context = (*Context)(nil) @@ -3422,6 +3423,8 @@ func TestContextSetCookieData(t *testing.T) { setCookie := c.Writer.Header().Get("Set-Cookie") assert.Contains(t, setCookie, "SameSite=None") }) +} + func TestParallelHeaderWrite(t *testing.T) { c, _ := CreateTestContext(httptest.NewRecorder()) wg := sync.WaitGroup{}