blackteay/gin
3
0
Fork 0
mirror of https://github.com/gin-gonic/gin.git synced 2026-09-04 14:49:27 +08:00
Code Issues Projects Releases Wiki Activity

Merge a2a45467de7d98f73f676a3eeba4b7c4a5b50bdf into dcaa4296d111981ffb31ac3eba90bb63e1eb5ab9

Browse Source
This commit is contained in:
Henry 2026-08-16 05:11:29 +00:00 committed by GitHub
commit c184b1e67c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
context.go
View File

@ -1208,6 +1208,10 @@ func (c *Context) Render(code int, r render.Render) {
return return
} }
if c.Writer.Written() {
debugPrint("[WARNING] Response body has already been written. Wanted to override response.")
}
if err := r.Render(c.Writer); err != nil { if err := r.Render(c.Writer); err != nil {
// Pushing error to c.Errors // Pushing error to c.Errors
_ = c.Error(err) _ = c.Error(err)

13
middleware_test.go
View File

@ -251,3 +251,16 @@ func TestMiddlewareWrite(t *testing.T) {
assert.Equal(t, http.StatusBadRequest, w.Code) assert.Equal(t, http.StatusBadRequest, w.Code)
assert.Equal(t, strings.ReplaceAll("hola\n<map><foo>bar</foo></map>{\"foo\":\"bar\"}{\"foo\":\"bar\"}event:test\ndata:message\n\n", " ", ""), strings.ReplaceAll(w.Body.String(), " ", "")) assert.Equal(t, strings.ReplaceAll("hola\n<map><foo>bar</foo></map>{\"foo\":\"bar\"}{\"foo\":\"bar\"}event:test\ndata:message\n\n", " ", ""), strings.ReplaceAll(w.Body.String(), " ", ""))
} }
func TestMultipleResponseWritesWarning(t *testing.T) {
router := New()
router.GET("/", func(c *Context) {
c.String(http.StatusOK, "first\n")
c.String(http.StatusOK, "second\n")
})
w := PerformRequest(router, http.MethodGet, "/")
assert.Equal(t, http.StatusOK, w.Code)
assert.Equal(t, "first\nsecond\n", w.Body.String())
}